mbox

[RFC,0/2] U-boot refactor

Message ID 20211115160642.765371-1-Vijaikumar_Kanagarajan@mentor.com
State Superseded, archived
Headers show

Message

Vijai Kumar K Nov. 15, 2021, 6:06 a.m. UTC 
Hi,

This series refactors u-boot recipe to build selective packages
based on DEB_BUILD_PROFILES.

This solves 2 problems(kind of related).

1. Tools were always built irrespective of whether we ship them or not.
2. libssl-dev package is needed only when we cross compile tools.
   Having this change, makes sure the dependency is only included when
   it is actually needed.

P1 drops the U_BOOT_TOOLS_PACKAGE variable and introduces
U_BOOT_BUILD_PROFILES in which we can specify which package to
build(tools, dev, config).

P2 makes sure libssl-dev is included only when it is needed.


Thanks,
Vijai Kumar K


Vijai Kumar K (2):
  u-boot: Switch to use DEB_BUILD_PROFILES
  meta/u-boot: Include libssl-dev only when building tools

 .../u-boot/u-boot-de0-nano-soc_2021.10.bb     |  3 +-
 .../u-boot/u-boot-stm32mp15x_2021.10.bb       |  2 ++
 .../u-boot/files/debian/control.tmpl          | 13 ++++++++
 meta/recipes-bsp/u-boot/files/debian/rules    |  9 +++++-
 meta/recipes-bsp/u-boot/u-boot-custom.inc     | 32 ++++++-------------
 5 files changed, 34 insertions(+), 25 deletions(-)

Comments

vijai kumar Nov. 15, 2021, 4:10 p.m. UTC | #1 
On Mon, Nov 15, 2021 at 9:37 PM Vijai Kumar K
<Vijaikumar_Kanagarajan@mentor.com> wrote:
>
> Hi,
>
> This series refactors u-boot recipe to build selective packages
> based on DEB_BUILD_PROFILES.
>
> This solves 2 problems(kind of related).
>
> 1. Tools were always built irrespective of whether we ship them or not.
> 2. libssl-dev package is needed only when we cross compile tools.
>    Having this change, makes sure the dependency is only included when
>    it is actually needed.
>
> P1 drops the U_BOOT_TOOLS_PACKAGE variable and introduces
> U_BOOT_BUILD_PROFILES in which we can specify which package to
> build(tools, dev, config).
>
> P2 makes sure libssl-dev is included only when it is needed.

Ah. This already needs V2. Need to take care of the below line
u-boot-custom.inc:13:PROVIDES += "${@'u-boot-tools' if
d.getVar('U_BOOT_TOOLS_PACKAGE') == '1' else ''}"

Will wait for review comments and club the changes, if any.

Thanks,
Vijai Kumar K

>
>
> Thanks,
> Vijai Kumar K
>
>
> Vijai Kumar K (2):
>   u-boot: Switch to use DEB_BUILD_PROFILES
>   meta/u-boot: Include libssl-dev only when building tools
>
>  .../u-boot/u-boot-de0-nano-soc_2021.10.bb     |  3 +-
>  .../u-boot/u-boot-stm32mp15x_2021.10.bb       |  2 ++
>  .../u-boot/files/debian/control.tmpl          | 13 ++++++++
>  meta/recipes-bsp/u-boot/files/debian/rules    |  9 +++++-
>  meta/recipes-bsp/u-boot/u-boot-custom.inc     | 32 ++++++-------------
>  5 files changed, 34 insertions(+), 25 deletions(-)
>
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20211115160642.765371-1-Vijaikumar_Kanagarajan%40mentor.com.
Vijai Kumar K Nov. 16, 2021, 9:51 a.m. UTC | #2 
Changes since v1:
 - Fix PROVIDES variable
 - Enable dev by default

CI Job running at
http://ci.isar-build.org:8080/job/isar_vkk_devel/98/console

Vijai Kumar K (2):
  u-boot: Switch to use DEB_BUILD_PROFILES
  meta/u-boot: Include libssl-dev only when building tools

 .../u-boot/u-boot-de0-nano-soc_2021.10.bb     |  2 +-
 .../u-boot/files/debian/control.tmpl          | 13 ++++++
 meta/recipes-bsp/u-boot/files/debian/rules    |  9 +++-
 meta/recipes-bsp/u-boot/u-boot-custom.inc     | 41 +++++++------------
 4 files changed, 37 insertions(+), 28 deletions(-)