| Message ID | CAJGKYO6sqJRShhcjhJzEN7ffGhTZ6HvCVGaZ5EgGwejO4NpPSw@mail.gmail.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | [1/1] aesthetic changes in module.inc | expand |
18.09.2022 23:54, Roberto A. Foglietta wrote: > Hi all, > > nothing else than an aesthetic changes in module.inc > > Cheers, R- Hello Roberto, Despite the fact that both versions work, the original one looks more readable. There is no need in complicating git blame history for such a cosmetic change. This one rejected.
> > This one rejected. > > Ok, thanks. R-
Il Ven 23 Set 2022, 15:36 Anton Mikanovich <amikan@ilbers.de> ha scritto: > 18.09.2022 23:54, Roberto A. Foglietta wrote: > > Hi all, > > nothing else than an aesthetic changes in module.inc > > Cheers, R- > > Hello Roberto, > > Despite the fact that both versions work, the original one looks more > readable. > There is no need in complicating git blame history for such a cosmetic > change. > This one rejected. > Just an aesthetic consideration: original script open and close a file descriptor each time it does a for cicle. My suggestion, open and close a single time the that file descriptor. Aesthetic, unless you have to go to the moon but then no bash/shell for sure. 😊 Cheers, R- >
From a1200eb45dd833f0d42e162c46080ecdd1dd3900 Mon Sep 17 00:00:00 2001 From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com> Date: Sun, 18 Sep 2022 22:43:25 +0200 Subject: [PATCH] aesthetic changes in module.inc Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com> --- meta/recipes-kernel/linux-module/module.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc index b20ec32..0a722b6 100644 --- a/meta/recipes-kernel/linux-module/module.inc +++ b/meta/recipes-kernel/linux-module/module.inc @@ -33,6 +33,6 @@ do_prepare_build() { cp -r ${WORKDIR}/debian ${S}/ for module in ${AUTOLOAD}; do - echo "echo $module >> /etc/modules" >> ${S}/debian/postinst - done + echo "echo $module >> /etc/modules" + done >> ${S}/debian/postinst } -- 2.34.1