Fail on errors in chroot subshell

Message ID 2d61f5bf-f945-a13e-4c4c-305bd7c39ecc@siemens.com
State Superseded, archived
Headers show
Series Fail on errors in chroot subshell | expand

Commit Message

Tobias Schaffner Oct. 25, 2022, 8:09 a.m. UTC
Let the chroot subshell in the image locales extension fail on errors.

Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
---
  meta/classes/image-locales-extension.bbclass | 1 +
  1 file changed, 1 insertion(+)

Comments

Jan Kiszka Oct. 25, 2022, 8:13 a.m. UTC | #1
On 25.10.22 10:09, Schaffner, Tobias wrote:
> Let the chroot subshell in the image locales extension fail on errors.
> 
> Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
> ---
>   meta/classes/image-locales-extension.bbclass | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/image-locales-extension.bbclass b/meta/classes/image-locales-extension.bbclass
> index 2db6d4a..01163bb 100644
> --- a/meta/classes/image-locales-extension.bbclass
> +++ b/meta/classes/image-locales-extension.bbclass
> @@ -77,6 +77,7 @@ __EOF__
>   
>           # Enter image and trigger locales config and localepurge:
>           chroot '${ROOTFSDIR}' /bin/sh <<'EOSH'
> +            set -e
>   
>               echo 'running locale debconf-set-selections'
>               debconf-set-selections /tmp/locale.debconf

Broken indention - possibly a sign more more formatting issues?

Jan

Patch

diff --git a/meta/classes/image-locales-extension.bbclass b/meta/classes/image-locales-extension.bbclass
index 2db6d4a..01163bb 100644
--- a/meta/classes/image-locales-extension.bbclass
+++ b/meta/classes/image-locales-extension.bbclass
@@ -77,6 +77,7 @@  __EOF__
  
          # Enter image and trigger locales config and localepurge:
          chroot '${ROOTFSDIR}' /bin/sh <<'EOSH'
+            set -e
  
              echo 'running locale debconf-set-selections'
              debconf-set-selections /tmp/locale.debconf