rootfs class lock undefined in corner cases fix

Message ID 20230104185604.2542129-1-roberto.foglietta@gmail.com
State Superseded, archived
Headers show
Series rootfs class lock undefined in corner cases fix | expand

Commit Message

Roberto A. Foglietta Jan. 4, 2023, 6:56 p.m. UTC
From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>

Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
---
 meta/classes/rootfs.bbclass | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Roberto A. Foglietta Jan. 4, 2023, 7:01 p.m. UTC | #1
On Wed, 4 Jan 2023 at 19:56, <roberto.foglietta@gmail.com> wrote:
>
> From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
>

Finally, I made my way with a reliable SMTP for git-send-email.

Best regards, R-
Henning Schild Jan. 4, 2023, 8:20 p.m. UTC | #2
Am Wed, 4 Jan 2023 20:01:05 +0100
schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:

> On Wed, 4 Jan 2023 at 19:56, <roberto.foglietta@gmail.com> wrote:
> >
> > From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
> >  
> 
> Finally, I made my way with a reliable SMTP for git-send-email.

Cool stuff, i almost which i could give you emojis and markdown as reply

Henning

> Best regards, R-
>

Patch

diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index b3faade..63735d4 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -198,11 +198,14 @@  python do_rootfs_install() {
         if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == "acquire-before":
             lock = bb.utils.lockfile(d.getVar("REPO_ISAR_DIR") + "/isar.lock",
                                      shared=True)
+        else:
+            lock = ""
 
         bb.build.exec_func(cmd, d)
 
         if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == "release-after":
-            bb.utils.unlockfile(lock)
+            if (lock != ""):
+                bb.utils.unlockfile(lock)
     progress_reporter.finish()
 }
 addtask rootfs_install before do_rootfs_postprocess after do_unpack