[1/6] meta-isar: Add bookworm config for de0-nano-soc

Message ID 20230829061627.1040720-1-srinuvasan_a@mentor.com
State Superseded, archived
Headers show
Series [1/6] meta-isar: Add bookworm config for de0-nano-soc | expand

Commit Message

Srinuvasan Arjunan Aug. 29, 2023, 6:16 a.m. UTC
From: Srinuvasan A <srinuvasan.a@siemens.com>

Add bookworm config for de0-nano-soc target.

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 meta-isar/conf/local.conf.sample                      | 1 +
 meta-isar/conf/multiconfig/de0-nano-soc-bookworm.conf | 5 +++++
 2 files changed, 6 insertions(+)
 create mode 100644 meta-isar/conf/multiconfig/de0-nano-soc-bookworm.conf

Comments

Uladzimir Bely Sept. 14, 2023, 5:07 a.m. UTC | #1
On Tue, 2023-08-29 at 11:46 +0530, Srinuvasan Arjunan wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> Add bookworm config for de0-nano-soc target.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>

This one and the following patches demand on adding to the testsuite.

The only question is what would be better to do - just add them to
avocado tests (and increase total build time) or add them as a
replacement of corresponding "buster" targets (and deprecate buster
multiconfigs).
Uladzimir Bely Sept. 25, 2023, 6:29 a.m. UTC | #2
On Tue, 2023-08-29 at 11:46 +0530, Srinuvasan Arjunan wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> Add bookworm config for de0-nano-soc target.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta-isar/conf/local.conf.sample                      | 1 +
>  meta-isar/conf/multiconfig/de0-nano-soc-bookworm.conf | 5 +++++
>  2 files changed, 6 insertions(+)
>  create mode 100644 meta-isar/conf/multiconfig/de0-nano-soc-
> bookworm.conf
> 
> diff --git a/meta-isar/conf/local.conf.sample b/meta-
> isar/conf/local.conf.sample
> index 762709f..2451598 100644
> --- a/meta-isar/conf/local.conf.sample
> +++ b/meta-isar/conf/local.conf.sample
> @@ -62,6 +62,7 @@ BBMULTICONFIG = " \
>      bananapi-bullseye \
>      de0-nano-soc-buster \
>      de0-nano-soc-bullseye \
> +    de0-nano-soc-bookworm \
>      hikey-bullseye \
>      hikey-bookworm \
>      imx6-sabrelite-buster \

This patch (and p2-p4) adds a new record to local.conf.sample only in
"meta-isar" layer. While p5-p6 do the same for both "meta-isar" and
"meta-test".

To avoid such kind of divergence in the future, now "meta-
isar/conf/mc.conf" is used as an only place to keep BBMULTICONFIG
variable, for both "meta-isar" and "meta-test" layers.

Also, p3 is not needed anymore since the nanopi bookworm multiconfig
was handled by other patchset.

> diff --git a/meta-isar/conf/multiconfig/de0-nano-soc-bookworm.conf
> b/meta-isar/conf/multiconfig/de0-nano-soc-bookworm.conf
> new file mode 100644
> index 0000000..15436aa
> --- /dev/null
> +++ b/meta-isar/conf/multiconfig/de0-nano-soc-bookworm.conf
> @@ -0,0 +1,5 @@
> +# This software is a part of ISAR.
> +# Copyright (C) 2023 ilbers GmbH
> +
> +MACHINE ?= "de0-nano-soc"
> +DISTRO ?= "debian-bookworm"
> -- 
> 2.34.1
>

Patch

diff --git a/meta-isar/conf/local.conf.sample b/meta-isar/conf/local.conf.sample
index 762709f..2451598 100644
--- a/meta-isar/conf/local.conf.sample
+++ b/meta-isar/conf/local.conf.sample
@@ -62,6 +62,7 @@  BBMULTICONFIG = " \
     bananapi-bullseye \
     de0-nano-soc-buster \
     de0-nano-soc-bullseye \
+    de0-nano-soc-bookworm \
     hikey-bullseye \
     hikey-bookworm \
     imx6-sabrelite-buster \
diff --git a/meta-isar/conf/multiconfig/de0-nano-soc-bookworm.conf b/meta-isar/conf/multiconfig/de0-nano-soc-bookworm.conf
new file mode 100644
index 0000000..15436aa
--- /dev/null
+++ b/meta-isar/conf/multiconfig/de0-nano-soc-bookworm.conf
@@ -0,0 +1,5 @@ 
+# This software is a part of ISAR.
+# Copyright (C) 2023 ilbers GmbH
+
+MACHINE ?= "de0-nano-soc"
+DISTRO ?= "debian-bookworm"