debianize: Introduce DEBIAN_PROVIDES and DEBIAN_REPLACES

Message ID 20240213125605.1964664-1-srinuvasan_a@mentor.com
State Superseded, archived
Headers show
Series debianize: Introduce DEBIAN_PROVIDES and DEBIAN_REPLACES | expand

Commit Message

Srinuvasan Arjunan Feb. 13, 2024, 12:56 p.m. UTC
From: Srinuvasan <srinuvasan.a@siemens.com>

Allow setting the Provides and Replaces field for auto generated control files,
with this changes now user can configure the provides and replaces in the debian/control file.

Recipes can simply setting the Provides and Replaces field now by defining the
DEBIAN_PROVIDES and DEBIAN_REPLACES variable.

Signed-off-by: Srinuvasan <srinuvasan.a@siemens.com>
---
 meta/classes/debianize.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Florian Bezdeka Feb. 13, 2024, 6:48 p.m. UTC | #1
On Tue, 2024-02-13 at 18:26 +0530, Srinuvasan Arjunan wrote:
> From: Srinuvasan <srinuvasan.a@siemens.com>

Something is wrong with your mail setup. The From: header 
is "Srinuvasan Arjunan <srinuvasan_a@mentor.com>" while your singed-
off-by and the From: part of the body is set to "Srinuvasan
<srinuvasan.a@siemens.com>"

> 
> Allow setting the Provides and Replaces field for auto generated control files,
> with this changes now user can configure the provides and replaces in the debian/control file.
> 
> Recipes can simply setting the Provides and Replaces field now by defining the
> DEBIAN_PROVIDES and DEBIAN_REPLACES variable.
> 
> Signed-off-by: Srinuvasan <srinuvasan.a@siemens.com>
Uladzimir Bely Feb. 16, 2024, 6:38 a.m. UTC | #2
On Tue, 2024-02-13 at 18:26 +0530, Srinuvasan Arjunan wrote:
> From: Srinuvasan <srinuvasan.a@siemens.com>
> 
> Allow setting the Provides and Replaces field for auto generated
> control files,
> with this changes now user can configure the provides and replaces in
> the debian/control file.
> 
> Recipes can simply setting the Provides and Replaces field now by
> defining the
> DEBIAN_PROVIDES and DEBIAN_REPLACES variable.
> 
> Signed-off-by: Srinuvasan <srinuvasan.a@siemens.com>
> ---
>  meta/classes/debianize.bbclass | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/classes/debianize.bbclass
> b/meta/classes/debianize.bbclass
> index 16f3638d..72afea88 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -8,6 +8,8 @@ CHANGELOG_V ??= "${PV}"
>  DPKG_ARCH ??= "any"
>  DEBIAN_BUILD_DEPENDS ??= ""
>  DEBIAN_DEPENDS ??= ""
> +DEBIAN_PROVIDES ??= ""
> +DEBIAN_REPLACES ??= ""

This looks like considering my comment in the same patch from Cedric
Hombourger
(https://groups.google.com/g/isar-users/c/fpPkw0WxQno/m/CLIq3fo8BwAJ),
but this patch misses original modification of user_manual.md.

>  DEBIAN_CONFLICTS ??= ""
>  DEBIAN_MULTI_ARCH ??= "no"
>  DESCRIPTION ??= "must not be empty"
> @@ -77,6 +79,8 @@ Build-Depends: debhelper (>= ${compat}),
> ${DEBIAN_BUILD_DEPENDS}
>  Package: ${BPN}
>  Architecture: ${DPKG_ARCH}
>  Depends: ${DEBIAN_DEPENDS}
> +Provides: ${DEBIAN_PROVIDES}
> +Replaces: ${DEBIAN_REPLACES}
>  Conflicts: ${DEBIAN_CONFLICTS}
>  Multi-Arch: ${DEBIAN_MULTI_ARCH}
>  Description: ${DESCRIPTION}
> -- 
> 2.39.2
>

Patch

diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
index 16f3638d..72afea88 100644
--- a/meta/classes/debianize.bbclass
+++ b/meta/classes/debianize.bbclass
@@ -8,6 +8,8 @@  CHANGELOG_V ??= "${PV}"
 DPKG_ARCH ??= "any"
 DEBIAN_BUILD_DEPENDS ??= ""
 DEBIAN_DEPENDS ??= ""
+DEBIAN_PROVIDES ??= ""
+DEBIAN_REPLACES ??= ""
 DEBIAN_CONFLICTS ??= ""
 DEBIAN_MULTI_ARCH ??= "no"
 DESCRIPTION ??= "must not be empty"
@@ -77,6 +79,8 @@  Build-Depends: debhelper (>= ${compat}), ${DEBIAN_BUILD_DEPENDS}
 Package: ${BPN}
 Architecture: ${DPKG_ARCH}
 Depends: ${DEBIAN_DEPENDS}
+Provides: ${DEBIAN_PROVIDES}
+Replaces: ${DEBIAN_REPLACES}
 Conflicts: ${DEBIAN_CONFLICTS}
 Multi-Arch: ${DEBIAN_MULTI_ARCH}
 Description: ${DESCRIPTION}