| Message ID | 20240506071705.940343-1-srinuvasan.a@siemens.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | meta/classes/template: add BPN to default TEMPLATE_VARS | expand |
On Monday, May 6, 2024 at 12:46:47 PM UTC+5:30 srinuv...@siemens.com wrote: From: Srinuvasan A <srinuv...@siemens.com> Add the base recipe name (BPN) to default template variables, this would be helpful to replace the base recipe name in template file if the recipe configured BPN across the builds. Signed-off-by: Srinuvasan A <srinuv...@siemens.com> --- meta/classes/template.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/template.bbclass b/meta/classes/template.bbclass index 7f8d5d8f..37e43196 100644 --- a/meta/classes/template.bbclass +++ b/meta/classes/template.bbclass @@ -4,7 +4,7 @@ # SPDX-License-Identifier: MIT TEMPLATE_FILES ?= "" -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH" +TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH" do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}" python do_transform_template() {
On Mon, 2024-05-06 at 22:24 -0700, Srinuvasan Arjunan wrote: > > > On Monday, May 6, 2024 at 12:46:47 PM UTC+5:30 srinuv...@siemens.com > wrote: > > From: Srinuvasan A <srinuv...@siemens.com> > > > > Add the base recipe name (BPN) to default template variables, this > > would be > > helpful to replace the base recipe name in template file if the > > recipe > > configured BPN across the builds. > > > > Signed-off-by: Srinuvasan A <srinuv...@siemens.com> > > --- > > meta/classes/template.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/classes/template.bbclass > > b/meta/classes/template.bbclass > > index 7f8d5d8f..37e43196 100644 > > --- a/meta/classes/template.bbclass > > +++ b/meta/classes/template.bbclass > > @@ -4,7 +4,7 @@ > > # SPDX-License-Identifier: MIT > > > > TEMPLATE_FILES ?= "" > > -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER > > DISTRO_ARCH" > > +TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER > > DISTRO_ARCH" > > > > do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}" > > python do_transform_template() { > > -- > > 2.34.1 > > > Hi All, > > Any feedback on this changes? > > Many thanks, > Srinu Hello. The patch is being tested under CI, with other patches. If there are no any issues and/or discussions on mail list, it will be applied as usually.
On 07.05.24 07:24, Srinuvasan Arjunan wrote: > > > On Monday, May 6, 2024 at 12:46:47 PM UTC+5:30 srinuv...@siemens.com wrote: > > From: Srinuvasan A <srinuv...@siemens.com> > > Add the base recipe name (BPN) to default template variables, this > would be > helpful to replace the base recipe name in template file if the recipe > configured BPN across the builds. > > Signed-off-by: Srinuvasan A <srinuv...@siemens.com> > --- > meta/classes/template.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/template.bbclass > b/meta/classes/template.bbclass > index 7f8d5d8f..37e43196 100644 > --- a/meta/classes/template.bbclass > +++ b/meta/classes/template.bbclass > @@ -4,7 +4,7 @@ > # SPDX-License-Identifier: MIT > > TEMPLATE_FILES ?= "" > -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH" > +TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER > DISTRO_ARCH" > > do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}" > python do_transform_template() { > -- > 2.34.1 > > > Hi All, > > Any feedback on this changes? > Please be more patient, specifically with feature extensions, even if they are small and kind of obvious as this one. Thanks, Jan
On Tuesday, May 7, 2024 at 3:00:00 PM UTC+5:30 Jan Kiszka wrote: On 07.05.24 07:24, Srinuvasan Arjunan wrote: > > > On Monday, May 6, 2024 at 12:46:47 PM UTC+5:30 srinuv...@siemens.com wrote: > > From: Srinuvasan A <srinuv...@siemens.com> > > Add the base recipe name (BPN) to default template variables, this > would be > helpful to replace the base recipe name in template file if the recipe > configured BPN across the builds. > > Signed-off-by: Srinuvasan A <srinuv...@siemens.com> > --- > meta/classes/template.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/template.bbclass > b/meta/classes/template.bbclass > index 7f8d5d8f..37e43196 100644 > --- a/meta/classes/template.bbclass > +++ b/meta/classes/template.bbclass > @@ -4,7 +4,7 @@ > # SPDX-License-Identifier: MIT > > TEMPLATE_FILES ?= "" > -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH" > +TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER > DISTRO_ARCH" > > do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}" > python do_transform_template() { > -- > 2.34.1 > > > Hi All, > > Any feedback on this changes? > Please be more patient, specifically with feature extensions, even if they are small and kind of obvious as this one. Thanks, Jan Sure jan, thanks for the update. Many thanks, Srinu
On Mon, 2024-05-06 at 12:47 +0530, srinuvasan.a via isar-users wrote: > From: Srinuvasan A <srinuvasan.a@siemens.com> > > Add the base recipe name (BPN) to default template variables, this > would be > helpful to replace the base recipe name in template file if the > recipe > configured BPN across the builds. > > Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> > --- > meta/classes/template.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/template.bbclass > b/meta/classes/template.bbclass > index 7f8d5d8f..37e43196 100644 > --- a/meta/classes/template.bbclass > +++ b/meta/classes/template.bbclass > @@ -4,7 +4,7 @@ > # SPDX-License-Identifier: MIT > > TEMPLATE_FILES ?= "" > -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH" > +TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER > DISTRO_ARCH" > > do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}" > python do_transform_template() { > -- > 2.34.1 > Applied to next, thanks.
diff --git a/meta/classes/template.bbclass b/meta/classes/template.bbclass index 7f8d5d8f..37e43196 100644 --- a/meta/classes/template.bbclass +++ b/meta/classes/template.bbclass @@ -4,7 +4,7 @@ # SPDX-License-Identifier: MIT TEMPLATE_FILES ?= "" -TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH" +TEMPLATE_VARS ?= "BPN PN PV DESCRIPTION HOMEPAGE MAINTAINER DISTRO_ARCH" do_transform_template[vardeps] = "TEMPLATE_FILES ${TEMPLATE_VARS}" python do_transform_template() {