diff mbox series

meta/classes/initramfs: remove unused variable

Message ID 20240509105935.4691-1-srinuvasan.a@siemens.com
State Accepted, archived
Headers show
Series meta/classes/initramfs: remove unused variable | expand

Commit Message

Arjunan, Srinu May 9, 2024, 10:59 a.m. UTC 
From: Srinuvasan A <srinuvasan.a@siemens.com>

The variable INITRAMFS_IMAGE_FILE is nowhere used across
the repository, hence remove the unused variable.

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 meta/classes/initramfs.bbclass | 1 -
 1 file changed, 1 deletion(-)

Comments

Srinuvasan Arjunan May 21, 2024, 7:19 a.m. UTC | #1 
Hi All,

            Any Update?

Thanks,
Srinu.
Jan Kiszka May 21, 2024, 8:32 a.m. UTC | #2 
On 09.05.24 12:59, srinuvasan.a@siemens.com wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> The variable INITRAMFS_IMAGE_FILE is nowhere used across
> the repository, hence remove the unused variable.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/classes/initramfs.bbclass | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/classes/initramfs.bbclass b/meta/classes/initramfs.bbclass
> index 5b5943f2..6886b95a 100644
> --- a/meta/classes/initramfs.bbclass
> +++ b/meta/classes/initramfs.bbclass
> @@ -14,7 +14,6 @@ INITRAMFS_INSTALL ?= ""
>  INITRAMFS_PREINSTALL ?= ""
>  INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
>  INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
> -INITRAMFS_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE_NAME}"
>  
>  # Install proper kernel
>  INITRAMFS_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME")) if d.getVar("KERNEL_NAME") else ""}"

Looks good. Would look even better when pointing to the commit that
obsoleted it (4b3382a98f3a).

Jan
Uladzimir Bely May 28, 2024, 6:02 a.m. UTC | #3 
On Thu, 2024-05-09 at 16:29 +0530, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> The variable INITRAMFS_IMAGE_FILE is nowhere used across
> the repository, hence remove the unused variable.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/classes/initramfs.bbclass | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/classes/initramfs.bbclass
> b/meta/classes/initramfs.bbclass
> index 5b5943f2..6886b95a 100644
> --- a/meta/classes/initramfs.bbclass
> +++ b/meta/classes/initramfs.bbclass
> @@ -14,7 +14,6 @@ INITRAMFS_INSTALL ?= ""
>  INITRAMFS_PREINSTALL ?= ""
>  INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
>  INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
> -INITRAMFS_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE_NAME}"
>  
>  # Install proper kernel
>  INITRAMFS_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME"))
> if d.getVar("KERNEL_NAME") else ""}"
> -- 
> 2.34.1
> 

Applied (with a slight commit message modification pointing to
appropriate commit hash) to next, thanks.
diff mbox series

Patch

diff --git a/meta/classes/initramfs.bbclass b/meta/classes/initramfs.bbclass
index 5b5943f2..6886b95a 100644
--- a/meta/classes/initramfs.bbclass
+++ b/meta/classes/initramfs.bbclass
@@ -14,7 +14,6 @@  INITRAMFS_INSTALL ?= ""
 INITRAMFS_PREINSTALL ?= ""
 INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
 INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
-INITRAMFS_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE_NAME}"
 
 # Install proper kernel
 INITRAMFS_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME")) if d.getVar("KERNEL_NAME") else ""}"