[1/1] do not forward SDE into sbuild environment

Message ID 20240517150505.569940-1-felix.moessbauer@siemens.com
State Accepted, archived
Headers show
Series [1/1] do not forward SDE into sbuild environment | expand

Commit Message

MOESSBAUER, Felix May 17, 2024, 3:05 p.m. UTC
The SOURCE_DATE_EPOCH inside the sbuild environment is automatically set
according to the debian changelog. By that, we do not need to explicitly
forward a possibly different, but ignored value into the sbuild
environment.

This patch also fixes a warning about converting the SDE to a template.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/classes/dpkg.bbclass | 1 +
 1 file changed, 1 insertion(+)

Comments

Jan Kiszka May 17, 2024, 3:28 p.m. UTC | #1
On 17.05.24 17:05, Felix Moessbauer wrote:
> The SOURCE_DATE_EPOCH inside the sbuild environment is automatically set
> according to the debian changelog. By that, we do not need to explicitly
> forward a possibly different, but ignored value into the sbuild
> environment.
> 
> This patch also fixes a warning about converting the SDE to a template.
> 

To be clear: That warning was only visible with a not-yet-published
patch of mine.

Jan

> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/classes/dpkg.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index 3fa9f604..0e25eb76 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -50,6 +50,7 @@ dpkg_runbuild() {
>          # Filter some standard variables
>          echo ${line} | grep -q "^HOME=" && continue
>          echo ${line} | grep -q "^PWD=" && continue
> +        echo ${line} | grep -q "^SOURCE_DATE_EPOCH=" && continue
>  
>          var=$(echo "${line}" | cut -d '=' -f1)
>          value=$(echo "${line}" | cut -d '=' -f2-)
Uladzimir Bely May 28, 2024, 5:39 a.m. UTC | #2
On Fri, 2024-05-17 at 17:05 +0200, 'Felix Moessbauer' via isar-users
wrote:
> The SOURCE_DATE_EPOCH inside the sbuild environment is automatically
> set
> according to the debian changelog. By that, we do not need to
> explicitly
> forward a possibly different, but ignored value into the sbuild
> environment.
> 
> This patch also fixes a warning about converting the SDE to a
> template.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/classes/dpkg.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index 3fa9f604..0e25eb76 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -50,6 +50,7 @@ dpkg_runbuild() {
>          # Filter some standard variables
>          echo ${line} | grep -q "^HOME=" && continue
>          echo ${line} | grep -q "^PWD=" && continue
> +        echo ${line} | grep -q "^SOURCE_DATE_EPOCH=" && continue
>  
>          var=$(echo "${line}" | cut -d '=' -f1)
>          value=$(echo "${line}" | cut -d '=' -f2-)
> -- 
> 2.39.2
> 

Applied to next, thanks.

Patch

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 3fa9f604..0e25eb76 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -50,6 +50,7 @@  dpkg_runbuild() {
         # Filter some standard variables
         echo ${line} | grep -q "^HOME=" && continue
         echo ${line} | grep -q "^PWD=" && continue
+        echo ${line} | grep -q "^SOURCE_DATE_EPOCH=" && continue
 
         var=$(echo "${line}" | cut -d '=' -f1)
         value=$(echo "${line}" | cut -d '=' -f2-)