[1/1] remove obsolete ISAR_APT_SNAPSHOT_MIRROR variable

Message ID 20240613131536.114357-1-felix.moessbauer@siemens.com
State Accepted, archived
Headers show
Series [1/1] remove obsolete ISAR_APT_SNAPSHOT_MIRROR variable | expand

Commit Message

MOESSBAUER, Felix June 13, 2024, 1:15 p.m. UTC
This variable was introduced while working on the generic snapshot
support, but then got refactored away while evolving the patch
series. Let's remove this leftover as well.

Reported-by: Anton Mikanovich <amikan@ilbers.de>
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 --
 1 file changed, 2 deletions(-)

Comments

Uladzimir Bely June 24, 2024, 6:35 a.m. UTC | #1
On Thu, 2024-06-13 at 15:15 +0200, 'Felix Moessbauer' via isar-users
wrote:
> This variable was introduced while working on the generic snapshot
> support, but then got refactored away while evolving the patch
> series. Let's remove this leftover as well.
> 
> Reported-by: Anton Mikanovich <amikan@ilbers.de>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> index faf22a50..4eec6361 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -34,8 +34,6 @@ DISTRO_VARS_PREFIX ?= "${@'HOST_' if
> bb.utils.to_boolean(d.getVar('BOOTSTRAP_FOR
>  BOOTSTRAP_DISTRO = "${@d.getVar('HOST_DISTRO' if
> bb.utils.to_boolean(d.getVar('BOOTSTRAP_FOR_HOST')) else 'DISTRO')}"
>  BOOTSTRAP_BASE_DISTRO = "${@d.getVar('HOST_BASE_DISTRO' if
> bb.utils.to_boolean(d.getVar('BOOTSTRAP_FOR_HOST')) else
> 'BASE_DISTRO')}"
>  FILESEXTRAPATHS:append = ":${BBPATH}"
> -# reproducible builds, only enabled if ISAR_USE_APT_SNAPSHOT
> -ISAR_APT_SNAPSHOT_MIRROR ??= ""
>  APT_SNAPSHOT_DATE = "${@ get_apt_snapshot_date(d)}"
>  
>  inherit deb-dl-dir
> -- 
> 2.39.2
> 

Applied to next, thanks.

Patch

diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index faf22a50..4eec6361 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -34,8 +34,6 @@  DISTRO_VARS_PREFIX ?= "${@'HOST_' if bb.utils.to_boolean(d.getVar('BOOTSTRAP_FOR
 BOOTSTRAP_DISTRO = "${@d.getVar('HOST_DISTRO' if bb.utils.to_boolean(d.getVar('BOOTSTRAP_FOR_HOST')) else 'DISTRO')}"
 BOOTSTRAP_BASE_DISTRO = "${@d.getVar('HOST_BASE_DISTRO' if bb.utils.to_boolean(d.getVar('BOOTSTRAP_FOR_HOST')) else 'BASE_DISTRO')}"
 FILESEXTRAPATHS:append = ":${BBPATH}"
-# reproducible builds, only enabled if ISAR_USE_APT_SNAPSHOT
-ISAR_APT_SNAPSHOT_MIRROR ??= ""
 APT_SNAPSHOT_DATE = "${@ get_apt_snapshot_date(d)}"
 
 inherit deb-dl-dir