debianize: set DEBIAN_RULES_REQUIRES_ROOT default to "no"

Message ID 20251025165759.32388-1-badrikesh.prusty@siemens.com
State Under Review
Headers show
Series debianize: set DEBIAN_RULES_REQUIRES_ROOT default to "no" | expand

Commit Message

Badrikesh Prusty Oct. 25, 2025, 4:57 p.m. UTC
From: badrikesh prusty <badrikesh.prusty@siemens.com>

With DEBIAN_RULES_REQUIRES_ROOT set to "no" by default, building Debian
packages no longer requires root privileges.

In dpkg version ≥ 1.22.13 (present in Debian Trixie), the default value
is "no". In earlier dpkg versions (used in Debian Bookworm and before)
the default value of Rules-Requires-Root was "binary-targets".

This ensures modern dpkg compatibility and safe, non-root builds for
older Debian versions, unless explicitly overridden.

Fixes: https://github.com/ilbers/isar/issues/113
Signed-off-by: badrikesh prusty <badrikesh.prusty@siemens.com>
---
 meta/classes/debianize.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka Oct. 27, 2025, 4:07 p.m. UTC | #1
On 25.10.25 18:57, 'Badrikesh Prusty' via isar-users wrote:
> From: badrikesh prusty <badrikesh.prusty@siemens.com>
> 
> With DEBIAN_RULES_REQUIRES_ROOT set to "no" by default, building Debian
> packages no longer requires root privileges.
> 
> In dpkg version ≥ 1.22.13 (present in Debian Trixie), the default value
> is "no". In earlier dpkg versions (used in Debian Bookworm and before)
> the default value of Rules-Requires-Root was "binary-targets".

...but your change now sets it to no by default for all Debian releases,
not just trixie.

Jan

> 
> This ensures modern dpkg compatibility and safe, non-root builds for
> older Debian versions, unless explicitly overridden.
> 
> Fixes: https://github.com/ilbers/isar/issues/113
> Signed-off-by: badrikesh prusty <badrikesh.prusty@siemens.com>
> ---
>  meta/classes/debianize.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
> index 1f54e8f9..ad9e1a0d 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -18,7 +18,7 @@ DEBIAN_BUILT_USING ??= ""
>  DEBIAN_MULTI_ARCH ??= "no"
>  DEBIAN_COMPAT ??= "10"
>  DEBIAN_CHANGELOG_TIMESTAMP ??= "3600"
> -DEBIAN_RULES_REQUIRES_ROOT ??= ""
> +DEBIAN_RULES_REQUIRES_ROOT ??= "no"
>  DESCRIPTION ??= "must not be empty"
>  MAINTAINER ??= "Unknown maintainer <unknown@example.com>"
>

Patch

diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
index 1f54e8f9..ad9e1a0d 100644
--- a/meta/classes/debianize.bbclass
+++ b/meta/classes/debianize.bbclass
@@ -18,7 +18,7 @@  DEBIAN_BUILT_USING ??= ""
 DEBIAN_MULTI_ARCH ??= "no"
 DEBIAN_COMPAT ??= "10"
 DEBIAN_CHANGELOG_TIMESTAMP ??= "3600"
-DEBIAN_RULES_REQUIRES_ROOT ??= ""
+DEBIAN_RULES_REQUIRES_ROOT ??= "no"
 DESCRIPTION ??= "must not be empty"
 MAINTAINER ??= "Unknown maintainer <unknown@example.com>"