diff mbox series

debian-common: Add fdisk package as a dependency in wic

Message ID 20210826051603.3649442-1-Srinuvasan_A@mentor.com
State Superseded, archived
Headers show
Series debian-common: Add fdisk package as a dependency in wic | expand

Commit Message

Srinuvasan Arjunan Aug. 25, 2021, 9:16 p.m. UTC 
From: Srinuvasan A <srinuvasan_a@mentor.com>

When we build the bullseye images for de0-nano-soc target it's getting
failed in wic image creation step due to sfdisk required to build the
wic images.

We added --syste-id to WKS file and triggered the builds for buster as
well as bullseye, buster image got passed, might be that indirectly pull
the fdisk package but bullseye builds got failed hence added this
package as a dependency in wic imager install.

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 meta/conf/distro/debian-common.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Henning Schild Aug. 26, 2021, 1:18 a.m. UTC | #1 
Am Thu, 26 Aug 2021 10:46:03 +0530
schrieb Srinuvasan A <Srinuvasan_A@mentor.com>:

> From: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> When we build the bullseye images for de0-nano-soc target it's getting
> failed in wic image creation step due to sfdisk required to build the
> wic images.
> 
> We added --syste-id to WKS file and triggered the builds for buster as

--system-id

> well as bullseye, buster image got passed, might be that indirectly
> pull the fdisk package but bullseye builds got failed hence added this
> package as a dependency in wic imager install.

It is not might be, it is for sure. See

https://github.com/ilbers/isar/blob/03124cca669f50b682336a0bdf4ede5a4238e144/scripts/lib/wic/plugins/imager/direct.py#L592

So maybe change the wording here accordingly.

You could add 
Fixes: c8eb30bfbff4 ("wic-img: import support for .wks.in files from oe-core")

So ack to the patch, but commit message should be improved.

Henning

> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>  meta/conf/distro/debian-common.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/distro/debian-common.conf
> b/meta/conf/distro/debian-common.conf index ba5262a..4c9b225 100644
> --- a/meta/conf/distro/debian-common.conf
> +++ b/meta/conf/distro/debian-common.conf
> @@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \
>                        e2fsprogs \
>                        python3 \
>                        bmap-tools \
> -                      tar"
> +                      tar \
> +                      fdisk"
>  
>  GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
>  GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"
diff mbox series

Patch

diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
index ba5262a..4c9b225 100644
--- a/meta/conf/distro/debian-common.conf
+++ b/meta/conf/distro/debian-common.conf
@@ -16,7 +16,8 @@  WIC_IMAGER_INSTALL = "parted \
                       e2fsprogs \
                       python3 \
                       bmap-tools \
-                      tar"
+                      tar \
+                      fdisk"
 
 GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
 GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"