diff mbox series

debian-common: Add fdisk package as a dependency in wic

Message ID 20210826121640.3650789-1-Srinuvasan_A@mentor.com
State Superseded, archived
Headers show
Series debian-common: Add fdisk package as a dependency in wic | expand

Commit Message

Srinuvasan Arjunan Aug. 26, 2021, 4:16 a.m. UTC 
From: Srinuvasan A <srinuvasan_a@mentor.com>

In downstream when we build the bullseye images for de0-nano-soc target it's getting
failed in wic image creation step due to sfdisk required to build the
wic images.

To reproduce this issue in upstream we triggered the de0-nano-soc build
with --system-id option enabled in wks.in file, this issue present in
upstream build hence added the dependency package fdisk to the wic
imager install.

Ref for de0-nano-soc.wks.in: https://github.com/ilbers/isar/commit/c8eb30bfbff4dc22c6d9633f33646e99590853d9

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 meta/conf/distro/debian-common.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Henning Schild Aug. 26, 2021, 11:26 a.m. UTC | #1 
Should be "v2" see "--subject-prefix" in "git send-email"

Am Thu, 26 Aug 2021 17:46:40 +0530
schrieb Srinuvasan A <Srinuvasan_A@mentor.com>:

> From: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> In downstream when we build the bullseye images for de0-nano-soc
> target it's getting failed in wic image creation step due to sfdisk
> required to build the wic images.
> 
> To reproduce this issue in upstream we triggered the de0-nano-soc
> build with --system-id option enabled in wks.in file, this issue
> present in upstream build hence added the dependency package fdisk to
> the wic imager install.
> 
> Ref for de0-nano-soc.wks.in:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Filbers%2Fisar%2Fcommit%2Fc8eb30bfbff4dc22c6d9633f33646e99590853d9&amp;data=04%7C01%7Cde173c00-e982-4fda-8644-47edf4671d63%40ad011.siemens.com%7C8d5cac41bb6b45120ee308d9688b6d6b%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637655770766182740%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=2QWon3o9OYfdb%2BpQjlokZL8mkbbV4K8gT8MkuRa395c%3D&amp;reserved=0

Forgive the f..ed up link. But naming a ref in the same repo is best
just done with that ref. So please just the sha maybe shortened to 8 or
12 leading chars.

gitk and other repo browsers will allow navigation when just using
the sha ... think of it as a much better relative link as opposed to
the absolute one you suggest here.

Henning

> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>  meta/conf/distro/debian-common.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/distro/debian-common.conf
> b/meta/conf/distro/debian-common.conf index ba5262a..4c9b225 100644
> --- a/meta/conf/distro/debian-common.conf
> +++ b/meta/conf/distro/debian-common.conf
> @@ -16,7 +16,8 @@ WIC_IMAGER_INSTALL = "parted \
>                        e2fsprogs \
>                        python3 \
>                        bmap-tools \
> -                      tar"
> +                      tar \
> +                      fdisk"
>  
>  GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
>  GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"
diff mbox series

Patch

diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
index ba5262a..4c9b225 100644
--- a/meta/conf/distro/debian-common.conf
+++ b/meta/conf/distro/debian-common.conf
@@ -16,7 +16,8 @@  WIC_IMAGER_INSTALL = "parted \
                       e2fsprogs \
                       python3 \
                       bmap-tools \
-                      tar"
+                      tar \
+                      fdisk"
 
 GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
 GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"