[v3] debian-common: Add fdisk package as a dependency in wic

Message ID 20210827131700.3655256-1-Srinuvasan_A@mentor.com
State Superseded, archived
Headers show
Series [v3] debian-common: Add fdisk package as a dependency in wic | expand

Commit Message

Srinuvasan Arjunan Aug. 27, 2021, 5:17 a.m. UTC
From: Srinuvasan A <srinuvasan_a@mentor.com>

In downstream when we build the bullseye images for de0-nano-soc target it's getting
failed in wic image creation step due to sfdisk required to build the
wic images.

To reproduce this issue in upstream we triggered the de0-nano-soc build
with --system-id option enabled in wks.in file, this issue present in
upstream build hence added the dependency package fdisk to the wic
imager install.

Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 meta/conf/distro/debian-common.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Anton Mikanovich Sept. 6, 2021, 5:48 a.m. UTC | #1
27.08.2021 16:17, Srinuvasan A wrote:
> From: Srinuvasan A <srinuvasan_a@mentor.com>
>
> In downstream when we build the bullseye images for de0-nano-soc target it's getting
> failed in wic image creation step due to sfdisk required to build the
> wic images.
>
> To reproduce this issue in upstream we triggered the de0-nano-soc build
> with --system-id option enabled in wks.in file, this issue present in
> upstream build hence added the dependency package fdisk to the wic
> imager install.
>
> Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4
>
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>

This will fail in stretch, because there is no such a package in it.
sfdisk was already included in util-linux, but moved to separate fdisk 
package started from buster.
Jan Kiszka Sept. 6, 2021, 10:41 a.m. UTC | #2
On 06.09.21 15:48, Anton Mikanovich wrote:
> 27.08.2021 16:17, Srinuvasan A wrote:
>> From: Srinuvasan A <srinuvasan_a@mentor.com>
>>
>> In downstream when we build the bullseye images for de0-nano-soc
>> target it's getting
>> failed in wic image creation step due to sfdisk required to build the
>> wic images.
>>
>> To reproduce this issue in upstream we triggered the de0-nano-soc build
>> with --system-id option enabled in wks.in file, this issue present in
>> upstream build hence added the dependency package fdisk to the wic
>> imager install.
>>
>> Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4
>>
>> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> This will fail in stretch, because there is no such a package in it.
> sfdisk was already included in util-linux, but moved to separate fdisk
> package started from buster.
> 

WIC_IMAGER_INSTALL_remove_stretch = "fdisk"

should fix that and can easily be dropped when we retire stretch.

Jan
Srinuvasan Arjunan Sept. 6, 2021, 4:18 p.m. UTC | #3
Sure jan, will send next version of patch soon.

Many thanks,
Srinuvasan.A

On Tue, 7 Sep, 2021, 12:11 am Jan Kiszka, <jan.kiszka@siemens.com> wrote:

> On 06.09.21 15:48, Anton Mikanovich wrote:
> > 27.08.2021 16:17, Srinuvasan A wrote:
> >> From: Srinuvasan A <srinuvasan_a@mentor.com>
> >>
> >> In downstream when we build the bullseye images for de0-nano-soc
> >> target it's getting
> >> failed in wic image creation step due to sfdisk required to build the
> >> wic images.
> >>
> >> To reproduce this issue in upstream we triggered the de0-nano-soc build
> >> with --system-id option enabled in wks.in file, this issue present in
> >> upstream build hence added the dependency package fdisk to the wic
> >> imager install.
> >>
> >> Ref commit for de0-nano-soc.wks.in: c8eb30bfbff4
> >>
> >> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> >
> > This will fail in stretch, because there is no such a package in it.
> > sfdisk was already included in util-linux, but moved to separate fdisk
> > package started from buster.
> >
>
> WIC_IMAGER_INSTALL_remove_stretch = "fdisk"
>
> should fix that and can easily be dropped when we retire stretch.
>
> Jan
>
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux
>
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/f5dc1714-0eee-77e5-be30-035d82e0c2ed%40siemens.com
> .
>

Patch

diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
index ba5262a..4c9b225 100644
--- a/meta/conf/distro/debian-common.conf
+++ b/meta/conf/distro/debian-common.conf
@@ -16,7 +16,8 @@  WIC_IMAGER_INSTALL = "parted \
                       e2fsprogs \
                       python3 \
                       bmap-tools \
-                      tar"
+                      tar \
+                      fdisk"
 
 GRUB_BOOTLOADER_INSTALL_amd64 = "grub-efi-amd64-bin"
 GRUB_BOOTLOADER_INSTALL_i386 = "grub-efi-ia32-bin"