mbox series

[v12,0/2] CPIO & OVA Images

Message ID 20210618133955.22505-1-Quirin.Gylstorff@siemens.com
Headers show
Series CPIO & OVA Images | expand

Message

Quirin Gylstorff June 18, 2021, 5:39 a.m. UTC 
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>

- Generate cpio images for rescue images
- generate ova images for VMWare & Virtualbox

Changes V2:
- initramfs modification is now a package
- ova-wic-img was renamed to virtual-machine-image
- virtual-machine-image do_convert_wic supports now other image
formats
- Add tests
- cpiogz now use chown instead of userspec

Changes V3:
- Add tests to build-ci
- add postrm to initramfs-config
- use sdimage-efi for virtualbox images
- changed maintainer

Changes V4:
- use templates from debhelper for postinst and postrm scripts

Changes V5:
- add virtual-machine-template package to add the template as extra file to the build

Changes V6:
- whitespace fix
- initramfs-config is now a inc file instead of a recipe
- meta isar contains a default implementation of intramfs-config

Changes V7:
- drop initramfs-config in favour of https://groups.google.com/g/isar-users/c/47EZAUTclZs/m/npCfE6zqCwAJ
- clarify OVA commit message
- rebase on  origin/next f5a6fdfd9aad49202093aab2158f625429eaf7c5

Changes V8:
- formatting
- correct cpio commit message

Changes in v9 by Jan Kiszka:
 - renaming "virtual-machine" -> "vm"

Changes in v10 by Jan Kiszka:
 - fix incomplete renaming "virtual-machine" -> "vm"
   (the classic "posting before testing"...)

Changes in v11:
 - fix full ci build by Jan Kiszka
 - fix missing in ovf file after envsubst

Changes in v12:
 - remove var BOOTLOADER

Quirin Gylstorff (2):
  meta/classes: Generate ova image for VMWare or Virtualbox
  meta/classes: add cpiogz-img

 doc/user_manual.md                            |   1 +
 meta-isar/conf/local.conf.sample              |   2 +
 meta-isar/conf/machine/virtualbox.conf        |  15 ++
 meta-isar/conf/machine/vmware.conf            |  15 ++
 .../multiconfig/qemuamd64-buster-cpiogz.conf  |   9 +
 .../multiconfig/virtualbox-ova-buster.conf    |   8 +
 meta/classes/cpiogz-img.bbclass               |  21 +++
 meta/classes/vm-img.bbclass                   | 122 ++++++++++++++
 .../vm-template/files/vm-template.ovf.tmpl    | 155 ++++++++++++++++++
 .../vm-template/vm-template_0.1.bb            |  16 ++
 scripts/ci_build.sh                           |   2 +
 11 files changed, 366 insertions(+)
 create mode 100644 meta-isar/conf/machine/virtualbox.conf
 create mode 100644 meta-isar/conf/machine/vmware.conf
 create mode 100644 meta-isar/conf/multiconfig/qemuamd64-buster-cpiogz.conf
 create mode 100644 meta-isar/conf/multiconfig/virtualbox-ova-buster.conf
 create mode 100644 meta/classes/cpiogz-img.bbclass
 create mode 100644 meta/classes/vm-img.bbclass
 create mode 100644 meta/recipes-devtools/vm-template/files/vm-template.ovf.tmpl
 create mode 100644 meta/recipes-devtools/vm-template/vm-template_0.1.bb

Comments

Anton Mikanovich June 25, 2021, 3:30 a.m. UTC | #1 
18.06.2021 16:39, Q. Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>
> - Generate cpio images for rescue images
> - generate ova images for VMWare & Virtualbox

Can you please add image_undo_mounts calls in all the functions using 
image_do_mounts?
This requirement is not jet mentioned in documentation, but it is 
mandatory after the latest mount rebuild.
Florian Bezdeka June 25, 2021, 7:06 a.m. UTC | #2 
Hi all,

On 25.06.21 13:30, Anton Mikanovich wrote:
> 18.06.2021 16:39, Q. Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> - Generate cpio images for rescue images
>> - generate ova images for VMWare & Virtualbox
> 
> Can you please add image_undo_mounts calls in all the functions using
> image_do_mounts?
> This requirement is not jet mentioned in documentation, but it is
> mandatory after the latest mount rebuild.
> 

Isn't that a performance killer doing mount/umount all the time?

I would expect a lot of recipes to break if we have to follow a new
pattern now. Can't that be done in a backward compatible manner like
locating the mount/umount inside "pre" and "post" tasks, so that recipes
can stay as they are?

If there is no way to do that in a backward compatible manner I would
vote for postponing the mount/umount refactoring to the next major release.

Best regards,
Florian