| Message ID | 20221119182031.2005807-1-tobias.schaffner@siemens.com |
|---|---|
| Headers | show |
| Series | Mask systemd-firstboot | expand |
In mail from Saturday, 19 November 2022 21:20:29 +03 user T. Schaffner wrote: > From: Tobias Schaffner <tobias.schaffner@siemens.com> > > systemd-firstboot asks the user interactively for missing system > configurations like locale or hostname if not configured. > > Mask this service as we do not want to depend on user interaction to allow > an image to boot. > > As other packages might depend on the configurations enforced by > systemd-firstboot run it in a postproc step and warn if it misses something. > > Tobias Schaffner (2): > Mask systemd-firstboot > Warn if systemd-firstboot misses configurations > > meta/classes/image-postproc-extension.bbclass | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Merged to next, thanks
On 27.02.23 13:23, Cedric Hombourger wrote: > > > On Monday, February 27, 2023 at 5:39:30 AM UTC+1 Uladzimir Bely wrote: > > In mail from Saturday, 19 November 2022 21:20:29 +03 user T. > Schaffner wrote: > > From: Tobias Schaffner <tobias.s...@siemens.com> > > > > systemd-firstboot asks the user interactively for missing system > > configurations like locale or hostname if not configured. > > > > Mask this service as we do not want to depend on user interaction > to allow > > an image to boot. > > This is IMO a distro/product level decision and I am not sure if Isar, > as a build-system, should make such decisions > Does the current approach now prevent to re-enable it at that level - obviously only after fixing all the issues that motivated the disabling? Then we need to be aware of the use case, and things should be made configurable. Jan
In mail from Monday, 27 February 2023 15:37:16 +03 user Jan Kiszka wrote: > On 27.02.23 13:23, Cedric Hombourger wrote: > > On Monday, February 27, 2023 at 5:39:30 AM UTC+1 Uladzimir Bely wrote: > > In mail from Saturday, 19 November 2022 21:20:29 +03 user T. > > > > Schaffner wrote: > > > From: Tobias Schaffner <tobias.s...@siemens.com> > > > > > > systemd-firstboot asks the user interactively for missing system > > > configurations like locale or hostname if not configured. > > > > > > Mask this service as we do not want to depend on user interaction > > > > to allow > > > > > an image to boot. > > > > This is IMO a distro/product level decision and I am not sure if Isar, > > as a build-system, should make such decisions > > > > Does the current approach now prevent to re-enable it at that level - > obviously only after fixing all the issues that motivated the disabling? > Then we need to be aware of the use case, and things should be made > configurable. > > Jan It's possible to reenable it by local.conf: ``` ROOTFS_POSTPROCESS_COMMAND:remove = "image_posprocess_disable_systemd_firstboot" ``` Of course, we could not to add this to ROOTFS_POSTPROCESS_COMMAND in image- postproc-extension.bbclass by default, but leave an opportunity for downstreams to make this :append. But it would be a kind of dead code in Isar in this case.
On 27.02.23 13:53, Uladzimir Bely wrote: > In mail from Monday, 27 February 2023 15:37:16 +03 user Jan Kiszka wrote: >> On 27.02.23 13:23, Cedric Hombourger wrote: >>> On Monday, February 27, 2023 at 5:39:30 AM UTC+1 Uladzimir Bely wrote: >>> In mail from Saturday, 19 November 2022 21:20:29 +03 user T. >>> >>> Schaffner wrote: >>> > From: Tobias Schaffner <tobias.s...@siemens.com> >>> > >>> > systemd-firstboot asks the user interactively for missing system >>> > configurations like locale or hostname if not configured. >>> > >>> > Mask this service as we do not want to depend on user interaction >>> >>> to allow >>> >>> > an image to boot. >>> >>> This is IMO a distro/product level decision and I am not sure if Isar, >>> as a build-system, should make such decisions >>> >> >> Does the current approach now prevent to re-enable it at that level - >> obviously only after fixing all the issues that motivated the disabling? >> Then we need to be aware of the use case, and things should be made >> configurable. >> >> Jan > > It's possible to reenable it by local.conf: > ``` > ROOTFS_POSTPROCESS_COMMAND:remove = > "image_posprocess_disable_systemd_firstboot" > ``` > > Of course, we could not to add this to ROOTFS_POSTPROCESS_COMMAND in image- > postproc-extension.bbclass by default, but leave an opportunity for > downstreams to make this :append. But it would be a kind of dead code in Isar > in this case. > I agree that this switch can be a distro/project topic, but if that switch makes sense for 99% of the cases (and it feels to me like this ATM), then having it default-on reduces the efforts downstream. Jan
From: Tobias Schaffner <tobias.schaffner@siemens.com> systemd-firstboot asks the user interactively for missing system configurations like locale or hostname if not configured. Mask this service as we do not want to depend on user interaction to allow an image to boot. As other packages might depend on the configurations enforced by systemd-firstboot run it in a postproc step and warn if it misses something. Tobias Schaffner (2): Mask systemd-firstboot Warn if systemd-firstboot misses configurations meta/classes/image-postproc-extension.bbclass | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)