mbox series

[v3,0/5] Remove code duplications for start_vm

Message ID 20240621150814.189288-1-amikan@ilbers.de
Headers show
Series Remove code duplications for start_vm | expand

Message

Anton Mikanovich June 21, 2024, 3:08 p.m. UTC
We had both shell and python APIs for running QEMU images, there is
also start_vm related functionality in testsuite itself. All this parts
duplicate each other and should be cleanup.

Changes since v2:
- Fix getVars usage in repro-build-test.
- Fix coding style.

Changes since v1:
- Fix multiple image type targets.

Anton Mikanovich (3):
  start_vm: Add secureboot support
  CI: Allow external usage for some APIs
  start_vm: Reuse getVars API

Ilia Skochilov (2):
  start_vm: Switch to python version
  scripts: Remove vm_smoke_test

 CONTRIBUTING.md                          |  50 +++----
 meta-isar/conf/machine/qemuamd64-sb.conf |   2 +-
 scripts/start_vm                         | 161 ++---------------------
 scripts/vm_smoke_test                    | 106 ---------------
 testsuite/README.md                      |   4 +-
 testsuite/cibase.py                      |   8 +-
 testsuite/cibuilder.py                   |  69 +++-------
 testsuite/citest.py                      |   4 +-
 testsuite/repro-build-test.py            |   4 +-
 testsuite/start_vm.py                    |  94 +++++++++----
 testsuite/utils.py                       |  55 ++++++++
 11 files changed, 193 insertions(+), 364 deletions(-)
 delete mode 100755 scripts/vm_smoke_test
 create mode 100755 testsuite/utils.py

Comments

Uladzimir Bely June 26, 2024, 6:32 a.m. UTC | #1
On Fri, 2024-06-21 at 18:08 +0300, Anton Mikanovich wrote:
> We had both shell and python APIs for running QEMU images, there is
> also start_vm related functionality in testsuite itself. All this
> parts
> duplicate each other and should be cleanup.
> 
> Changes since v2:
> - Fix getVars usage in repro-build-test.
> - Fix coding style.
> 
> Changes since v1:
> - Fix multiple image type targets.
> 
> Anton Mikanovich (3):
>   start_vm: Add secureboot support
>   CI: Allow external usage for some APIs
>   start_vm: Reuse getVars API
> 
> Ilia Skochilov (2):
>   start_vm: Switch to python version
>   scripts: Remove vm_smoke_test
> 
>  CONTRIBUTING.md                          |  50 +++----
>  meta-isar/conf/machine/qemuamd64-sb.conf |   2 +-
>  scripts/start_vm                         | 161 ++-------------------
> --
>  scripts/vm_smoke_test                    | 106 ---------------
>  testsuite/README.md                      |   4 +-
>  testsuite/cibase.py                      |   8 +-
>  testsuite/cibuilder.py                   |  69 +++-------
>  testsuite/citest.py                      |   4 +-
>  testsuite/repro-build-test.py            |   4 +-
>  testsuite/start_vm.py                    |  94 +++++++++----
>  testsuite/utils.py                       |  55 ++++++++
>  11 files changed, 193 insertions(+), 364 deletions(-)
>  delete mode 100755 scripts/vm_smoke_test
>  create mode 100755 testsuite/utils.py
> 
> -- 
> 2.34.1
> 

Applied to next.