mbox series

[v1,0/1] Set hash-seed for empty ext partition

Message ID 20240625065032.595783-1-Adithya.Balakumar@toshiba-tsip.com
Headers show
Series Set hash-seed for empty ext partition | expand

Message

Adithya Balakumar June 25, 2024, 6:50 a.m. UTC 
ext filesystems require a hash_seed to generate deterministic directory 
indexes for reproducible builds. This is handled by wic in the case where 
the rootfs plugin is used but this not handled in the case when an empty 
ext4 partition is deployed.

This patch is also shared with openembedded-core and also accepted. 
Upstream commit: 0202fb594fb05098cb8d8b6088e63beb40b5906e

Adithya Balakumar (1):
  wic/partition.py: Set hash_seed for empty ext partition

 scripts/lib/wic/partition.py | 37 ++++++++++++++++++++++--------------
 1 file changed, 23 insertions(+), 14 deletions(-)

Comments

Anton Mikanovich June 25, 2024, 1:09 p.m. UTC | #1 
25/06/2024 10:37, Jan Kiszka wrote:
> Shouldn't we sync to a wic revision >= the one containing this?
>
> Jan
>
Hello Jan,

This is our preferred process by default, but this commit is in oe-core 
master
branch only for now. We should probably wait for release or backporting.

We are currently using the latest Scarthgap LTS version 5.0 branch.
Jan Kiszka June 25, 2024, 2:30 p.m. UTC | #2 
On 25.06.24 15:09, Anton Mikanovich wrote:
> 25/06/2024 10:37, Jan Kiszka wrote:
>> Shouldn't we sync to a wic revision >= the one containing this?
>>
>> Jan
>>
> Hello Jan,
> 
> This is our preferred process by default, but this commit is in oe-core
> master
> branch only for now. We should probably wait for release or backporting.
> 
> We are currently using the latest Scarthgap LTS version 5.0 branch.
> 

Maybe propose the commit for 5.0-LTS branch and then sync that in? But
if you are fine with taking this backport, I will not hold you back. It
will be valuable for us, that is for sure.

Jan
Adithya Balakumar June 26, 2024, 4:35 a.m. UTC | #3 
Hi Anton and Jan,

Thanks for the feedback. Let me propose this patch to Scarthgap also. And once accepted in Scarthgap, I will share the patch with isar again.

Thanks,
Adithya 

-----Original Message-----
From: Jan Kiszka <jan.kiszka@siemens.com> 
Sent: Tuesday, June 25, 2024 8:00 PM
To: Anton Mikanovich <amikan@ilbers.de>; balakumar adithya(ＴＳＩＰ TEUR) <Adithya.Balakumar@toshiba-tsip.com>; isar-users@googlegroups.com
Cc: hayashi kazuhiro(林 和宏 ＤＭＥ ○ＤＩＧ□ＭＰＳ○ＭＰ４) <kazuhiro3.hayashi@toshiba.co.jp>; dinesh kumar(ＴＳＩＰ TMIEC ODG Porting) <dinesh.kumar@toshiba-tsip.com>; kunijadar shivanand(ＴＳＩＰ TMIEC ODG Porting) <Shivanand.Kunijadar@toshiba-tsip.com>; ashrith sai(ＴＳＩＰ) <Sai.Sathujoda@toshiba-tsip.com>
Subject: Re: [PATCH v1 0/1] Set hash-seed for empty ext partition

On 25.06.24 15:09, Anton Mikanovich wrote:
> 25/06/2024 10:37, Jan Kiszka wrote:
>> Shouldn't we sync to a wic revision >= the one containing this?
>>
>> Jan
>>
> Hello Jan,
> 
> This is our preferred process by default, but this commit is in 
> oe-core master branch only for now. We should probably wait for 
> release or backporting.
> 
> We are currently using the latest Scarthgap LTS version 5.0 branch.
> 

Maybe propose the commit for 5.0-LTS branch and then sync that in? But if you are fine with taking this backport, I will not hold you back. It will be valuable for us, that is for sure.

Jan

--
Siemens AG, Technology
Linux Expert Center