| Message ID | 20240704111053.1647620-1-Adithya.Balakumar@toshiba-tsip.com |
|---|---|
| Headers | show |
| Series | Set hash-seed for empty ext partition | expand |
On Thu, 2024-07-04 at 16:40 +0530, Adithya Balakumar wrote: > ext filesystems require a hash_seed to generate deterministic directory indexes > for reproducible builds. This is handled by wic in the case where the rootfs > plugin is used but this not handled in the case when an empty ext4 partition > is deployed. > > This patch is also shared with openembedded-core and also accepted. > master branch commit: 0202fb594fb05098cb8d8b6088e63beb40b5906e > scarthgap branch commit: a4e7334a4b87f1bb1947f6b10f71ddb445c91d0c Thanks for upstreaming! Instead of applying a single patch I would vote for triggering a complete wic update. > > Changes since v1: > There is no change in the patch from v1. Just that this patch is also applied > to the scarthgap branch in OE-core. > > Adithya Balakumar (1): > wic/partition.py: Set hash_seed for empty ext partition > > scripts/lib/wic/partition.py | 37 ++++++++++++++++++++++-------------- > 1 file changed, 23 insertions(+), 14 deletions(-) > > -- > 2.39.2
Hi Florian, As I remember, ISAR just updated wic for the latest LTS release of OE (scarthgap) back in May, and this is the only patch to the scarthgap branch that is wic related since then. If I understand correctly, ISAR updates OE related libraries / dependencies for every LTS release in OE. Please correct me if I am mistaken. Thanks and Regards, Adithya Balakumar -----Original Message----- From: Florian Bezdeka <florian.bezdeka@siemens.com> Sent: Thursday, July 4, 2024 9:14 PM To: balakumar adithya(ＴＳＩＰ TEUR) <Adithya.Balakumar@toshiba-tsip.com>; isar-users@googlegroups.com; amikan@ilbers.de Cc: jan.kiszka@siemens.com; hayashi kazuhiro(林 和宏 ＤＭＥ ○ＤＩＧ□ＭＰＳ○ＭＰ４) <kazuhiro3.hayashi@toshiba.co.jp>; dinesh kumar(ＴＳＩＰ TMIEC ODG Porting) <dinesh.kumar@toshiba-tsip.com>; kunijadar shivanand(ＴＳＩＰ TMIEC ODG Porting) <Shivanand.Kunijadar@toshiba-tsip.com>; ashrith sai(ＴＳＩＰ) <Sai.Sathujoda@toshiba-tsip.com> Subject: Re: [PATCH v2 0/1] Set hash-seed for empty ext partition On Thu, 2024-07-04 at 16:40 +0530, Adithya Balakumar wrote: > ext filesystems require a hash_seed to generate deterministic > directory indexes for reproducible builds. This is handled by wic in > the case where the rootfs plugin is used but this not handled in the > case when an empty ext4 partition is deployed. > > This patch is also shared with openembedded-core and also accepted. > master branch commit: 0202fb594fb05098cb8d8b6088e63beb40b5906e > scarthgap branch commit: a4e7334a4b87f1bb1947f6b10f71ddb445c91d0c Thanks for upstreaming! Instead of applying a single patch I would vote for triggering a complete wic update. > > Changes since v1: > There is no change in the patch from v1. Just that this patch is also > applied to the scarthgap branch in OE-core. > > Adithya Balakumar (1): > wic/partition.py: Set hash_seed for empty ext partition > > scripts/lib/wic/partition.py | 37 > ++++++++++++++++++++++-------------- > 1 file changed, 23 insertions(+), 14 deletions(-) > > -- > 2.39.2
On 04.07.24 13:10, Adithya Balakumar wrote: > ext filesystems require a hash_seed to generate deterministic directory indexes > for reproducible builds. This is handled by wic in the case where the rootfs > plugin is used but this not handled in the case when an empty ext4 partition > is deployed. > > This patch is also shared with openembedded-core and also accepted. > master branch commit: 0202fb594fb05098cb8d8b6088e63beb40b5906e > scarthgap branch commit: a4e7334a4b87f1bb1947f6b10f71ddb445c91d0c > So, your change lifts wic to commit a4e7334a4b? This remains unclear from your patch but, given that your patch is accepted to stable now, it is the way to go for isar now. Jan > Changes since v1: > There is no change in the patch from v1. Just that this patch is also applied > to the scarthgap branch in OE-core. > > Adithya Balakumar (1): > wic/partition.py: Set hash_seed for empty ext partition > > scripts/lib/wic/partition.py | 37 ++++++++++++++++++++++-------------- > 1 file changed, 23 insertions(+), 14 deletions(-) >
-----Original Message----- From: Jan Kiszka <jan.kiszka@siemens.com> Sent: Tuesday, July 16, 2024 2:30 PM To: balakumar adithya(ＴＳＩＰ TEUR) <Adithya.Balakumar@toshiba-tsip.com>; isar-users@googlegroups.com; amikan@ilbers.de Cc: hayashi kazuhiro(林 和宏 ＤＭＥ ○ＤＩＧ□ＭＰＳ○ＭＰ４) <kazuhiro3.hayashi@toshiba.co.jp>; dinesh kumar(ＴＳＩＰ TMIEC ODG Porting) <dinesh.kumar@toshiba-tsip.com>; kunijadar shivanand(ＴＳＩＰ TMIEC ODG Porting) <Shivanand.Kunijadar@toshiba-tsip.com>; ashrith sai(ＴＳＩＰ) <Sai.Sathujoda@toshiba-tsip.com> Subject: Re: [PATCH v2 0/1] Set hash-seed for empty ext partition On 04.07.24 13:10, Adithya Balakumar wrote: > ext filesystems require a hash_seed to generate deterministic > directory indexes for reproducible builds. This is handled by wic in > the case where the rootfs plugin is used but this not handled in the > case when an empty ext4 partition is deployed. > > This patch is also shared with openembedded-core and also accepted. > master branch commit: 0202fb594fb05098cb8d8b6088e63beb40b5906e > scarthgap branch commit: a4e7334a4b87f1bb1947f6b10f71ddb445c91d0c > So, your change lifts wic to commit a4e7334a4b? This remains unclear from your patch but, given that your patch is accepted to stable now, it is the way to go for isar now. Jan [Adithya Balakumar
Yes Jan, My patch lifts wic to commit a4e7334a4b87f1bb1947f6b10f71ddb445c91d0c in the stable branch (scarthgap) of oe-core. Apologies for not making that clear in my patch. Regards, Adithya -----Original Message----- From: Jan Kiszka <jan.kiszka@siemens.com> Sent: Tuesday, July 16, 2024 2:30 PM To: balakumar adithya(ＴＳＩＰ TEUR) <Adithya.Balakumar@toshiba-tsip.com>; isar-users@googlegroups.com; amikan@ilbers.de Cc: hayashi kazuhiro(林 和宏 ＤＭＥ ○ＤＩＧ□ＭＰＳ○ＭＰ４) <kazuhiro3.hayashi@toshiba.co.jp>; dinesh kumar(ＴＳＩＰ TMIEC ODG Porting) <dinesh.kumar@toshiba-tsip.com>; kunijadar shivanand(ＴＳＩＰ TMIEC ODG Porting) <Shivanand.Kunijadar@toshiba-tsip.com>; ashrith sai(ＴＳＩＰ) <Sai.Sathujoda@toshiba-tsip.com> Subject: Re: [PATCH v2 0/1] Set hash-seed for empty ext partition On 04.07.24 13:10, Adithya Balakumar wrote: > ext filesystems require a hash_seed to generate deterministic > directory indexes for reproducible builds. This is handled by wic in > the case where the rootfs plugin is used but this not handled in the > case when an empty ext4 partition is deployed. > > This patch is also shared with openembedded-core and also accepted. > master branch commit: 0202fb594fb05098cb8d8b6088e63beb40b5906e > scarthgap branch commit: a4e7334a4b87f1bb1947f6b10f71ddb445c91d0c > So, your change lifts wic to commit a4e7334a4b? This remains unclear from your patch but, given that your patch is accepted to stable now, it is the way to go for isar now. Jan > Changes since v1: > There is no change in the patch from v1. Just that this patch is also > applied to the scarthgap branch in OE-core. > > Adithya Balakumar (1): > wic/partition.py: Set hash_seed for empty ext partition > > scripts/lib/wic/partition.py | 37 > ++++++++++++++++++++++-------------- > 1 file changed, 23 insertions(+), 14 deletions(-) > -- Siemens AG, Technology Linux Expert Center
On 16.07.24 11:49, Adithya.Balakumar@toshiba-tsip.com wrote: > Yes Jan, My patch lifts wic to commit a4e7334a4b87f1bb1947f6b10f71ddb445c91d0c in the stable branch (scarthgap) of oe-core. Apologies for not making that clear in my patch. > Then please update the commit message accordingly, see e.g. 07fb09747f60a99ffece335404f5096977af4f4e. The commit message can additionally refer to the only change this brings, but most important is recording the wic sha in isar's git. Thanks, Jan