mbox series

[0/2] use BPN instead of PN for PP

Message ID 20240912082741.354985-1-cedric.hombourger@siemens.com
Headers show
Series use BPN instead of PN for PP | expand

Message

Cedric Hombourger Sept. 12, 2024, 8:27 a.m. UTC 
With 2ca3a7e5, sources are built only once and re-used when building
-native and -compat binary packages. The dpkg-raw class generates
a debian/rules file with ${PP}/image expanded: this causes build
of the -compat or -native variants to fail since /home/builder/${PN}
does not exist in the sbuild environment of -compat/-native.

Change the definition of PP to be /home/builder/${BPN} so that the
expanded value remains the same for all variants.

Having absolute paths in generated debian/rules files is obviously
questionable.


Cedric Hombourger (2):
  refactor: remove duplicate definition of BPN
  dpkg: use BPN instead of PN when defining PP

 meta/classes/dpkg-base.bbclass | 2 +-
 meta/classes/multiarch.bbclass | 2 --
 meta/classes/sbuild.bbclass    | 2 +-
 meta/classes/sdk.bbclass       | 1 -
 meta/conf/bitbake.conf         | 1 +
 5 files changed, 3 insertions(+), 5 deletions(-)

Comments

Uladzimir Bely Sept. 19, 2024, 1:17 p.m. UTC | #1 
On Thu, 2024-09-12 at 10:27 +0200, 'Cedric Hombourger' via isar-users
wrote:
> With 2ca3a7e5, sources are built only once and re-used when building
> -native and -compat binary packages. The dpkg-raw class generates
> a debian/rules file with ${PP}/image expanded: this causes build
> of the -compat or -native variants to fail since /home/builder/${PN}
> does not exist in the sbuild environment of -compat/-native.
> 
> Change the definition of PP to be /home/builder/${BPN} so that the
> expanded value remains the same for all variants.
> 
> Having absolute paths in generated debian/rules files is obviously
> questionable.
> 
> 
> Cedric Hombourger (2):
>   refactor: remove duplicate definition of BPN
>   dpkg: use BPN instead of PN when defining PP
> 
>  meta/classes/dpkg-base.bbclass | 2 +-
>  meta/classes/multiarch.bbclass | 2 --
>  meta/classes/sbuild.bbclass    | 2 +-
>  meta/classes/sdk.bbclass       | 1 -
>  meta/conf/bitbake.conf         | 1 +
>  5 files changed, 3 insertions(+), 5 deletions(-)
> 
> -- 
> 2.39.2
> 

Applied to next, thanks.