From patchwork Fri Oct 11 10:00:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Mikanovich X-Patchwork-Id: 220 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 11 Oct 2024 12:01:08 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-il1-f186.google.com (mail-il1-f186.google.com [209.85.166.186]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 49BA17a5008661 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 11 Oct 2024 12:01:08 +0200 Received: by mail-il1-f186.google.com with SMTP id e9e14a558f8ab-3a1a8b992d3sf20988775ab.0 for ; Fri, 11 Oct 2024 03:01:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1728640861; cv=pass; d=google.com; s=arc-20240605; b=K7+B4+4rQJ4SI1O+mi/kRPh72L+fAQ2QkuNMhTUdrRoDlVhA3LZz3HEAje7PxyZjG9 GGM7AAMoTdq480z1aekKWciMevSP2N9PjqJNIs+gBLUOxlTKlvJIAk8sybopjsHRtIMm 7i4Lw9f16d5pYvhdoH08n02ETaxqzuySXi7ppr0dpmtm6QaialHcPNls6FXxMUex2G5+ FL7w22CBsofgz79KP30fWTHWPkw7swI3BS392RD1OvdYgSBxEahD7l3etZ29mHLZCx0j npN2bKalWjEeKPzsdPgewxxZ23F6RFQadjt5GA+UqAaNG1tIvxHj0ltKDVPocpQeTUgM GU0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=pkEmdOUIaQ2fcxULAMiPJMta+BiOnpt78/iY/6t9l84=; fh=w/DbD/JgzjJbt9Tp67WPkJFhu+jLXY/4pfIhBm6wVVQ=; b=JqH4uLCbvUy6fwsxXqMnq9f38auavRQUvFwgaw+DKlVuaRuFXfyaUASKmH2naodNw0 oMMa/tjvIJn6Hdh6b5tLwNLGwKT+6WoVXmItcRiJyAu1ZqKiTp9TCbWTREOMtZVG1Jkh HJT20DLMmOg7SnBA6mQEdg777MHO85+0l2wGe0oapGd8w0K8+5+yS+25dFd9EgCKVSir B8LOsMHmHaIwDeKnDaH3zfYUi2uIPLTg5b4eujytJZOtDr6cUbZPFn3LRs8LNfh648A+ z+Adqq4m/Kh8cktw3DbmVxqVgJT0g0WVwYhRf7ZBYP6hiQXaqh8lmDBMhQ5rLar/nmUJ FNhg==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1728640861; x=1729245661; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :sender:from:to:cc:subject:date:message-id:reply-to; bh=pkEmdOUIaQ2fcxULAMiPJMta+BiOnpt78/iY/6t9l84=; b=SuOWoNccXKqZH7Zv9xc9cLuGYlIgh7u/upMaEh8FKvvil+nA8LHFgQhIbR6f/IPBhp aXZG8F7uQxhQ+9LwCpBZ/8rH2cfVWFBAQl8h7TzPJmlfZfyKElIQUhjOOPT2+01Pz0MQ 6ZdZzKyGTBMYzo2lt2UsjxM6T50hhxwshXP5qSG3ALSiAkWj2lKk53OkU5losXzj5/Aa 0K95IELbBQ9Ip7Ti/jBSsoehvGXw4FzxpngbcYirOBKjpKT6LidOhddAjbj/BhveDDLR 8EgKGX0GQF9Ew6KRNA0DHUQrdaXRIvag6VFt/ufXRiWcaZbffax/SB7d653ekTVafjqc 91wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728640861; x=1729245661; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :sender:from:to:cc:subject:date:message-id:reply-to; bh=pkEmdOUIaQ2fcxULAMiPJMta+BiOnpt78/iY/6t9l84=; b=FwdzAvzEM6Av/UFAXI3H3MiwmBWxVRzbDwe5jSfluUb1AZQ2dHZcbbyzNjh6jabAls FPlmFzY4IlUvuboC9nrUUBkpxbizojqryFTF1C818/+sgWYyMnx/6a0xHOXietqCkuBG rcxvKVTTUndkVs2VMe0k6pwv81h8OEuwctSxqCNwiepMeC3bFtOnql39JXeZ9B/WQz8F qK9LF9G3R+ZpGYHKZ265a0WNIMCgwISpK3IKmgxoACmkIlpEjovgMA8gBzd5hdCfHepU nJZFWgMtj+x1XcS75+fKzPyvBnH7rKUZ6LDQDmkljJ7sNUrbL4vy24KSJAtplpywA1Pr FZ0A== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCXV5WKuIZy4tWKwZt72UmUc1xlUzFVgjC8pYjLlYy4dTr3Qa9Ml0cKsH4m6nRqEH0+0aCscK4A=@isar-build.org X-Gm-Message-State: AOJu0Yz0ceoWyPsI6HhGuiGQqSZXE4hq2PSXl8UtTHN541jZG2UxUjn9 caj5Qcw52IucGqqe5hQmnFAKGqXhwYFG7creqkaZmhjnLbfR3XLL X-Google-Smtp-Source: AGHT+IGpMiZ4fEPZNKG0UTA3vQCRA+viADVhybmtSh4o1HLtW0y6DNNz2xufRbXy+zvYT7GVsw/vfA== X-Received: by 2002:a05:6e02:20e9:b0:3a1:a2b4:6665 with SMTP id e9e14a558f8ab-3a3b58cac98mr11272835ab.12.1728640861341; Fri, 11 Oct 2024 03:01:01 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6e02:1d08:b0:3a0:99ea:845a with SMTP id e9e14a558f8ab-3a3a743d610ls5603395ab.2.-pod-prod-00-us; Fri, 11 Oct 2024 03:01:00 -0700 (PDT) X-Received: by 2002:a05:6602:1608:b0:7f6:8489:2679 with SMTP id ca18e2360f4ac-83783a882d1mr114589839f.8.1728640860020; Fri, 11 Oct 2024 03:01:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728640860; cv=none; d=google.com; s=arc-20240605; b=CS/AomcYhnw7iOGC9hGZAYtdRwaDtMIkZqc+6aqlcyHm/hcv4y93SuNQYW77cMxERu eJfKQrXombavMcBV2qTb8R8ejH9yssqSMuu818lfopKfbkQtyJX/0Ve7pao1JIphTtV+ TxyVJ1gEhjg2w9+RigtTrH+j7wFh71xdj8eMvx33ro1eWwzesmkAYtz9isxDFLwDfahJ pwMfGRc2/o1bg5gg55sjfOjI/Bv27d8igryb4en9HKDz2ruMyCra0rKy4pRT62iaIZr7 ZS/SYrgSYoT28UIthOBKxJPBM4AgUQA4QfE1qFuaQIG2rmZl9u/xL0TWD0aROoiXXrFW 8ZRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=G5SgFGfBOxy4jEaFrp6kqG5TH5rsad37LDkuDGAD9EI=; fh=/h9QQkzJ8EboVkWg45aWwpaUro6WMavIVd2OhN45RtE=; b=F49/TQbBfC6fBV+RLKXFF5hc4OcBDujQQQMU6pYf3+8Xqjg07/V5BDoLVkmoxgA9gx fCQNkVf03faJwPb9lvrsojWntZontqoTAcJqMBREt+IGcABEwGWf/93BtZ1bz9hvAOqy 4ZNlu5oh4q7OYcHNzAzItUrR7VKlsRQrwWPKmQjO8zImyEhpBdvDq4VWAfETfvgxsAXZ T2+hndCVwRcfMurQVazfTCYXNlGUC6gXEKy9nAy5BuNxceliktvUF4Ykvu5gkFQBZAwt msMQHCf6D9VlbnB2SWbElaFnNSplYcMiaHBm3e5vxmu5DaExz4Z1FXnJFI3ogiHBS7AY zA7g==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id ca18e2360f4ac-8354b8cdf03si10829439f.1.2024.10.11.03.00.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Oct 2024 03:00:59 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from user-B660.promwad.corp ([159.148.83.114]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 49BA0vWH008632 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Oct 2024 12:00:57 +0200 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH v3 0/8] Hanging mount fixes Date: Fri, 11 Oct 2024 13:00:42 +0300 Message-Id: <20241011100050.322686-1-amikan@ilbers.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: amikan@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= Consolidate the patches to address the hanging mount issues. Addresses the following issues: 1. Cleanup handler is called multiple times, unmounting any hanging mounts. 2. Hanging mount warnings are discarded in the current setup. 3. Incorrect asymmetric mount-umount logic inherited from buildchroot times. In this series, cleanup is done in reverse /proc/mounts order to unmount e.g. /dev/shm before /dev. This happens to work for us today but we could perform stricter semantic ordering if necessary. ISAR_FAIL_ON_CLEANUP=1 can be set in the environment to fail builds if mounts are left behind. We will use this for Isar CI. The default is 0. p1 comes from 'Additional CI improvements' series. Patches p4-p6 come from v2 of 'Start to address umount problems' series by Jan. p7 comes from 'Fix leftover mounts in rootfs.bbclass' by Florian. p2, p3 and p8 are new one. Anton Mikanovich (4): CI: Do not lose output on bitbake / qemu exit isar-events: Unhide mounts left behind CI: Pass ISAR_FAIL_ON_CLEANUP from environment to bitbake image: Do not call rootfs_do_umounts twice Florian Bezdeka (1): rootfs: Add missing umounts in rootfs_postprocess() and rootfs_install() Jan Kiszka (3): image: Avoid breaking the build when mounts are no longer present on umount rootfs: Provide rootfs_do_umounts initramfs: Add missing umounts after generation RECIPE-API-CHANGELOG.md | 15 ++++++++ meta/classes/image.bbclass | 19 ---------- meta/classes/initramfs.bbclass | 2 + meta/classes/isar-events.bbclass | 40 ++++++++++++++++---- meta/classes/rootfs.bbclass | 63 ++++++++++++++++++++++++++------ testsuite/cibuilder.py | 13 +++++-- 6 files changed, 110 insertions(+), 42 deletions(-)