mbox series

[v2,0/1] deb-dl-dir: fix package source download

Message ID 20250124091219.3489707-1-benedikt.niedermayr@siemens.com
Headers show
Series deb-dl-dir: fix package source download | expand

Message

Niedermayr, BENEDIKT Jan. 24, 2025, 9:12 a.m. UTC 
I recently wanted to download all source packages for a specific image and encountered
that some of the source packages were missing (e.g. adduser).

I tracked the issue down to the deb-dl-dir.bbclass and found that the
"is_not_part_of_current_build" function skipped the source package download
because the "adduser" package was not listed in the "/var/log/dpkg.log" file.

I assume that this package has been installed during early debootstrap
and therefore the package is not listed in the dpkg.log file.

**As discussed in V1, the issue has been introduced with mmdebstrap, which
either doesn't create or deletes the dpkg.log file.**

I'm not sure if I got the comment in the function right:

"Since we are parsing all the debs in DEBDIR, we can to some extend
try to eliminate some debs that are not part of the current multiconfig
build using the below method"

AFAIK we could also achieve this by running dpkg-query commands on the target
filesystem and also catch the packages that have been installed during bootstrap.

I'm not sure if this patch will interfere in any way with multiconfig builds,
as mentioned in the comment above, but I think it's worth a try.


Changes since v1:
- Adapt the commit message: Make it clear that the problem
  has been introduced with mmdebstrap


Benedikt Niedermayr (1):
  deb-dl-dir: fix package source download

 meta/classes/deb-dl-dir.bbclass | 39 ++++++++++-----------------------
 1 file changed, 11 insertions(+), 28 deletions(-)

--
2.34.1