| Message ID | 20221028142145.4428-2-henning.schild@siemens.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | expand-on-first-boot CI testing | expand |
Say there are longer discussions. I think this one can be picked and might not need much talking about. Henning Am Fri, 28 Oct 2022 16:21:44 +0200 schrieb Henning Schild <henning.schild@siemens.com>: > What was called "servive_prompt" is not a prompt nor a service. > Document what that is and rename the variable. > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > --- > testsuite/cibuilder.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py > index d5c83b222d50..07a9edc56d9c 100755 > --- a/testsuite/cibuilder.py > +++ b/testsuite/cibuilder.py > @@ -229,7 +229,8 @@ class CIBuilder(Test): > self.log.info('QEMU boot line: ' + str(cmdline)) > > login_prompt = b'isar login:' > - service_prompt = b'Just an example' > + # the printk of recipes-kernel/example-module > + module_output = b'Just an example' > > timeout = time.time() + int(time_to_wait) > > @@ -263,7 +264,7 @@ class CIBuilder(Test): > if os.path.exists(output_file) and > os.path.getsize(output_file) > 0: with open(output_file, "rb") as f1: > data = f1.read() > - if service_prompt in data and login_prompt in data: > + if module_output in data and login_prompt in data: > return > else: > app_log.error(data.decode(errors='replace'))
diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py index d5c83b222d50..07a9edc56d9c 100755 --- a/testsuite/cibuilder.py +++ b/testsuite/cibuilder.py @@ -229,7 +229,8 @@ class CIBuilder(Test): self.log.info('QEMU boot line: ' + str(cmdline)) login_prompt = b'isar login:' - service_prompt = b'Just an example' + # the printk of recipes-kernel/example-module + module_output = b'Just an example' timeout = time.time() + int(time_to_wait) @@ -263,7 +264,7 @@ class CIBuilder(Test): if os.path.exists(output_file) and os.path.getsize(output_file) > 0: with open(output_file, "rb") as f1: data = f1.read() - if service_prompt in data and login_prompt in data: + if module_output in data and login_prompt in data: return else: app_log.error(data.decode(errors='replace'))
What was called "servive_prompt" is not a prompt nor a service. Document what that is and rename the variable. Signed-off-by: Henning Schild <henning.schild@siemens.com> --- testsuite/cibuilder.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)