dpkg-base: set default for RPROVIDES

Message ID 20230112094118.2281568-1-adriaan.schmidt@siemens.com
State Accepted, archived
Headers show
Series dpkg-base: set default for RPROVIDES | expand

Commit Message

Schmidt, Adriaan Jan. 12, 2023, 9:41 a.m. UTC
This is a follow-up to 40a53789d46763441715508b82154c976700075b

When RDEPENDing on something that is not the PN of a recipe, bitbake needs
a corresponding RPROVIDES.
While Yocto is very precise with definitions of DEPENDS vs. RDEPENDS (and thus
also the RPROVIDES are properly maintained), the Isar way is to specify build
dependencies with DEPENDS, and runtime dependencies with DEBIAN_DEPENDS.
This sets a sane default for RPROVIDES, and most users should be able to
use RDEPENDS without explicitly overriding it.

Acked-by: Felix Moessbauer <felix.moessbauer@siemens.com>
Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
---
 meta/classes/dpkg-base.bbclass | 1 +
 1 file changed, 1 insertion(+)

Comments

Uladzimir Bely Jan. 24, 2023, 7:38 a.m. UTC | #1
In mail from четверг, 12 января 2023 г. 12:41:18 +03 user Adriaan Schmidt 
wrote:
> This is a follow-up to 40a53789d46763441715508b82154c976700075b
> 
> When RDEPENDing on something that is not the PN of a recipe, bitbake needs
> a corresponding RPROVIDES.
> While Yocto is very precise with definitions of DEPENDS vs. RDEPENDS (and
> thus also the RPROVIDES are properly maintained), the Isar way is to
> specify build dependencies with DEPENDS, and runtime dependencies with
> DEBIAN_DEPENDS. This sets a sane default for RPROVIDES, and most users
> should be able to use RDEPENDS without explicitly overriding it.
> 
> Acked-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
> ---
>  meta/classes/dpkg-base.bbclass | 1 +
>  1 file changed, 1 insertion(+)
>

Applied to next, thanks.

Patch

diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index 260aa73e..5cda42c0 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -12,6 +12,7 @@  inherit repository
 inherit deb-dl-dir
 
 DEPENDS ?= ""
+RPROVIDES ?= "${PROVIDES}"
 
 DEPENDS_append_riscv64 = "${@' crossbuild-essential-riscv64' if d.getVar('ISAR_CROSS_COMPILE', True) == '1' and d.getVar('PN') != 'crossbuild-essential-riscv64' else ''}"
 DEB_BUILD_PROFILES ?= ""