From patchwork Sun Jun 4 09:32:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinuvasan Arjunan X-Patchwork-Id: 2879 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Sun, 04 Jun 2023 11:32:46 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-ej1-f62.google.com (mail-ej1-f62.google.com [209.85.218.62]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 3549Wk8G019693 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 4 Jun 2023 11:32:46 +0200 Received: by mail-ej1-f62.google.com with SMTP id a640c23a62f3a-94a34d3e5ebsf252960266b.3; Sun, 04 Jun 2023 02:32:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1685871160; cv=pass; d=google.com; s=arc-20160816; b=vCMDM+yquEIPs1Zy5Z64sCK5kZsgkeRB8BRdcVuHpuNvE6/qSSxCTgNymN7lzfh66e WqXGY0VBOnNkrdzOo5mTN/D8h4Xe/mLg8oAgmQTju5bYx2kVPTa0Pwo13jG+loT01EzE eoo+dpyk2CwPDfh9TQInBrMa+xj//pkl6h5jL3HiwS3lCihfPo4xU3Fg8kIZgjUGAr6R Pqacw4urLjC7qIeWtS75M8RpwOTCHG5U16plCrC5e8pfPUTFErze4jFXH/kSDhYcubfk Yl+GNsD+B9bARG+LdPU8wj64CWaZlO04L2Gr2AmKBVp7Aa4NxTkI4QIOpe3NOxnScerI RhbA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:ironport-sdr:sender :dkim-signature; bh=QuNJXyG7V+dE+AMamVzmf3I1e2eqOpmxkWVTMJAIcd8=; b=ABO6fC6N34G6/E6550TVaUFSiZ+Qf1PZ5cT4jrAblU2VDid5yI2oIS/rX9eChRV0WM adFi63nOH/cRGnecw+KLcrJNJpdn2/wKplf3Y2I7dvSsmbJgSCzqwqBDCUzAQrRhexio 52uj+g9QDfR4h19jpKWXpGncpizyBS56KMcWvDdAX8m7GtuWeV+bmEUVcxrmSoKX5YiA 3Nuz17HbvOB7Tnnd3FBYpGoDVqjRI7Bq5fDNZPlRE0uo2LXjKWdKQX8e38cfeFE1/Bg3 KyI0At7hf67vBplqs1R31C0Elzo8eyXGibMhcYHDZ0QusAeyqeiGzTs8HnuvuWOJ0565 rYlQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Srinuvasan_A@mentor.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20221208; t=1685871160; x=1688463160; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:ironport-sdr:sender:from:to:cc:subject:date :message-id:reply-to; bh=QuNJXyG7V+dE+AMamVzmf3I1e2eqOpmxkWVTMJAIcd8=; b=ijU/kg+M406RZXFaGHO+C2p5UVaRLu6h0iWAqvK7Twy7+cxFifHQ14hBShWyFdeCTw QNoTB2ugk6fqh93DGf5TwIUEESNImaW+zhpfxPtbncMqheXoiglwJ3CcXihzmcubE9JG /AMsBXWiH7b+O7ajvtbU8WdVjD/S1dAEtFa4Ri7Bu+rj6jum/J+ltdQxF0ozv/BFbs4e 8vdQSdP3ZXBzKL98LMWduitfLU8R8ON8EwQYXGBifiEZVq7bPCX5cLIkSJ2Uqni+NR1I yG9bt2vC7utDDyYCMvmR4C+YOLi6YyjGsywF4dkZTaE4qtod7r2vlSVpiC/+ruqWXZBh JiWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685871160; x=1688463160; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:x-beenthere:x-gm-message-state:sender:from:to:cc :subject:date:message-id:reply-to; bh=QuNJXyG7V+dE+AMamVzmf3I1e2eqOpmxkWVTMJAIcd8=; b=IcByUuZhyBu6EBMxA6ehcQc3CHZvvcBHkWvPL6flJHS3JabKwQP5t95b0+nteFXpkJ ah2qCyr/iTYvt3x4mrDHyGiPVtume78CfYLdZwl7bjsvqdPLuzmQL/FtM7Nr4Sa2t+OL WS90eNVKbYkYEfbKufb/+e2ipAGXkzY6lJkYZzwJUHBnGwSthcWvYmUZiEP1y/+UfvSh zfdAiPTmwAxcEDuT9Rhhks1r3Fa32zcuoRn6Vsvf8buZat3FRhRpLwXw3XuOBgETP1Og Vvej50EyZhOmGc8KXFPha8SHhgzfqPp6/c+MXYZQ17qNyFrwl8BNXT656QAyyVV6tjlE Tk+Q== Sender: isar-users@googlegroups.com X-Gm-Message-State: AC+VfDxMOSzCqnYzAlSBHvPtpgdUsH0zSJ+NE88wi1VeKtVldoy1eXjb LzLWvSjwTy8XRGjtzI1qY2A= X-Google-Smtp-Source: ACHHUZ6JSyBst9NT2aeNTQcp7PTF2oAzBy44FDoEf86jGaCYI6eJScgaIsbWrNUzAxHPIwl/V2wTKg== X-Received: by 2002:a17:907:7ea9:b0:966:484a:335e with SMTP id qb41-20020a1709077ea900b00966484a335emr4262298ejc.43.1685871160145; Sun, 04 Jun 2023 02:32:40 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1c26:b0:3f6:971:c0a6 with SMTP id j38-20020a05600c1c2600b003f60971c0a6ls97986wms.0.-pod-prod-02-eu; Sun, 04 Jun 2023 02:32:38 -0700 (PDT) X-Received: by 2002:a7b:cc05:0:b0:3f4:1cd8:3e99 with SMTP id f5-20020a7bcc05000000b003f41cd83e99mr5381411wmh.28.1685871158917; Sun, 04 Jun 2023 02:32:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685871158; cv=none; d=google.com; s=arc-20160816; b=JWheztk8Q12xOyhG46vSAbJ7W/kA5HxaTDQ9tVkhS3lxpmDcoEOxXor/Q5wc7yAlqX m+GiWkPvVyNTvRCA0sBpzAa1wt37tX88F9vK2Sj53FsHIDOLHd0giNS3gR1HztFxnd2l 4ploEtqwEprq/swhyvJnO+quy+YwjMtyPGzhdMS3mZkVSl2UYOUkrdEjVP70gDDLhF17 D1Miy6qNc1zki2qaXJ7wed2qJkMOZKctF/ALOt7Q8qT47uAmfsaMuPxvQQPtYK6hkE91 QXTxDOyRVr7E1XlRqvt3gfWFN8OvAWSDQ4aipce4xYgzz3ku0/sRzr3uBn3F1iRVsFzy Sr7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:ironport-sdr; bh=O4E14Zr7MvBjvM/puVDTrlZ5ttOivpUqKFI3Oy3hBG8=; b=CH+p3QwFlbB91TcMsqUsWxnHZh+5Eb9V0HrqjlNH3IIwrsjXTtHzQA/S/EZLJlELmG aBa5q6WdxISNED2L+kMUxAgC47RL0FZCIjKZQOijBLnJzxCBTWyM4pexbxZompzDUUYU ND6QA7yu7omjPbfVymSWkvvMjYdwNdSm4SYeRS5h0CJ3MQFjKT6aSuEG3EAr57stkX9U d8Gh1dM9stutmIrw/vlv4GbszOfAxfjpW8TBeowedqT2Ny/wNMVEQIOwVSKEL3GO8vR6 GAfxDwgIUZV1MN4BEU/U+8JD0yMnpKNf+kNXeRfpRZNltWtqtKtC1jON7RqknRzojZGd rv/g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Srinuvasan_A@mentor.com Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com. [68.232.137.252]) by gmr-mx.google.com with ESMTPS id az16-20020a05600c601000b003f42786c7b4si760180wmb.0.2023.06.04.02.32.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jun 2023 02:32:38 -0700 (PDT) Received-SPF: pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) client-ip=68.232.137.252; X-IronPort-AV: E=Sophos;i="6.00,217,1681200000"; d="scan'208";a="7607770" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 04 Jun 2023 01:32:36 -0800 IronPort-SDR: o4Z7As75mmrPMHqSOv4Jej9h+CyomaVzNwp5/7V0ButWVYB2oYj7nAhAtrarXz5W6f/z+JvKKy 46/KvQtp4IEudTMHM/+Zwd7lf4W454uL4FNR8+wrtpTJOceEJqsBMxaydcIcgYixi6Kr4fzoVT boLSYtHo7ry/ZmGW9HH9+N0jfihWsUg2sG1UW6zooZE1N3nZtdIkOHUc5ebLtvPvDGTE4QSp9y OSsmpFiW/tJEQOZRVWxW8bc2R1KGyaiCmOQG8SnFDWYvLRwLXyerKFjNMFcl1Qgu4Quh9ZkJnz d6M= From: Srinuvasan Arjunan To: CC: , , Srinuvasan A Subject: [PATCH] meta/classes/crossvars: move sdk toolchain selection from python block Date: Sun, 4 Jun 2023 15:02:16 +0530 Message-ID: <20230604093216.1094289-1-srinuvasan_a@mentor.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <46a03938-0343-4221-a57c-efba80b27c83@siemens.com> References: <46a03938-0343-4221-a57c-efba80b27c83@siemens.com> MIME-Version: 1.0 X-ClientProxiedBy: svr-orw-mbx-10.mgc.mentorg.com (147.34.90.210) To svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) X-Original-Sender: srinuvasan_a@mentor.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Srinuvasan_A@mentor.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Srinuvasan A In the present implementation we are not able to override the SDK toolchain from downstream layer, this is due to the SDK toolchain selection part in anonymous python function. Anonymous python functions always run at the end of parsing, regardless of where they are defined even when we do override in our recipe, always wins the Anonymous Python functions variable settings, hence we are not able to override our downstream toolchain. Move the SDK toolchian selection from python block, now we can able to override from downstream layer. Signed-off-by: Srinuvasan A --- meta/classes/crossvars.bbclass | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/meta/classes/crossvars.bbclass b/meta/classes/crossvars.bbclass index 201d460..120e6d1 100644 --- a/meta/classes/crossvars.bbclass +++ b/meta/classes/crossvars.bbclass @@ -5,6 +5,10 @@ ISAR_CROSS_COMPILE ??= "0" inherit compat +SDK_TOOLCHAIN = "${@'build-essential' if d.getVar('ISAR_CROSS_COMPILE') == '0' or d.getVar('HOST_ARCH') == d.getVar('DISTRO_ARCH') or d.getVar('DISTRO_ARCH') == None else 'crossbuild-essential-${DISTRO_ARCH}'}" + +SDK_TOOLCHAIN:append = "${@' crossbuild-essential-${COMPAT_DISTRO_ARCH}' if isar_can_build_compat(d) else ''}" + python __anonymous() { import pwd d.setVar('SCHROOT_USER', pwd.getpwuid(os.geteuid()).pw_name) @@ -17,19 +21,14 @@ python __anonymous() { sbuild_dep = "sbuild-chroot-target:do_build" buildchroot_dir = d.getVar('BUILDCHROOT_TARGET_DIR', False) buildchroot_dep = "buildchroot-target:do_build" - sdk_toolchain = "build-essential" else: d.setVar('BUILD_HOST_ARCH', d.getVar('HOST_ARCH')) schroot_dir = d.getVar('SCHROOT_HOST_DIR', False) sbuild_dep = "sbuild-chroot-host:do_build" buildchroot_dir = d.getVar('BUILDCHROOT_HOST_DIR', False) buildchroot_dep = "buildchroot-host:do_build" - sdk_toolchain = "crossbuild-essential-" + distro_arch d.setVar('SCHROOT_DIR', schroot_dir) d.setVar('SCHROOT_DEP', sbuild_dep) d.setVar('BUILDCHROOT_DIR', buildchroot_dir) d.setVar('BUILDCHROOT_DEP', buildchroot_dep) - if isar_can_build_compat(d): - sdk_toolchain += " crossbuild-essential-" + d.getVar('COMPAT_DISTRO_ARCH') - d.setVar('SDK_TOOLCHAIN', sdk_toolchain) }