dpkg-base: Fix task devshell_nodeps

Message ID 20230627054422.33699-1-Quirin.Gylstorff@siemens.com
State Accepted, archived
Headers show
Series dpkg-base: Fix task devshell_nodeps | expand

Commit Message

Quirin Gylstorff June 27, 2023, 5:44 a.m. UTC
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>

The task devshell_nodeps fails with:

sudo: /etc/sudo.conf is owned by uid 65534, should be 0
sudo: /usr/bin/sudo must be owned by uid 0 and have the setuid bit set

as the options do_devshell_nodeps[network] is missing.

Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
 meta/classes/dpkg-base.bbclass | 1 +
 1 file changed, 1 insertion(+)

Comments

MOESSBAUER, Felix June 27, 2023, 5:46 a.m. UTC | #1
On Tue, 2023-06-27 at 07:44 +0200, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> The task devshell_nodeps fails with:
> 
> sudo: /etc/sudo.conf is owned by uid 65534, should be 0
> sudo: /usr/bin/sudo must be owned by uid 0 and have the setuid bit
> set
> 
> as the options do_devshell_nodeps[network] is missing.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>

Acked-by: Felix Moessbauer <felix.moessbauer@siemens.com>

> ---
>  meta/classes/dpkg-base.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-
> base.bbclass
> index e3412c82..7b02f378 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -339,3 +339,4 @@ python do_devshell_nodeps() {
>  addtask devshell_nodeps after do_prepare_build
>  do_devshell_nodeps[dirs] = "${DEVSHELL_STARTDIR}"
>  do_devshell_nodeps[nostamp] = "1"
> +do_devshell_nodeps[network] = "${TASK_USE_SUDO}"
Uladzimir Bely June 30, 2023, 11:57 a.m. UTC | #2
On Tue, 2023-06-27 at 07:44 +0200, 'Quirin Gylstorff' via isar-users
wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> The task devshell_nodeps fails with:
> 
> sudo: /etc/sudo.conf is owned by uid 65534, should be 0
> sudo: /usr/bin/sudo must be owned by uid 0 and have the setuid bit
> set
> 
> as the options do_devshell_nodeps[network] is missing.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>  meta/classes/dpkg-base.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-
> base.bbclass
> index e3412c82..7b02f378 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -339,3 +339,4 @@ python do_devshell_nodeps() {
>  addtask devshell_nodeps after do_prepare_build
>  do_devshell_nodeps[dirs] = "${DEVSHELL_STARTDIR}"
>  do_devshell_nodeps[nostamp] = "1"
> +do_devshell_nodeps[network] = "${TASK_USE_SUDO}"
> -- 
> 2.40.1
> 

Applied to next, thanks.

Patch

diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index e3412c82..7b02f378 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -339,3 +339,4 @@  python do_devshell_nodeps() {
 addtask devshell_nodeps after do_prepare_build
 do_devshell_nodeps[dirs] = "${DEVSHELL_STARTDIR}"
 do_devshell_nodeps[nostamp] = "1"
+do_devshell_nodeps[network] = "${TASK_USE_SUDO}"