classes/sdk.bbclass: remove additional "/" in new_target finding

Message ID 20230704102416.2646313-1-srinuvasan_a@mentor.com
State Accepted, archived
Headers show
Series classes/sdk.bbclass: remove additional "/" in new_target finding | expand

Commit Message

Srinuvasan Arjunan July 4, 2023, 10:24 a.m. UTC
From: Srinuvasan A <srinuvasan.a@siemens.com>

We observed that one additional / present in finding the new_target,
here target already start with /, hence no need to append the additional
/.

In functionality wise there is no change.

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 meta/classes/sdk.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Uladzimir Bely July 11, 2023, 6:40 a.m. UTC | #1
On Tue, 2023-07-04 at 15:54 +0530, Srinuvasan Arjunan wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> We observed that one additional / present in finding the new_target,
> here target already start with /, hence no need to append the
> additional
> /.
> 
> In functionality wise there is no change.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/classes/sdk.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
> index c6dc689..3d650a1 100644
> --- a/meta/classes/sdk.bbclass
> +++ b/meta/classes/sdk.bbclass
> @@ -98,9 +98,10 @@ sdkchroot_finalize() {
>      for link in $(find ${ROOTFSDIR}/ -type l); do
>          target=$(readlink $link)
>  
> +        # Enter into if condition if target has a leading /
>          if [ "${target#/}" != "${target}" ]; then
>              basedir=$(dirname $link)
> -            new_target=$(realpath --no-symlinks -m --relative-
> to=$basedir ${ROOTFSDIR}/${target})
> +            new_target=$(realpath --no-symlinks -m --relative-
> to=$basedir ${ROOTFSDIR}${target})
>  
>              # remove first to allow rewriting directory links
>              sudo rm $link
> -- 
> 2.34.1
> 

Applied to next, thanks.

Patch

diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
index c6dc689..3d650a1 100644
--- a/meta/classes/sdk.bbclass
+++ b/meta/classes/sdk.bbclass
@@ -98,9 +98,10 @@  sdkchroot_finalize() {
     for link in $(find ${ROOTFSDIR}/ -type l); do
         target=$(readlink $link)
 
+        # Enter into if condition if target has a leading /
         if [ "${target#/}" != "${target}" ]; then
             basedir=$(dirname $link)
-            new_target=$(realpath --no-symlinks -m --relative-to=$basedir ${ROOTFSDIR}/${target})
+            new_target=$(realpath --no-symlinks -m --relative-to=$basedir ${ROOTFSDIR}${target})
 
             # remove first to allow rewriting directory links
             sudo rm $link