From patchwork Wed Jul 26 04:59:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "MOESSBAUER, Felix" X-Patchwork-Id: 2984 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 26 Jul 2023 06:59:48 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-ed1-f55.google.com (mail-ed1-f55.google.com [209.85.208.55]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 36Q4xlrQ020989 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 26 Jul 2023 06:59:47 +0200 Received: by mail-ed1-f55.google.com with SMTP id 4fb4d7f45d1cf-51a595bc30dsf626770a12.0 for ; Tue, 25 Jul 2023 21:59:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690347582; cv=pass; d=google.com; s=arc-20160816; b=tgdgpisW5zIWZX8aTs/4kY5vPUSnz+kp41s9wgaJ4YGiF2o+sCACguaow9dTc93tPN zFrPi9hSu8rTmrvK2qUiAOndDclgGUSWJrIrWzJfUoXNrPNdvcACXIlkNAEbgT8jch0i gYtwuO8ULb5/8yE5kYMXG3JE3cJZssHoHfTFHtPSJc0zk4pU+nNbzJJX0zImK7mv5NIr Hu4C5rBjnksNLyNnDEgqoiooHv05Kh6HTkoW0+Dk50ZiSJ5PzDRHWIuFUnRPtb+QYME/ jWJ+fMWk74b2VW8sR2lgYf1KSaj8kkmo4tybbtF7dagg/v3YGtkL+uLPbLFSYAyA6BNi SBPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oTEnSxSDD6pUPCAGPW6vjAcVDQYC0iQwZog97dyhQ8I=; fh=JKqf9J7hlNlz24Nl/HODZL3o+A6ZAkdjinVSl7OE0r0=; b=Y0mYGCDJXHl+26NsINOzK1kdWPHrxD2AusEpzmUmL+s6SqAnq21uqKTriK5fMCIEQv JMIF4dErOQOWfk7A0NIo3lOvnqI+dvmiR6naZJeYVo+Vvmyzi8oQfvIPo4qqeqwWHhu1 zfVsfu2ZQ+yDAIxWT2Y9n9GOs3VZbJvSTwbYDMNO46ceRkR7YKA5CUYRXLsMsbtGVALa IBEeYWcNsUMROtqvgMP1i/7LILPyzNopf7KqtLEphOHIQB4hpb40Q0wuN0CT9hukNnME DDA7aNHPbaG9Qrf9LlTqNs2dAT3VAWOKXbqcFn9taUPNjEqrAeme5aR7P5s+1fVjwGbj RGow== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=CyJUJaww; spf=pass (google.com: domain of fm-72506-202307260459395a287a0960ea006cc1-ll7ydt@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-72506-202307260459395a287a0960ea006cc1-Ll7yDt@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20221208; t=1690347582; x=1690952382; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=oTEnSxSDD6pUPCAGPW6vjAcVDQYC0iQwZog97dyhQ8I=; b=s/EGhfzDoZtdxMnEwXKSgL6+EfTRXEjvm969/WIoWAdOjEX0G6ZyryceKcWz4BCCrR ovMgHKNqCYolnSGPw3v73VKZ8GTY4Yuki2T5vcK2eBrkqZBZrPpomO2QQ/lGbV7M+o7q aJwfet979ogqLn2rtp+gT0fsLJOO9CvU5akiTtaGHPwn9dyoD3mwCljf8BMTtqxKUODA eMSs01QV955VLMG82GMqe6Fdg9DBK+UyP9sHGsrIK4wsjSyCPlYybCB8FXOO++aY44fA WU/IbFHk7fv99AiZAqktTRwJun2dc1uR6/thi9d44kgKjrimqNVrxr42WqPgZC6hodaM Nazw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690347582; x=1690952382; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oTEnSxSDD6pUPCAGPW6vjAcVDQYC0iQwZog97dyhQ8I=; b=iSjuN0RXiZgC7okSVbKeMrL5v7wTQR7RuyzV821cjovqhdS1wUAxoOVWwQBc1Zcnu5 pwLLeBXbOTXL5gx3QulpA4HV0IjEff7mnzYXqoQQn3yjZfVcfQsudw2H4pVotaR7CwIe 72Qt83BLmQFuB+yMPM3muElZfxuFj0pRy3kVJ1CPvnD1suiCth13oAJjsd2VmRq+62sb ilOcK2TAmybY+B39yYIs6U1ix9uWybNuID5g6A/mrHGiWhKz7PNY9XzzInWtBvItgpg+ hqqRi9smLvQPFidkp35xWUfJ/gvIC5DEoqzNxodfcX1SxP5nNVayJbPeeENlfTvWLf9j ZG2A== X-Gm-Message-State: ABy/qLaSJMYERE2dL+jcMDelgl1MnSUlcBYOU0y9hmbE2pE0uWLkg0YP CjIA88OgeTY4BC30wl1Yf88= X-Google-Smtp-Source: APBJJlF6Z1vZhzvkc35Atb2Awss76Z1RZKzfdiLd9LNJg2p5hljyz2WxcwC4hSkqTWvSmw6Ehm0txQ== X-Received: by 2002:aa7:d3c8:0:b0:522:18b6:c01f with SMTP id o8-20020aa7d3c8000000b0052218b6c01fmr1333702edr.3.1690347581670; Tue, 25 Jul 2023 21:59:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:1808:b0:51b:d432:a176 with SMTP id g8-20020a056402180800b0051bd432a176ls804694edy.2.-pod-prod-00-eu; Tue, 25 Jul 2023 21:59:39 -0700 (PDT) X-Received: by 2002:aa7:d85a:0:b0:522:4cb6:d1e3 with SMTP id f26-20020aa7d85a000000b005224cb6d1e3mr1177786eds.10.1690347579637; Tue, 25 Jul 2023 21:59:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690347579; cv=none; d=google.com; s=arc-20160816; b=wpMhYX02IJn33OI7NY3KznUvpYtyz+kWB9hCCsF+QG9pn8jMuHp/DpSxThXWCRMQ13 X3/j4PllFcXGktwSBYsWZZM0tkWOJdXkF1MeYaHNCr6iHKEotML6y50wr6qcmmQiVyCj g1g7sNmGmOuftLrf1Xtz0hzvZSxEVMiQSYKDWVlOmXV0plq7Apaaz8D6AWKa3Y+Og/bS y+614nSwhofNEOl6QQDgFdcXw68ZiOeos1oUV705fp06K7ODDR8IosqpgrfPEqSEOGFL 4wBK3SNiyY8+RFpOdxta1XgtaGXOaycNfomlsm8sXxI7ucPwJaBrdYJeoyZuLnvj7yxx JLfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=k6Gjyfky9UKQDT2df89/91SYNhpD81vRPvaHhPIXQF0=; fh=JKAk5g9OeEpZsHSr5t9bMJhmzqtLpjZpEcjmUiZCWCM=; b=JAOV6vc0V6kG++72Dyr+sg2AfWfq4DKK7pqPCS3QYvYvB+vJt43N49v+odGcNmr6UZ ZxKUn3aap3pUTMBl6mVzcrGNlV/NhxlmFKqZa2PmlFoEDMPiLaTUOjDyXWLh1Va8x+A+ faKljcqYv2qJyJ43pcl6NUuS/hu4jC2uDT4iL4EhtfxPST21YZobB4mojiBjoSvOEGfI zv566EwemdR+z+JJIud9FUnensAOs7LQGxGW+2JUrkc8zBcULik6Iy2JIO3Mr34rBB2Z R/FbM3B0xqCDaqEnAuZFSBy8+PELnDlXdYbFXlxmhtEOrba/ShrK067RPEA/fxckxqKE xA7w== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=CyJUJaww; spf=pass (google.com: domain of fm-72506-202307260459395a287a0960ea006cc1-ll7ydt@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-72506-202307260459395a287a0960ea006cc1-Ll7yDt@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-227.siemens.flowmailer.net (mta-65-227.siemens.flowmailer.net. [185.136.65.227]) by gmr-mx.google.com with ESMTPS id g20-20020a056402321400b0051e6316130dsi798752eda.5.2023.07.25.21.59.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jul 2023 21:59:39 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-202307260459395a287a0960ea006cc1-ll7ydt@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) client-ip=185.136.65.227; Received: by mta-65-227.siemens.flowmailer.net with ESMTPSA id 202307260459395a287a0960ea006cc1 for ; Wed, 26 Jul 2023 06:59:39 +0200 X-Patchwork-Original-From: "'Felix Moessbauer' via isar-users" From: "MOESSBAUER, Felix" To: isar-users@googlegroups.com Cc: tobias.schaffner@siemens.com, Felix Moessbauer Subject: [PATCH 1/1] fix group splitting in user creation Date: Wed, 26 Jul 2023 04:59:20 +0000 Message-Id: <20230726045920.1542471-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-Original-Sender: felix.moessbauer@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=CyJUJaww; spf=pass (google.com: domain of fm-72506-202307260459395a287a0960ea006cc1-ll7ydt@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-72506-202307260459395a287a0960ea006cc1-Ll7yDt@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Felix Moessbauer Reply-To: Felix Moessbauer Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= There is a bug when converting the USER_[groups] configuration from the bitbake format (space separated) to the format useradd expects (comma separated). We cannot simply replace spaces with commas, as then multiple spaces in a row would create multiple commas. Instead, we need to split it first into the tokens and then join these tokens by comma. Signed-off-by: Felix Moessbauer --- meta/classes/image-account-extension.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/image-account-extension.bbclass b/meta/classes/image-account-extension.bbclass index e783c135..6f67f459 100644 --- a/meta/classes/image-account-extension.bbclass +++ b/meta/classes/image-account-extension.bbclass @@ -98,10 +98,10 @@ def image_create_users(d: "DataSmart") -> None: add_user_option("--comment", "comment") add_user_option("--shell", "shell") - groups = d.getVarFlag(user_entry, "groups") or "" + groups = (d.getVarFlag(user_entry, "groups") or "").split() if groups: args.append("--groups") - args.append(groups.replace(' ', ',')) + args.append(','.join(groups)) flags = (d.getVarFlag(user_entry, "flags") or "").split()