From patchwork Thu Jul 27 03:24:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "MOESSBAUER, Felix" X-Patchwork-Id: 2986 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 27 Jul 2023 05:24:44 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-lj1-f185.google.com (mail-lj1-f185.google.com [209.85.208.185]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 36R3Oi39025160 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Jul 2023 05:24:44 +0200 Received: by mail-lj1-f185.google.com with SMTP id 38308e7fff4ca-2b934194964sf3820621fa.1 for ; Wed, 26 Jul 2023 20:24:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690428278; cv=pass; d=google.com; s=arc-20160816; b=pPEYRVbtYgdg/Pf9FTdLRal6xkSgflSvWVHlGo7UQ+56D4Mbg0p47EmfoUN0AcE5fT apBcsEPDlL8Tm5/GX+ZzKqkDmLIIuNlBYKvmuU/EtTYrBVrLMxnxVLF80S/eZskNiO3n MvsQLnF4KnPbJnq/tQoMRbbW2SlK3LAagcwy/fMXVe5jRINW7x7RaJchYDeVGgCf5k6o vSx4+LSH3SZSYT948+suXEjpta6wIVvhHzUDLehqvPQukUGdDoc2Mw4Kg4o5FmSFk/u4 CtmI9EB1i+znqzYmGeHtAcRoFiC9SE69jrn4oXlGgHG6SKgO5u9citFuPfbkB5otA2WX mNJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=eCfYfCMHaVTtNK8Iy7EeI1RmpFDaiDa/7qG5H5uNl7k=; fh=JKqf9J7hlNlz24Nl/HODZL3o+A6ZAkdjinVSl7OE0r0=; b=OxQSiBIwqN0D84AmZfV5mj68BIiEu3NFOCJ/lKTTy2szTbydP8Tt7247Gak1ReaBdg NmIReTPEJCOfBE8FL+gs/mTETTiUsXay2ce5XT3BNnoYX4d0acx58Vz8KDhxZIMVComd stb933fGrCdaCRKkszuKTE9seXQ7Uxavyt3kdEFNbRGMmCooBJiLpm+fhXjmXmN1SqmG 06YyyB1rHSJizeKpDfTWT5kbxU+S75KEq9HK863ZNdbaOy65VDVmQaJJxz0PGW37CrxG Hg0RH8levDuSNAjKHVTyw44+Cb/neQi5bUjFoA8B2cyRNGxS9MVtYgiC0uajcUini6tS s74w== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=BzMQ7pye; spf=pass (google.com: domain of fm-72506-20230727032434988a094ff95ae4f76d-2tnfow@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-72506-20230727032434988a094ff95ae4f76d-2tNFow@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20221208; t=1690428278; x=1691033078; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=eCfYfCMHaVTtNK8Iy7EeI1RmpFDaiDa/7qG5H5uNl7k=; b=f07aA9b60bGEr34ZP0SII8A4ta/EtTrABnGuLzHarYKO08tDEW91N9NZGQaB1TaK2r KsRwdss6xmF10eoa8b4Ue1EGG15VyZSx2iwKGVQFRK15qZQjiRR+YhYZatDfXyf7bdM8 9N1kUcg2RUXmk28jNeY4R/J9PCBFjHhwZ0lWvXun/ojW3X6cughcfk3lL5Wg75BvxlvZ 5ZqD2MeJwWcy+I+9981hKc2gGtgH4LbIVedCHwy0gapJpV+9akKXC10M6pMpo8m1iWHJ mwWOLE/TqjZzw/UhXIsdXtu1tLGvRRviwoYuLkLSezbLqKsoeoJ8sd20CGMu+77Qs4YY ds5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690428278; x=1691033078; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eCfYfCMHaVTtNK8Iy7EeI1RmpFDaiDa/7qG5H5uNl7k=; b=Dmyq+Ig2d7ngvnjQyhtIgNJSUL1YvfJxSofsuacTlzYMROafKjRGlEN7QUY1QgOVKH LJb/2mjkUBGYoFxGtnkZwqVIR5ZVEaNQvSbzoQgAVmuaB1dQnGQjRBmAhqgT2bPALt/5 c3z3W80uoqE9AQA98c7xJNUu8Gv3B1zxqgj69pccjB5Mnb1zD2IjyqEwNGm9PW8VntZT naO/64KFbXSgRs5vtOZr0fbQYfGsDT2a1ODh4ILp1U1S49T35b7scsugQMJ1znxcy0M0 N3uD6fXrM2yJ2IkLt8vsUiS2k4HO1zLzIKjuAdMjbLEPPGIHtrRJi8NyWli2DSpMg3N1 SCGg== X-Gm-Message-State: ABy/qLZPJ6DWywGD9JGleLQhEFCFkJ3U1jk9hYNuQdljrDjTJgLbkBWS RAynWM+iKpgORRf5qLgKelw= X-Google-Smtp-Source: APBJJlFt5QVlDMZTvK9Kjn9RqWCpyFoAnhGDYgy9GoZt0a4nQqMgeV3W9epB/8ls4xACMI9eFvMPuQ== X-Received: by 2002:a2e:981a:0:b0:2b9:c5ca:a423 with SMTP id a26-20020a2e981a000000b002b9c5caa423mr8669ljj.18.1690428278139; Wed, 26 Jul 2023 20:24:38 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:c85:b0:2b9:57fb:fcf1 with SMTP id bz5-20020a05651c0c8500b002b957fbfcf1ls153648ljb.1.-pod-prod-05-eu; Wed, 26 Jul 2023 20:24:36 -0700 (PDT) X-Received: by 2002:ac2:58d4:0:b0:4fe:95e:159a with SMTP id u20-20020ac258d4000000b004fe095e159amr600186lfo.23.1690428276052; Wed, 26 Jul 2023 20:24:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690428276; cv=none; d=google.com; s=arc-20160816; b=eu1apGetWMXgDQgdU/4YhmBbYtGBP+zj+z1iL5wHXcAwOJGAIHJZt0roF+5m337jWQ QrOdhSw0dDbybXDg9VTd8f5lJwIXhKjlqEfG2KzlbGtkq2eeBYbrZAV6QB9/HqLIBDnC CczK8fNg/40IE2FELltMpsSWKRULCH8LVyB2JJ/6ODRgVVmzksSiiSMTXImrm5K7Qnu3 PorN/Epcvd4/IejPPQdoU91ex+Cag+Li45Lu0ejEDa2jD9+4wymKBNJ+CRQ4iYcgUr1O LL3gdJLikTENCBKr2JzNR+KjgCcatr0HC8oGo6317qEeuaRma7ssUhz6D/fbRjU+ShCs 3LLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=k6Gjyfky9UKQDT2df89/91SYNhpD81vRPvaHhPIXQF0=; fh=JKAk5g9OeEpZsHSr5t9bMJhmzqtLpjZpEcjmUiZCWCM=; b=oHj7PNb+Npq8cBLIlNHIou6hya3r4EUwaUCtx+TxSOzAgaI0SHAhRItFxCySHpOR1y PmHGr5rQZoYezys4IuL9jnSioko1YpzpgXd2D/qqc5ANcN72Rn6PJhllf0ZtvZpELCV8 x670hhwo1SSU5ZUchlLwmP6Q5+4DLYMwkjVwOMJL1AG32I1wEtpJLvexodtxOIB9Okdk T8lXY2QYlXQ7j6lVy7SLDZxfE6+wyyiRnhHmcogyu45DFr1AiaC5mDaWSVIc6EMBJSH6 mfiz2P/eW/aHB2E3szUzASJQEcnmPdMlntokYAfSD1371wy+0PVhfELcBmQTYEzgo4ar hSZg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=BzMQ7pye; spf=pass (google.com: domain of fm-72506-20230727032434988a094ff95ae4f76d-2tnfow@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-72506-20230727032434988a094ff95ae4f76d-2tNFow@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-225.siemens.flowmailer.net (mta-64-225.siemens.flowmailer.net. [185.136.64.225]) by gmr-mx.google.com with ESMTPS id j5-20020a056512344500b004fa16c65a05si31515lfr.6.2023.07.26.20.24.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jul 2023 20:24:35 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-20230727032434988a094ff95ae4f76d-2tnfow@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) client-ip=185.136.64.225; Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 20230727032434988a094ff95ae4f76d for ; Thu, 27 Jul 2023 05:24:35 +0200 X-Patchwork-Original-From: "'Felix Moessbauer' via isar-users" From: "MOESSBAUER, Felix" To: isar-users@googlegroups.com Cc: tobias.schaffner@siemens.com, Felix Moessbauer Subject: [PATCH v2 1/2] fix group splitting in user creation Date: Thu, 27 Jul 2023 03:24:14 +0000 Message-Id: <20230727032415.3366650-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-Original-Sender: felix.moessbauer@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=BzMQ7pye; spf=pass (google.com: domain of fm-72506-20230727032434988a094ff95ae4f76d-2tnfow@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-72506-20230727032434988a094ff95ae4f76d-2tNFow@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Felix Moessbauer Reply-To: Felix Moessbauer Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= There is a bug when converting the USER_[groups] configuration from the bitbake format (space separated) to the format useradd expects (comma separated). We cannot simply replace spaces with commas, as then multiple spaces in a row would create multiple commas. Instead, we need to split it first into the tokens and then join these tokens by comma. Signed-off-by: Felix Moessbauer Acked-by: Tobias Schaffner --- meta/classes/image-account-extension.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/image-account-extension.bbclass b/meta/classes/image-account-extension.bbclass index e783c135..6f67f459 100644 --- a/meta/classes/image-account-extension.bbclass +++ b/meta/classes/image-account-extension.bbclass @@ -98,10 +98,10 @@ def image_create_users(d: "DataSmart") -> None: add_user_option("--comment", "comment") add_user_option("--shell", "shell") - groups = d.getVarFlag(user_entry, "groups") or "" + groups = (d.getVarFlag(user_entry, "groups") or "").split() if groups: args.append("--groups") - args.append(groups.replace(' ', ',')) + args.append(','.join(groups)) flags = (d.getVarFlag(user_entry, "flags") or "").split()