From patchwork Thu Jan 18 10:31:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "MOESSBAUER, Felix" X-Patchwork-Id: 3306 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 18 Jan 2024 11:31:43 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-il1-f183.google.com (mail-il1-f183.google.com [209.85.166.183]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 40IAVQr3006637 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jan 2024 11:31:27 +0100 Received: by mail-il1-f183.google.com with SMTP id e9e14a558f8ab-360d8e54839sf51766885ab.2 for ; Thu, 18 Jan 2024 02:31:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705573881; cv=pass; d=google.com; s=arc-20160816; b=cb9Gc2aW7NNM9Q/sGcqXHoQb4ChGRmVSS81qgb/9mqHUhk8le0n7AB2grhJas7WmqA AMuT8dNVxJCusNseQGOJctTAx53r04oJn7rLyYtiImo45fXJI4ohnwMUnKIXmisrhMxL ZDUfCMFp/9IYABjJPzLNRa5No+AAlRaXLDCEn0c/ltVef1IKkwzTr1n4zW28ljtfM5g3 Kw4gUxMgFx02nh44xRUl/zCKEqe64yI9P2QDKqztQ2cY6VJG+le88YHy9uKcDo5EA4Gw DqDIEDyrvU/J/GNRHM3VRrDEAYKgbb+hN/p4zofKYWhOqY/3XbeJmbYRqdmmvW6mrMch DecA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=n36ahnERqWJNGXF7prdAaLoKkFsijBr39yZOHl4a9gQ=; fh=2vPEtVRFZgJExMSCfX53nKBFsjiPYp/60rbGy5S5Mwo=; b=t8V8sbLEr6K//0TsBBuo0kVrbXpRehxCuBDDyetsi5GQGtv3wpJXnhvsSQANeqQrgb F4jGZnaW1tHoa3lruTYXPPhlcM5i1CntOhfsjxvUEJeKB2NH/Ei1wjpQvATd2iQAT6hc 4jk6MyiVIFl/cTF7NJvSUOeotb42SySnk1JJIQDF538q+Gj9GiP2DRNKFH/v8MHwH9HI jw/e9OR9sN0AJJ4MCMS56pBlj5+W3kY7Mpr0LTfGoJLb6Xy2Z/l5okCngKkdbD3hOVoN j4r3iF0eZ9+euaHSOKXYYib9I38hgSPSIlIJ8QdgQLasE9DtFnEwZQm+x3CrdtAZ6+Dc F9ug== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=UY0ooAoD; spf=pass (google.com: domain of fm-1321639-20240118103118177c89a60598eeb2f0-uya5vx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1321639-20240118103118177c89a60598eeb2f0-UyA5vx@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1705573881; x=1706178681; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=n36ahnERqWJNGXF7prdAaLoKkFsijBr39yZOHl4a9gQ=; b=SJu5CwMp+jLllJTBOnIsx1fh0AE+1hS+TSZoQrrh1BAYASy9vQwcKZPPiVCKLyHZ0n WfdurCa0fee6NU/IVm4yC/KIqTA5Fm2kCgBVDhF5qZr/oGEoG++yXm7Cg3INZYHr+VZq EnPFlcDqNti0qsw7izvHy7EyNr334SewE6F8dejmlbY0u7m3m5sdnXGcVbpF3Xr5sZ6F IJxB1boGifNU8uXgH1J19zxqHQddagjhwJlK515YeJWP8RNVz1Urfxvs1gW03kUagGI5 w9rL7GymPMkH1bkB2WuU9qmKSCSISuaUH8qTCXJ7Et8X4SoOO6cIQrSu7ltFZG1iyQQe C2Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705573881; x=1706178681; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n36ahnERqWJNGXF7prdAaLoKkFsijBr39yZOHl4a9gQ=; b=TcD3ZpPm4I36F8/SNPFBVYkxkGmq47ti8yesmVe5yPZlx303Zg77dYxZ7z19q4x56k olBhko16M7nUy/BfupAGxa3rfJ9DnIih16dIOPCDCrTsBllPwyyHwyTiEnk2YRNf/tYF bR9wNIggatvFfSa5gI/HSok5psYpjgG8JIlbZ8865g6F0L1dCIZj3TH5JaPdeDM01Ezt fdd85el4xOyavlY68dasBIDs/X0Gc/6Y31Z8SVjRKnyuyNKEgtRO20LtweFtLw/Z78sM N1n1YZkr1JKC+LIcKLB+cOjnJwKzrfk0l5mU83HYYmTdvosBZIsSHCr5VGUly54WzD39 zmnQ== X-Gm-Message-State: AOJu0YytEjJyaD42Cjoby5UilJkIWzTkgKjt3I/qWy+Ax91IkU+7ZWQq sgod3+47OyrAhn2W3RaJVkCLjm1aMOm71EQMyRrEJ9pl+9CsZpwy X-Google-Smtp-Source: AGHT+IFTGr9X9jVbDT/6WTyOIiNb2luw3+tf1QGJwFDSq0+Nm6jmRn68QsSvXtlYvCWkP0xxG3AiBQ== X-Received: by 2002:a92:c844:0:b0:35d:59a2:bc4 with SMTP id b4-20020a92c844000000b0035d59a20bc4mr699392ilq.90.1705573881322; Thu, 18 Jan 2024 02:31:21 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a92:6f0c:0:b0:361:a069:dba5 with SMTP id k12-20020a926f0c000000b00361a069dba5ls146832ilc.2.-pod-prod-03-us; Thu, 18 Jan 2024 02:31:20 -0800 (PST) X-Received: by 2002:a92:cb8e:0:b0:361:8a14:9607 with SMTP id z14-20020a92cb8e000000b003618a149607mr617495ilo.73.1705573880515; Thu, 18 Jan 2024 02:31:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705573880; cv=none; d=google.com; s=arc-20160816; b=YqtjXMkrBYP+EVkomYMyEQh0XaNfPwmWkBHdRdPTuN5uI+UyAWCljUklj7fI3ZLTAT 1rYjDLa09Eo9aJUHS30dDRmtCz74eApIE9QGhhwYxhO4MOaASW6I+d8vGiEIJPs6wMwQ AHyI3z6Abt2SyhVv8iOHD0rzWvhC+kq46NLCieKoL6TYzYzCBGZ9a5A5sFryAdXMnSVA h2FpxWlIa7jw29EK7j1jm78FdgFAwJ+fhDtd+v/pzbDob6d25FTvs9Kk5gmreQMoA6Ov 9cDCcXkwrjpLN0pMaLrrrZ3k/j4lVgAyi5t4XQIPjewgW1d7Zx6t9YcY7tSRZBVqPjHL XuaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=mkJBUpsBWrUNlrAT4xJzYW4pJRN5XmyPdzVUx/l8HdA=; fh=2vPEtVRFZgJExMSCfX53nKBFsjiPYp/60rbGy5S5Mwo=; b=QQSf5+0ejaLpQPzBtlnlwT0pXGzJ4aeQYRx6VMDJd4FkPlobH6KSTtbwhoFFWxi27n Zt9R6neI06K02hQiRC1BmCuUrfK4ozKq4DsUsZu9UwcCMnTqEayRdCG+VRf/LvEFQ0vK Nk3rsrBHUuhhDxOqynEluHRg4BaBA7cqD2rWvb8sf5bMAsT5wYz7RmlBvaEnxiKPje9b LeiCBRho1OisntrA5pg5GtKYjH9JuoVNOAY+fk0HU63iT1YzOzwJRaTC7bDGalYY6NEU WgHESCflgiihbHK11SFiUWwXPjHbXQ95i2vzI3qdQFZi3W4NcofAmEVD7PpQzoP63sHV AEDg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=UY0ooAoD; spf=pass (google.com: domain of fm-1321639-20240118103118177c89a60598eeb2f0-uya5vx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1321639-20240118103118177c89a60598eeb2f0-UyA5vx@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-225.siemens.flowmailer.net (mta-65-225.siemens.flowmailer.net. [185.136.65.225]) by gmr-mx.google.com with ESMTPS id n8-20020a056e0208e800b00361928c606dsi306496ilt.2.2024.01.18.02.31.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2024 02:31:20 -0800 (PST) Received-SPF: pass (google.com: domain of fm-1321639-20240118103118177c89a60598eeb2f0-uya5vx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) client-ip=185.136.65.225; Received: by mta-65-225.siemens.flowmailer.net with ESMTPSA id 20240118103118177c89a60598eeb2f0 for ; Thu, 18 Jan 2024 11:31:18 +0100 X-Patchwork-Original-From: "'Felix Moessbauer' via isar-users" From: "MOESSBAUER, Felix" To: isar-users@googlegroups.com Cc: jan.kiszka@siemens.com, Felix Moessbauer Subject: [PATCH 1/1] auto disable cross for kmod build against distro kernels Date: Thu, 18 Jan 2024 11:31:02 +0100 Message-Id: <20240118103102.658035-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1321639:519-21489:flowmailer X-Original-Sender: felix.moessbauer@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=UY0ooAoD; spf=pass (google.com: domain of fm-1321639-20240118103118177c89a60598eeb2f0-uya5vx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1321639-20240118103118177c89a60598eeb2f0-UyA5vx@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Felix Moessbauer Reply-To: Felix Moessbauer Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,SPF_PASS, T_SPF_HELO_TEMPERROR autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= Cross compiling kernel modules for distro kernels is not supported in debian. To simplify downstream kernel module builds, we automatically turn off cross compilation for a user-provided module when building it for a distro kernel. This patch further replaces the hard-coded list of distro kernels with the DISTRO_KERNELS variable to avoid code duplication. Signed-off-by: Felix Moessbauer --- RECIPE-API-CHANGELOG.md | 6 +++++ .../example-module/example-module.bb | 22 ------------------- meta/recipes-kernel/linux-module/module.inc | 10 +++++++++ 3 files changed, 16 insertions(+), 22 deletions(-) diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md index bea12871..b1e5a5ab 100644 --- a/RECIPE-API-CHANGELOG.md +++ b/RECIPE-API-CHANGELOG.md @@ -566,3 +566,9 @@ supported, but a warning is issued when it is used. Future versions will drop When building a custom kernel module, the `KBuild` file might be located in a subdirectory. To support this use-case, set `MODULE_DIR=$(PWD)/subdir` in the module build recipe. + +### Automatically disable cross for kmod builds against distro kernels + +Cross compiling kernel modules for distro kernels is not supported in debian. +To simplify downstream kernel module builds, we automatically turn of cross +compilation for a user-provided module when building it for a distro kernel. diff --git a/meta-isar/recipes-kernel/example-module/example-module.bb b/meta-isar/recipes-kernel/example-module/example-module.bb index 5ebed102..22f3cc47 100644 --- a/meta-isar/recipes-kernel/example-module/example-module.bb +++ b/meta-isar/recipes-kernel/example-module/example-module.bb @@ -5,28 +5,6 @@ # # SPDX-License-Identifier: MIT -# Cross-compilation is not supported for the default Debian kernels. -# For example, package with kernel headers for ARM: -# linux-headers-armmp -# has hard dependencies from linux-compiler-gcc-4.8-arm, what -# conflicts with the host binaries. -python() { - if d.getVar('KERNEL_NAME') in [ - 'armmp', - 'arm64', - 'rpi-rpfv', - 'amd64', - '686-pae', - '4kc-malta', - 'riscv64', - 'kernel', - 'kernel7', - 'kernel7l', - 'kernel8', - ]: - d.setVar('ISAR_CROSS_COMPILE', '0') -} - require recipes-kernel/linux-module/module.inc SRC_URI += "file://src" diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc index 269da6ae..eddbf177 100644 --- a/meta/recipes-kernel/linux-module/module.inc +++ b/meta/recipes-kernel/linux-module/module.inc @@ -28,6 +28,16 @@ SRC_URI += "file://debian/" AUTOLOAD ?= "" +# Cross-compilation is not supported for the default Debian kernels. +# For example, package with kernel headers for ARM: +# linux-headers-armmp +# has hard dependencies from linux-compiler-gcc-4.8-arm, what +# conflicts with the host binaries. +python() { + if d.getVar('KERNEL_NAME') in d.getVar('DISTRO_KERNELS').split(): + d.setVar('ISAR_CROSS_COMPILE', '0') +} + inherit dpkg TEMPLATE_FILES = "debian/control.tmpl \