From patchwork Tue Apr 2 17:28:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kergoth@gmail.com X-Patchwork-Id: 3465 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 02 Apr 2024 19:29:08 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qv1-f61.google.com (mail-qv1-f61.google.com [209.85.219.61]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 432HT7Dt019590 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 2 Apr 2024 19:29:07 +0200 Received: by mail-qv1-f61.google.com with SMTP id 6a1803df08f44-69901bb1743sf29925496d6.3 for ; Tue, 02 Apr 2024 10:29:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712078941; cv=pass; d=google.com; s=arc-20160816; b=PtLUp0Rqphi8NrTmok9slWl+G1FU+Dc4hw7nEREIM5NUGpx68XcOkhzz5fKz7PQZs8 uXNv06XQVEwfKbeLsVoPM8am5lbit7TwVaWez05mweCB8VrWqbSU0SahkA8tCUnbZ1AH kNIRrC8QU0n+oKHTz8GLL5mYq/GUezBF8oql0st3+pNvLUUW0xef2ku2gWbwh/02qSWP ZLXe7/wNfW9yylIp9DxAhUmmWj1i6gya5nONduN7aDqOiwRou2YW6IVjTHOnwj3o72ue BC+U5tmZbBCcNDCszv/r1bX5Z1nE7vVJVuxjEwvHH8OyGdQyb96FXIio59MfRHEZi9hZ Aidg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature :dkim-signature; bh=JsFzO3ah66QDaD96Zxh03HCWdMtYPBQ4HieNtrmrHsA=; fh=pIVY3oTIs+lZqZC5NBGKOWYcgIGpZM8hOQAj0E6kDF4=; b=KElVkGToPt1tx4bxSHrs1Ru53+XfuhclEozFEizMsp6OR5rylVlsegfsCj0EQeV0N7 Jd7T3qYIGezMzpRoJxJ/FyY0zfBV13P6p2LnpQBSnBZ7uAeFIqBUpkqdg2Hqpn1NlMC3 ix7DJy5gItSZBmePLgom4iMf8NiEjl1e0Em6poRTarJPJKdlSFsEjjalboymM0bDHbtI JEF83EDEUO+2ozOYw/58lQMtrY2oKzDk1G23fFLk+vc3jDAs2SaUtru3j7GMvrp4tKdZ Hfpy3f9bcyXYy6f1YpGO88MgZpMZTYiyyGeQgSaAbZSY/3PDnQ2XBpDx5Kv+rcRU9ivY NKrw==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jw+Zk5wi; spf=pass (google.com: domain of kergoth@gmail.com designates 2607:f8b0:4864:20::1032 as permitted sender) smtp.mailfrom=kergoth@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1712078941; x=1712683741; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=JsFzO3ah66QDaD96Zxh03HCWdMtYPBQ4HieNtrmrHsA=; b=mTTJ05/ZggVRc0LoFLdg6pCTEc3F8zz+taoWSVwsxZ84PgkesknKYWhJJFqwdq3/aD XFK88ynshpwj0drLaBkd7bhIVs4qFam1s3LF/GkUfPMO5UYLK+5UAbp+sZbHwYfzYysL 72wMLZLI4zGpc/uinxCYZEE/nZRcDP1kvYU9k/o7CqaIy9IZYMfqoWbQ7xTfcumib8RR KqFufDop06QO/hJGSNKDQvR8bL5SV4ZQvwTb8rC0/egrOk1UTnfMxBQSZmAPjJmLBhRy AE35ZbLSbhITMg+ZPWmT9QnreoFI+qqRUxf9+GjWZRxHQ+rJFUQredOCAlPrI2oprFon Zwew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712078941; x=1712683741; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=JsFzO3ah66QDaD96Zxh03HCWdMtYPBQ4HieNtrmrHsA=; b=UJ9cBTHzCClvCuJFPTR2soIXYFTJYaDryAziGxfP2r9cDbdaDiHD+29yv5av3czhBD loLI6JdhZfypHP2PUL2e7XTbbx39jHkY/urEfhm9B+ir2c5vR/vvSWRtUqM9yZbkol+o ZlrcxgjniKUv9ApEsgvcURNH4gVmalHR6xmTkHgUmVXB4lneg8qLJNMa9FY5iiVtuLaQ b2W080StXm4auF98TTY2W+FDjLiPgjlwWhVAy/UeyegexNLJWqbXweF5DS22JccVIipV ezNnR59VVmbJ55zV4MexusHgvylAc7MC+TcXLw9704N9bzTF9qUy538vwC8R+EeCslIF ZFeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712078941; x=1712683741; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=JsFzO3ah66QDaD96Zxh03HCWdMtYPBQ4HieNtrmrHsA=; b=UGGJfbW829ileuML9GzIRlaFPv4/l5QndN1Jpy2s11qT0lk2DUc3QseNaTL/f/vlkb qGcAwkbk7X3t2gejsOyuQLeXlWyrFoXSVjsCnyN8qGz/7ZO6Ib2lEBXZLv7UXtpfsXtG NesHJ0mBubsddceV4NK+M/c1LEseXQs2Ll2Nvg5rg00sBN6kJgZ8XhQcYrcdG4nFXKX8 BS4K+xD7l9jUoGuTSGRq1sRx883k8pCly55O+g033hF8GtvGL7HsnxSAommY68vMs0YF SSnRaVtHTJO8qIK0ci9YTh6B0o9g9AOM4H+eObUi2HU+B/NoD3t9vv/xhh1LVYI4PZ7F 6w2Q== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVM1fNKiaNZbcqs7VwfY6EtfE4OtA3Y5priIGlmTUTHc6sOWWNRlQNm/8PEVwwoLH8dUlJvkjfUN+gdMA776vx1/PVl2Y4= X-Gm-Message-State: AOJu0Yw7yXim3sxsHaVHkLMAwyRk83cMuX4R0bZd7SIEKoFRnpfZDvez wqbyzfgHgN1unQ023MEVgYFMKiEPs2M7+UDC5NzeYJq6dnmOmVgn9rI= X-Google-Smtp-Source: AGHT+IEW/faI05U1LqaEDXqZ6+6+cbwl4t+83vGF2fCDRZL3+F2LQRvad0wEAcftuhwMYFx3TM2O5w== X-Received: by 2002:ad4:4e11:0:b0:699:2212:3b33 with SMTP id dl17-20020ad44e11000000b0069922123b33mr331127qvb.19.1712078941498; Tue, 02 Apr 2024 10:29:01 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ad4:4ea9:0:b0:698:7a54:d873 with SMTP id ed9-20020ad44ea9000000b006987a54d873ls1036835qvb.2.-pod-prod-03-us; Tue, 02 Apr 2024 10:29:00 -0700 (PDT) X-Received: by 2002:a05:6122:2003:b0:4b6:d63c:ca8f with SMTP id l3-20020a056122200300b004b6d63cca8fmr377053vkd.16.1712078940163; Tue, 02 Apr 2024 10:29:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712078940; cv=none; d=google.com; s=arc-20160816; b=TBAVjKfcck+9k4DEAYQQdTxsS4+Q5kgDGZVZyE5/JPdsliW+PInjzfCItfw2bBp3Xr PzqPpuZRewUirZrVT5iN2TNDVqcmWVdVzWfJ0DPyp/gD5Kk80a7DFz4ttCkq+v3Pkao1 mJKHavG6Wquldds2eucjNMyYiF7/glEJYzOrFnXqUPUb6UTqKHxj7eLLK6W3kIQGOp9r xs6MIpyHKGCMN5dDYWUhybtGkzuQxhqA+gXzWBnuhZIuYmr+OLxaepdjGrzsH54Mvby2 tFA44d3G8hDPjZzp7yYnW64IomRS2TiL/CeVK3A3UMR4ehih6pYJdXI1aBFJG3jNvjwv 7VCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=PsoYVkopixoTWu0I0XvQ3YIN+luvBXXfRju/3GaGyGk=; fh=oQsVBfLFKOCDpQI4v78XDUCp+c0vYPEMW+xCOFIgP4c=; b=tq1yFI8DA+ao6R03DhoV6/am9IFwN7eMFYtoR85VGXHEUxevpNhqFU5Yt8b5Hr9/Gi EgI1sgeA8Tu3XgMMRoJ/JyCQa6bduXGuzo1sMGclqFP4uTKIQaZ//g1XNv+blMgfRbsP jURGv/JMHABhpoWxJ9sfaqHso+w9RFdmIk+0Q2LL1HA9D1D6gDVX3l5OOXIT+OFVbi5f lSiMclrqdkO4/4E2JlrQ9wKdCyUkVwmijGKOGihqhgLPxh/EjchxGFygHFhYnqhy1ddp uUxYTrH78mehOVmcvuGbUwdfP2Ap68UWB2HpkuE/hBeaUKakkJO3qfmy/b6C/7OFRGhT 4kpA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jw+Zk5wi; spf=pass (google.com: domain of kergoth@gmail.com designates 2607:f8b0:4864:20::1032 as permitted sender) smtp.mailfrom=kergoth@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com. [2607:f8b0:4864:20::1032]) by gmr-mx.google.com with ESMTPS id 33-20020a0561220a2100b004d3c4a37c63si564643vkn.2.2024.04.02.10.29.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Apr 2024 10:29:00 -0700 (PDT) Received-SPF: pass (google.com: domain of kergoth@gmail.com designates 2607:f8b0:4864:20::1032 as permitted sender) client-ip=2607:f8b0:4864:20::1032; Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-29b7164eef6so4468667a91.2 for ; Tue, 02 Apr 2024 10:29:00 -0700 (PDT) X-Received: by 2002:a17:90b:18e:b0:2a0:2a36:91a0 with SMTP id t14-20020a17090b018e00b002a02a3691a0mr400677pjs.18.1712078939376; Tue, 02 Apr 2024 10:28:59 -0700 (PDT) Received: from dc4670097af0.alm.mentorg.com (nat-mam.mentorg.com. [139.181.8.34]) by smtp.googlemail.com with ESMTPSA id bt19-20020a17090af01300b002a2313f62dcsm66705pjb.0.2024.04.02.10.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:28:59 -0700 (PDT) From: kergoth@gmail.com To: isar-users@googlegroups.com Cc: Christopher Larson , Christopher Larson Subject: [PATCH 3/9] isar-sstate: lint: check for absolute paths in SRC_URI Date: Tue, 2 Apr 2024 17:28:07 +0000 Message-Id: <20240402172813.418770-4-chris.larson@siemens.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240402172813.418770-1-chris.larson@siemens.com> References: <20240402172813.418770-1-chris.larson@siemens.com> MIME-Version: 1.0 X-Original-Sender: kergoth@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jw+Zk5wi; spf=pass (google.com: domain of kergoth@gmail.com designates 2607:f8b0:4864:20::1032 as permitted sender) smtp.mailfrom=kergoth@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Christopher Larson In addition to the current checks for variables starting with an absolute path, particularly those within the build or sources directories, we should also check for absolute paths in SRC_URI file entries. Signed-off-by: Christopher Larson Acked-by: Felix Moessbauer --- scripts/isar-sstate | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/scripts/isar-sstate b/scripts/isar-sstate index c14c2843..9b20cb8e 100755 --- a/scripts/isar-sstate +++ b/scripts/isar-sstate @@ -839,6 +839,23 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, pedantic, ** continue # remove leading whitespaces possibly added by appending val = val.lstrip() + if name == 'SRC_URI': + src_uri = val.split() + for entry in src_uri: + if entry.startswith('file:///'): + entry_path = entry[7:] + if entry_path.startswith(build_dir): + pn_issues.append(f'\033[0;31m-> path in build-dir: SRC_URI entry "{entry}"\033[0m') + hits_builddir += 1 + elif entry_path.startswith(sources_dir): + pn_issues.append(f'\033[0;31m-> path in sources-dir: SRC_URI entry "{entry}"\033[0m') + hits_srcdir += 1 + else: + hits_other += 1 + if verbose: + pn_issues.append(f'\033[0;34m-> other absolute path: SRC_URI entry "{entry}"\033[0m') + continue + if not val[0] == '/': continue if val.startswith(build_dir):