From patchwork Fri Apr 5 16:31:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Larson, Chris" X-Patchwork-Id: 3479 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 05 Apr 2024 18:32:34 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-pj1-f63.google.com (mail-pj1-f63.google.com [209.85.216.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 435GWW7N003051 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 5 Apr 2024 18:32:33 +0200 Received: by mail-pj1-f63.google.com with SMTP id 98e67ed59e1d1-2a28775dcaesf606372a91.0 for ; Fri, 05 Apr 2024 09:32:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712334746; cv=pass; d=google.com; s=arc-20160816; b=WbvQJVqLOAQLLlJ6eIfqe/xAHVXrZ/l6WBt/fEIw90NmcNMi4bGgX4kp0EDX5yzo+2 pYCReJ3zX7BOq07VN1XUSGI3BmpT3m6l+kVUaH+m+u17vtPXXY5POIVVe14NL9Kwp+q6 YbPyt13DwO2Wu+mjh9k1HEhkBs5Kij8+N6sUt9bnkqwhknRnyIuthjmz/4uajtTiVtSo zt1mVOwWGM+3rFA377KBHf1Pf0Cy0srAMn55iTV4UyvLA6mzx8hl7WtX7bQEdWdiiqWt KVozU+fEV9wzX5GOAY3zxB0ZEWw94Fz+KRCpWt8EqtTpEO/8YEFh2bygkJHa6gHFLcxh EehA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vvg4GOOg+SrsDJriWb5nnAjVFZHfZU0RW1HIFertsDQ=; fh=OscIgrnFN3uyhGM8xb9uzkfcx2P+vC6Ok/ZtnDLeb4k=; b=MmKFaeMuR0Zo6C1lbsSBcBYq3t/oxVl45Y4uwsJRNRt/Oc0TyjfrVa/8ar4YbFeorv xuBJmywxOLwaCZcVrj8inE8oiSXYZRb/Rp+O3t8QRXNx2MwybQ3V9MFUIYnq22/12k59 0JvG6TWFXzfNmHuE5848OVgHz7irNvRK5138RElbxh8G04kILJ9k+HfOvseKc7tjM27p 9w6efqXbmT1mydj9miCWvTV/f3x4Q+F3xaVbyJLjw9wfkZ9jdmw1+f4x+n3LEyFQtErU ZKLQ0oUEEN6P5dddKb+wXuB2H8iDaZD7X+Nqh1LqYl7szIdoiMQ5lg+sM5C7mY++3nAF xGqw==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Ua8+Xvwj; spf=pass (google.com: domain of fm-1325773-2024040516322269c98b7391ab0c50e2-qpgcoh@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-1325773-2024040516322269c98b7391ab0c50e2-QpGcoh@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1712334746; x=1712939546; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=vvg4GOOg+SrsDJriWb5nnAjVFZHfZU0RW1HIFertsDQ=; b=PUdPtE6yo2jcfMzH9Jhe0oTeoWPg7+DR7Ir7i2vqwX17h96ykHsM7NdCa1Mj2JeQTy AvisVReEtbndQPDkIJbAMtHjlw+VBYH+TOvYpwkKCXOCUsB3+iVxtyz/Y0AwbTa5ftrd ASrFRSogzv8yzgl8E/OT2B4IG7jhSzjp8QFFyq7Gb3NXP64PFNTnOKMi6k9NbLaqSkNl cZsN8NQwj6TdIk5RGG6xVKHeHAfNGsKm/GWUnPckzfKSV02VkUVjJOYQ4ZCJ+WYzlMD1 r8pGfBgUiGqV1byGOoe0xIqOxLCPyo8hiL5hJkEDk9Yb8XDzMSCgyjJ+7efZBdnLOBLi ZiHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712334746; x=1712939546; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vvg4GOOg+SrsDJriWb5nnAjVFZHfZU0RW1HIFertsDQ=; b=kXLPPmgAiJplNwhvIBUJHpzZQES1TwtFasnQd3qJ629pJpAvg5s9vtawhar6CxtjFh l32n3hpziEJ0PM/OrXfLl8Wh1HnvT8bqQ4TsnPF/T36wi5Qg3Rhm6x9xz9b9qiSiUs3l FttDD6X0wVl7iv/7bkCEXhtOInFcDjlmscIzJOQs3n9PuRmmiJqnv6pBFJ733xvNzzru SH587bLtlshdIjxDS3vrjVnX/n2s/MOuEQeuK0fEL+mY2B8sIRae17zWuWpv8InzWv9n +K/ksrbgtHktFvwbGBQj6jhVYJ1PcEnpWVnYSQLAQ6Bc71yCJDeHEqGp2+Dp/3Kl47sg U2vA== X-Forwarded-Encrypted: i=2; AJvYcCVS67lf6j66SkYGIqpU8XIzWw+bhxyOozH8kCgdSK92G/nGPA/3rdBQ+XOwiX69zY67BuSb53LbbtV7epoWxxIOcL7Q0Qk= X-Gm-Message-State: AOJu0YzB3LK5Wx7mDLlaQB5qr0tgF9gMNk3qES24Hp3RF0X4RX/z1LRM +sh1uNVCuer9X9t5pGkBJqHH0gmQIS2aml83KdAU6P+G+zq+QuAP X-Google-Smtp-Source: AGHT+IHjViRugwJjdRP9OIWmxYAf0eaW3yQNnWI5eC8bBamEGHneZMqxcla7eBrGHCvDYnOl6FGmZA== X-Received: by 2002:a17:90a:d814:b0:2a3:cf8:44ad with SMTP id a20-20020a17090ad81400b002a30cf844admr1872573pjv.1.1712334746222; Fri, 05 Apr 2024 09:32:26 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:90a:c20e:b0:2a2:9d0f:c728 with SMTP id e14-20020a17090ac20e00b002a29d0fc728ls1362027pjt.2.-pod-prod-06-us; Fri, 05 Apr 2024 09:32:25 -0700 (PDT) X-Received: by 2002:a05:6a21:360a:b0:1a7:34c5:f8d with SMTP id yg10-20020a056a21360a00b001a734c50f8dmr1803782pzb.38.1712334744761; Fri, 05 Apr 2024 09:32:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712334744; cv=none; d=google.com; s=arc-20160816; b=UFwElGBkpJxnonF3mNxxTBvFSWVOb0Fq+MUetzqrSWsGBfzY63B8zxP4Rz00HkFk3c sfbCeOBXYUaaoGsrdvWBr+0tn5Osy8BOOoI3YzQlR/6xyDShQdr4In/0XQtpWUXB/TKL bJ81+NzK9hlSJ2mzpl2tB8vHvSNFeyuKirxJ4FxbXZQ8PrJa6oG+jkumXrgjzOx1DJuj zEpYNLUtPwWtSmjo2u+pG3wt3K0+kUZAN3ii4K7kV7dqaD0SfnH5tYCjzPvwWp+m46Y7 1/Oi1q84uMo9ZToElS0ebBYr/iQIBcdVjqOW2L7bdWj4krmb2AWzfoLpJ7LUn5R37qWO R0BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=rGdg6ldi2thVX4/MpwPbnhgb9DhjmdHWXNiwtkcSwbs=; fh=3bh9z2BWAzGAc1byRhMi0K+arMZmX5BQHE0sOxINdyU=; b=mMbp9hkJa5W7SssNCyf37Dz4ZRuitAH6aiu/EZStBfRK/g4Uhael90z7nojSUSPFOK ohaZfa/ftKzrCp514B/1lubX4y+t82KunyTwCOEANjdBRx1yHnMReQyXovH1PoUck1WJ ohtXP9UjTWgozpmYdI2iNEKNf7D+LO2+eOmFwJ8yWg5AZLsVJ1IhpCdY+bE/6VuU0VLb Zzau9A00Pa5pfphY2fIUUinkWuyoMZXjOEb54DebTnFjAFQtpZG26e6EWxTNFRUjx6Oe Wiv6WJMZ9rQoM7Y+6v2cpWOFK+E3cKhN3Xf6M/z2uz700wULisVDvo18Ab6BumfNmGnw kKQQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Ua8+Xvwj; spf=pass (google.com: domain of fm-1325773-2024040516322269c98b7391ab0c50e2-qpgcoh@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-1325773-2024040516322269c98b7391ab0c50e2-QpGcoh@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-228.siemens.flowmailer.net (mta-64-228.siemens.flowmailer.net. [185.136.64.228]) by gmr-mx.google.com with ESMTPS id c4-20020a63d504000000b005f0a5113629si153309pgg.3.2024.04.05.09.32.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2024 09:32:24 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1325773-2024040516322269c98b7391ab0c50e2-qpgcoh@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) client-ip=185.136.64.228; Received: by mta-64-228.siemens.flowmailer.net with ESMTPSA id 2024040516322269c98b7391ab0c50e2 for ; Fri, 05 Apr 2024 18:32:22 +0200 X-Patchwork-Original-From: "chris.larson via isar-users" From: "Larson, Chris" To: isar-users@googlegroups.com Cc: Christopher Larson Subject: [PATCH 2/9] isar-ci-ssh-setup: avoid abs path in signatures Date: Fri, 5 Apr 2024 16:31:28 +0000 Message-Id: <20240405163135.2987489-3-chris.larson@siemens.com> In-Reply-To: <20240405163135.2987489-1-chris.larson@siemens.com> References: <20240405163135.2987489-1-chris.larson@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1325773:519-21489:flowmailer X-Original-Sender: chris.larson@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Ua8+Xvwj; spf=pass (google.com: domain of fm-1325773-2024040516322269c98b7391ab0c50e2-qpgcoh@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-1325773-2024040516322269c98b7391ab0c50e2-QpGcoh@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: chris.larson@siemens.com Reply-To: chris.larson@siemens.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Christopher Larson TESTSUITEDIR is a full absolute path to the testsuite directory in isar, as set in the environment by the build setup scripts. This is referenced in the install task, which prevents shared state reuse for this package. While this is predominently used in CI, it's still a good idea to avoid absolute paths in signatures, so we can reuse shared state for this package in other contexts. Rather than excluding the TESTSUITEDIR from signatures entirely with vardepsexclude, we can retain some information about the path by using os.path.relpath to make it relative to the top directory of the build. This is the same approach used by isar-bootstrap for the keys, and the vardepvalue approach is also used elsewhere for layer paths. Submitted at https://groups.google.com/g/isar-users/c/2NB-PXyswq8/m/oOIB_KxTAQAJ. Signed-off-by: Christopher Larson --- .../recipes-ci/isar-ci-ssh-setup/isar-ci-ssh-setup_0.1.bb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta-test/recipes-ci/isar-ci-ssh-setup/isar-ci-ssh-setup_0.1.bb b/meta-test/recipes-ci/isar-ci-ssh-setup/isar-ci-ssh-setup_0.1.bb index 4693f647..89100444 100644 --- a/meta-test/recipes-ci/isar-ci-ssh-setup/isar-ci-ssh-setup_0.1.bb +++ b/meta-test/recipes-ci/isar-ci-ssh-setup/isar-ci-ssh-setup_0.1.bb @@ -13,6 +13,9 @@ DEBIAN_DEPENDS = "adduser, apt (>= 0.4.2), network-manager, sshd-regen-keys" inherit dpkg-raw +# Avoid absolute paths in signatures which prevent shared state reuse +TESTSUITEDIR[vardepvalue] = "${@os.path.relpath('${TESTSUITEDIR}', '${TOPDIR}')}" + do_install() { # Install authorized SSH keys install -v -d ${D}/var/lib/isar-ci/.ssh/