From patchwork Fri Apr 5 16:31:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Larson, Chris" X-Patchwork-Id: 3478 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 05 Apr 2024 18:32:33 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-pg1-f185.google.com (mail-pg1-f185.google.com [209.85.215.185]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 435GWVl6003039 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 5 Apr 2024 18:32:32 +0200 Received: by mail-pg1-f185.google.com with SMTP id 41be03b00d2f7-5d8dd488e09sf1928907a12.2 for ; Fri, 05 Apr 2024 09:32:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712334746; cv=pass; d=google.com; s=arc-20160816; b=uJWsf4HJrALPGMhNM2BQ/q1i3JX3t8RLX7Eto2daihDqjhiDBYnsYnx5/pCD19jntL hgAmituXbCKLpyJxfTa8FIS9XI+lh5uuyD7Zg8HFr/KckojQnHC69icKiJnNjYI8D2nL +ebaLv/VO6g4C5i9CHBaFmiKMec+ee9ByLxaADq8FlCLOTJ+Qv4uIISfQmAEE3V/A/mY 6gwOBL0+trh47U/cDVQOSUwXcFnQm6GwVOxBbiQ2N2U+T3LySYXTYuXClG8zt1Fpff3S 8S4bcRczqkT0fCZoB6w+Vguke5GdhKffFE6sLZeoADS9cZAvCfdyi1QC/aTDV1BgEkDA XBMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NLSZU/6eK2V/eHLzkcIQjQ0NcjzG1uvTlCe1FSrYTIA=; fh=7Sc8fkyTb/gwcadI1ArxUwT1H28U3p3jx6tpAGZClHI=; b=m01TnCUVpY/ULNAvHFI1xDiw9sV8QvtQe8iPteBun8PCFH7wY6SY7zHxX3m6htIMSB GpaOrMuxP6J0L+odvNN5NwUfP9LgzVfN0EGwtbODCGHj+jArCyWB/CDtYXyg3vK1k/dZ pQ32gh0KWFbPjZ0sGaMpbPl8Uz9jALaLVPeGyVNe6GJBk/2ZlFh+EHBz6m9Iel3Fa0Bg C8wr8T9Eh9YXUMNjRhyaUnR7UQb3ghprJQMxzbmCy2Lfzf7a78REHnTRj2wHGj1YubhM CPeIE1PjaJCzSztTxD9nYZDby3Sn+UxN6+DStXshEP1VnWBsVfuOUm+8if8b/r+0m16T HfKw==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=NHniP2JY; spf=pass (google.com: domain of fm-1325773-20240405163223c0c83308707095f514-ljzsih@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-1325773-20240405163223c0c83308707095f514-LJZsIH@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1712334746; x=1712939546; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=NLSZU/6eK2V/eHLzkcIQjQ0NcjzG1uvTlCe1FSrYTIA=; b=oKYSYbQu1EprJ3N10S52Zp/K0JybC0klaUH3kxCQTeoNIJSf0KqzwPwJUGXZUbVlZg 4+66LHcqmshOk0JmJazG1yorUkPZlkla+D+4iyIe7B5STgwUPbBAABaDmRT4+DIOwX4h 5NCDUcC+ZQhnLAeou8McF5aMgPaaCiJ8E8+xCNJpCj1mYnJozNwUnfCCkPB3Eyn6ILVS +H2QvTx1ctEmYY9hfUsrfEpyvwy6Lj+NXAuOXguAVu0dKegZWuLRcsSbNfGAUXdP+5Qo MentvqQ619nkOIdSg1RDkMxqBu1mJ/BwuKYLYnfUUhvV1q3zdM1QMLPlyzg10oMDExlD sZVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712334746; x=1712939546; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NLSZU/6eK2V/eHLzkcIQjQ0NcjzG1uvTlCe1FSrYTIA=; b=AsObebLoalb7xuRSRf/exNFtxZTlQt9FHIFpqzNFazdt//6cjFkTl4E+izRPl8aYez 1gCjV6927Z+5RbnCx0bVkvrZnd9jbf10zFPtYQFzwoA19peThRQu87G8uiOdehnKu6ly eT8XKZYdyGRBcEHphPRPGPwgKjL0F4V885zX45MUlMz05Mvpo1c9SmAt+ZMfydHGJMJ8 22bbf6dI+pljoqpsmi5bPOd23qwruNvJdhvS6mcd0SwazMLVh8NMbFRhkn8mAb6GuSiB v7o6rbQ0OJ4z8Saz7JRE8GdAN+pL15f2xgcuotsTmCi+CvL9ESc/yHFeCzwwogYIP6RI WeeQ== X-Forwarded-Encrypted: i=2; AJvYcCWu41aARunZJj0HBBE8GtJ/Z0P8oJeaZAlEUt/6KAZUXWzE4smZL58PJg0M196grQhaFsNJJ0Er69tu1tNkefEDgS8XkIQ= X-Gm-Message-State: AOJu0Yw5LLD+WNDAOohwY3wOr6bU7ApamiEPF8i03wsDUTWSMCdWAHwP oHr0BDTBP7/AaTsEB86uFqPqpIavxJvKG0OxeJh/BT33t3xmxnDe X-Google-Smtp-Source: AGHT+IHnWMY6i20PrvPcpkcmUtt2Q47MTN6G6ekTFCpfFmrFeqmI/4//6G62w4QcqtO9wn+SrSneFA== X-Received: by 2002:a17:90a:e294:b0:2a2:a10a:d174 with SMTP id d20-20020a17090ae29400b002a2a10ad174mr1934071pjz.6.1712334745699; Fri, 05 Apr 2024 09:32:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:90a:ca8e:b0:2a2:3355:fe9a with SMTP id y14-20020a17090aca8e00b002a23355fe9als1356775pjt.1.-pod-prod-06-us; Fri, 05 Apr 2024 09:32:24 -0700 (PDT) X-Received: by 2002:a17:903:2286:b0:1e0:b872:d862 with SMTP id b6-20020a170903228600b001e0b872d862mr2257254plh.52.1712334744143; Fri, 05 Apr 2024 09:32:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712334744; cv=none; d=google.com; s=arc-20160816; b=PYUhXe1/yZXIu4av0OTsonGxuWvodySHZ5mioTlTZZlvLqCGqI5xbxpBicgV33WkyU T7VuOC9I7eYq+BwySirkDDbxOIrGoBTlzo4dqDRmk8G3F/tZInBFrQ1QNs2fhLB8t9sI a8UMKong0dgZ6tjnbW//OShXltwAZC2lNZVfc+Bkx1SWZRZ1cys7+ppD9d8lURwtF0FP Bxejl3aqoJVnvaulVmVR0z6ToHz3DRJEcGgDzYpSJ8ZpYA6OYmeQzPNji2CAPKoieAV5 vTOLjc42Kk3RXODCM17AILIcypmpBeM8E6gdrKRiHPtHCpgix3zmTptk3cQhTB+3waww WOhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=wyKwn6HscoV1RoKsg24H+Y8IfRwLm00bV1i7brRqD10=; fh=3bh9z2BWAzGAc1byRhMi0K+arMZmX5BQHE0sOxINdyU=; b=eHrxCeMKwfyQHeoJvym7aBnexZUR9ahq3oeGRtW86lV58kQntub4cfnZjjuj4RJ3xD 28jcJfXl5TV9lHF/BdoE/F1diHNCdEjIEzPEJ5DTeVGjMJcVPCPWNCw1hxoHHWDpZbix oLb6gSc7sZ0MueGZcmrEgdkQRSCO2kH18ZRUsC+If4yMWx8pKbUAynlvLILJ7cGiIa3a 1l9HX5FgffQY04GEyeLXcyhMx2vudKKsTEp4OZG2DzpLycEkynyoCsAzzCd2Vg2owNU8 1kOIFCeyUV54Mkjp+gGIQGvV/GqFybj8LYXwalqEIMUGr2cyY2hOFXeBlr6GtXiWZm0K XNuQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=NHniP2JY; spf=pass (google.com: domain of fm-1325773-20240405163223c0c83308707095f514-ljzsih@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-1325773-20240405163223c0c83308707095f514-LJZsIH@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-228.siemens.flowmailer.net (mta-64-228.siemens.flowmailer.net. [185.136.64.228]) by gmr-mx.google.com with ESMTPS id mp6-20020a170902fd0600b001e2c4ecc402si110212plb.8.2024.04.05.09.32.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2024 09:32:24 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1325773-20240405163223c0c83308707095f514-ljzsih@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) client-ip=185.136.64.228; Received: by mta-64-228.siemens.flowmailer.net with ESMTPSA id 20240405163223c0c83308707095f514 for ; Fri, 05 Apr 2024 18:32:23 +0200 X-Patchwork-Original-From: "chris.larson via isar-users" From: "Larson, Chris" To: isar-users@googlegroups.com Cc: Christopher Larson Subject: [PATCH 3/9] isar-sstate: lint: check for absolute paths in SRC_URI Date: Fri, 5 Apr 2024 16:31:29 +0000 Message-Id: <20240405163135.2987489-4-chris.larson@siemens.com> In-Reply-To: <20240405163135.2987489-1-chris.larson@siemens.com> References: <20240405163135.2987489-1-chris.larson@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1325773:519-21489:flowmailer X-Original-Sender: chris.larson@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=NHniP2JY; spf=pass (google.com: domain of fm-1325773-20240405163223c0c83308707095f514-ljzsih@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-1325773-20240405163223c0c83308707095f514-LJZsIH@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: chris.larson@siemens.com Reply-To: chris.larson@siemens.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Christopher Larson In addition to the current checks for variables starting with an absolute path, particularly those within the build or sources directories, we should also check for absolute paths in SRC_URI file entries. Submitted at https://groups.google.com/g/isar-users/c/2NB-PXyswq8/m/C8LiWa1TAQAJ. Signed-off-by: Christopher Larson --- scripts/isar-sstate | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/scripts/isar-sstate b/scripts/isar-sstate index c14c2843..9b20cb8e 100755 --- a/scripts/isar-sstate +++ b/scripts/isar-sstate @@ -839,6 +839,23 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, pedantic, ** continue # remove leading whitespaces possibly added by appending val = val.lstrip() + if name == 'SRC_URI': + src_uri = val.split() + for entry in src_uri: + if entry.startswith('file:///'): + entry_path = entry[7:] + if entry_path.startswith(build_dir): + pn_issues.append(f'\033[0;31m-> path in build-dir: SRC_URI entry "{entry}"\033[0m') + hits_builddir += 1 + elif entry_path.startswith(sources_dir): + pn_issues.append(f'\033[0;31m-> path in sources-dir: SRC_URI entry "{entry}"\033[0m') + hits_srcdir += 1 + else: + hits_other += 1 + if verbose: + pn_issues.append(f'\033[0;34m-> other absolute path: SRC_URI entry "{entry}"\033[0m') + continue + if not val[0] == '/': continue if val.startswith(build_dir):