From patchwork Fri Apr 5 16:31:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Larson, Chris" X-Patchwork-Id: 3482 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 05 Apr 2024 18:32:36 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-pl1-f183.google.com (mail-pl1-f183.google.com [209.85.214.183]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 435GWYjg003073 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 5 Apr 2024 18:32:36 +0200 Received: by mail-pl1-f183.google.com with SMTP id d9443c01a7336-1e2bb241663sf13952815ad.1 for ; Fri, 05 Apr 2024 09:32:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712334748; cv=pass; d=google.com; s=arc-20160816; b=Bs6bK0994M/HclnnwkWEvXj4GAOmquP0+lauHHK9rA0SltHIB9dfFvnhirv17WfQ0j RlfLXd31P2PImtDy0vZ+RXU0S/RenOXttPUkUw8/q5N5EQQu4o3Ave/NImPTkrezpTrw ofaA3K26nN/3aBzExE5yDjIliWy/v1/MsnZjJnu9y/XqmwcZMQfiaUQ253UumXPpBgYC 8EdU5VHFRJ0/0fSoiws1KCGvYSSKAsky2bAPr/abtxosixiuG2v3gBVe9V1DLzjEzE9H 9ytQ0258k9KOlAXHYILbizfopa/UzXT5etahdLn7QIG14Oms0Sk2se7EBHymWQV6/wqf O5kQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YEdxAhD7VIwpglPzUJnp36yZeB3aTfIWatArZQZmVj0=; fh=NYk/Lv0wPZs78zwfMC9tPvJBtKcTk9MNSmo1N4OpGLY=; b=h0LK+/G9ApKd3BKWTuu/ntislqPOvUuttThZ2nfeLo0KwkscoHrcYykwOsf8/MruC2 5xFq68jBP0cNA75Cn/m98+zJbcpl46dBFv/kLfmcJ9HyRBYUjjlYWMDX1A1VbC12vD1B CnZeBCvhnDdo3VsrXVyrk7toq0LMCJ9DwSBOCZEY3JUXMuL+46EnYbDt2yHe/nrLJ3Mz I7Kdjv8oQ5qqnqOmCxvk8LXV0k2pyP5SYhOzSDGi/5VMDg3oB78H5t45R04hJ+rr55ZM uLVagMrbhPLzLjUCGb2+mag1UPXHeIDA+hmxH63fz78ngWghnylvlsjgtsRO3w/wRcTD A1Sw==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Z7p6ts4B; spf=pass (google.com: domain of fm-1325773-20240405163226e6ce2504f08d44c6f5-zapzuj@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1325773-20240405163226e6ce2504f08d44c6f5-zAPzuJ@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1712334748; x=1712939548; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=YEdxAhD7VIwpglPzUJnp36yZeB3aTfIWatArZQZmVj0=; b=CZNrlyn8wLptcnaVBig+rYkddR47URNiITslf5GmmhZjyeaCYk69LviD7StDlSyJjE pyqnii6swpvoalyrsTDKO83ViZ3k0zMvM2CRiAeoKykHUGtn08DKQ7oxpusjxHwZjd7F LZPv2U2iGep39Ub9XkpmWChOfG/dBVmoTqN9WPz5ZB8+1XG2jdNXXI1nIDm2IZnkjr/x 7BYaIaY8GMfgNf7eG6dLNySxOLF3zHxR8N770nI21jDKrQkyJgobYoc5kiM4+DgDvaDN imK9AyQfZZou/SX1mKHULVlvXIeHgjH7ZVi7is+ODAu/oGi2NnfguCQfv5MKEym8mo0L cbtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712334748; x=1712939548; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YEdxAhD7VIwpglPzUJnp36yZeB3aTfIWatArZQZmVj0=; b=Q6llscur5iv9BZ8N4BkXkrsSf1/OMZ8WlOsv92h+b+4lfTkbxOr+ftwcvL5dXGeX4D xFqYEAHUg7Dw9LFeHOZKYkX2Fy4Cjimbo++dn2ewCdLuSmq7O6sgoTuY5zI4Ds2EqCnL bmQw8hZZJNvuGgIAc3tBOsmnuAtonhcSmcgfOH+VpxwhGEDeT87AjfRmmU1Gg96zUVZP BBIiR9Q5cmAEjM+x/v4kRQBcbjGxJtB++zstsX8xs5GL/ddg4mLKrRI3lj+uPMaRAwt1 7F+qcHUCJkSl8mqfIL8oRO+4cTxUsrCuJnxcjj7d+Xk829/ICzNOjYDR2VkUefXkMQzX pMdA== X-Forwarded-Encrypted: i=2; AJvYcCXRtq5usuCHmks0YFNMaDqgda/kKD4z2/9KDyECSEy1ff+CcUYzeSH6NSyp2UonAUA39MK2sZBGp+6Bn1emxkRnddccHRs= X-Gm-Message-State: AOJu0Yw3ZRiciFW9CmaS33DzXGoprCaamoMNHqzBLlVpss3Kr+LDIyE2 Oj49kXDfRgxFQFzADjKaIynKFmOpgzmzJ3WFMgLDsQItfPreT6bv X-Google-Smtp-Source: AGHT+IGPIrlooz9896ao1agV1U1rjgT9NaqXw0i+0hDAfDQJe/f2xTlYhOs3ZyLT+VQJzi3xbtgb5g== X-Received: by 2002:a17:902:d506:b0:1e0:b873:ce48 with SMTP id b6-20020a170902d50600b001e0b873ce48mr2182830plg.27.1712334748417; Fri, 05 Apr 2024 09:32:28 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:902:e5cb:b0:1e2:a413:578b with SMTP id u11-20020a170902e5cb00b001e2a413578bls1735814plf.0.-pod-prod-02-us; Fri, 05 Apr 2024 09:32:27 -0700 (PDT) X-Received: by 2002:a17:902:d2d1:b0:1e2:aa13:5bf4 with SMTP id n17-20020a170902d2d100b001e2aa135bf4mr2370307plc.8.1712334746965; Fri, 05 Apr 2024 09:32:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712334746; cv=none; d=google.com; s=arc-20160816; b=sFXScQZ5C+xZ0tjYt329YUQeV1ma9WFdksN/XlmI3nl97P1jpqm4P+q7g0Pb3oeuba ZiYZD3EXh/0/vE2VTCqib44BLyOzZa9/HG2uHN97Tc6X1ploF5EZ2esyx7wqUxGe0gup Pe7PjKGVpwGG+TovNYbDXuK2BGyqWlOjYx9xUBVyB6LqkMI/EE8rkShkWim/wX9bf6wl MD/59QeoEtl6A2U+LysKLtumK52YlU10gdGIBwuumB8k1ULCIUzCmpBMKXum46knKMy6 fYOWi/0PKRxBCS6S+HVh8gdK9Hv+BWpIhjcBJl/qXZgvG0jLuQPcChzdYFZFCggyPs+u N7sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=XQoEjsphyZvUDDMutunjKOyx4SuUUd8lZ7A+xckUXIg=; fh=3bh9z2BWAzGAc1byRhMi0K+arMZmX5BQHE0sOxINdyU=; b=m8ZMuNNjmH7weUVYfIBv5ZF3g2cr1GQ0N2EF049lRBvkAxM0C5YQLc38QRx81A4x2v S+jdlTRs7FzNFJ85VduA8dx/4dHb8k7Xvs9lv0KtxPMEKfcWJsybkMxpwfeeangESN7j bQofGsVzYm57PjnF0ooXhgQck9949Axn/pckBxC1/6HDKhaSOC+wb75HJj0/jvKIW/cr XqnL5ZuKEqSdfKJ49rrfopNWIIcpkEDVb3utdiVEIr5xE2qUvdy1xkvjMlNiN+SEISOg 1+sBKnqNMUTfELcJOm4eqt/bC8+VSyytBX9oa6bPxu1ud5YsNSkxRopxXTZrwYTCL2MB c1fQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Z7p6ts4B; spf=pass (google.com: domain of fm-1325773-20240405163226e6ce2504f08d44c6f5-zapzuj@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1325773-20240405163226e6ce2504f08d44c6f5-zAPzuJ@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-226.siemens.flowmailer.net (mta-65-226.siemens.flowmailer.net. [185.136.65.226]) by gmr-mx.google.com with ESMTPS id jc18-20020a17090325d200b001dd61b4ef8esi97963plb.12.2024.04.05.09.32.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2024 09:32:26 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1325773-20240405163226e6ce2504f08d44c6f5-zapzuj@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) client-ip=185.136.65.226; Received: by mta-65-226.siemens.flowmailer.net with ESMTPSA id 20240405163226e6ce2504f08d44c6f5 for ; Fri, 05 Apr 2024 18:32:26 +0200 X-Patchwork-Original-From: "chris.larson via isar-users" From: "Larson, Chris" To: isar-users@googlegroups.com Cc: Christopher Larson Subject: [PATCH 6/9] isar-sstate: fix failures if a variable is set to just whitespace Date: Fri, 5 Apr 2024 16:31:32 +0000 Message-Id: <20240405163135.2987489-7-chris.larson@siemens.com> In-Reply-To: <20240405163135.2987489-1-chris.larson@siemens.com> References: <20240405163135.2987489-1-chris.larson@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1325773:519-21489:flowmailer X-Original-Sender: chris.larson@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Z7p6ts4B; spf=pass (google.com: domain of fm-1325773-20240405163226e6ce2504f08d44c6f5-zapzuj@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1325773-20240405163226e6ce2504f08d44c6f5-zAPzuJ@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: chris.larson@siemens.com Reply-To: chris.larson@siemens.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Christopher Larson We see this failure if a variable is set to the empty string, as whitespace is being stripped off of the variable after we check if the value is empty or None, not before. Traceback (most recent call last): File "/home/kergoth/Code/indos/signatures/isar/scripts/isar-sstate", line 941, in sys.exit(main()) ^^^^^^ File "/home/kergoth/Code/indos/signatures/isar/scripts/isar-sstate", line 937, in main return globals()[f'sstate_{args.command}'](**vars(args)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/kergoth/Code/indos/signatures/isar/scripts/isar-sstate", line 894, in sstate_lint if not val[0] == '/': ~~~^^^ IndexError: string index out of range Signed-off-by: Christopher Larson --- scripts/isar-sstate | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/isar-sstate b/scripts/isar-sstate index a4429b7a..4ea38bc8 100755 --- a/scripts/isar-sstate +++ b/scripts/isar-sstate @@ -868,10 +868,11 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, pedantic, li sigdata['taskhash_ignore_tasks'] and name in sigdata['taskhash_ignore_tasks'] or \ name in ADDITIONAL_IGNORED_VARNAMES: continue - if not val: - continue # remove leading whitespaces possibly added by appending val = val.lstrip() + if not val: + continue + if name == 'SRC_URI': src_uri = val.split() for entry in src_uri: