From patchwork Wed Apr 17 06:46:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhibin Dong X-Patchwork-Id: 3494 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 17 Apr 2024 08:47:32 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-pl1-f189.google.com (mail-pl1-f189.google.com [209.85.214.189]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 43H6lVeF026576 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 17 Apr 2024 08:47:32 +0200 Received: by mail-pl1-f189.google.com with SMTP id d9443c01a7336-1e2c0d3eadesf51926385ad.0 for ; Tue, 16 Apr 2024 23:47:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713336445; cv=pass; d=google.com; s=arc-20160816; b=vav9MIX3x8yPqWsdHsUYCvCUEco6k0Monb+a1ZR0UcSAe4QIECf5xIcNgSz38ExKm/ Q3MnL74WMScsIG1+Fbcy9+PILAiBcAoNcyizdloyRx5LlFVZbFgSNtcubca0BeeSwJKy 3qgYwNnOuoxm4eMWr2uXPIs3SHp/Y4yiSvp8MDuk3DMz1eRbjraH8XAEWYqEmUGc/P63 WvwdD4g5lckHKLpZWfZwYfTDEkAztpmjbKtsfkNTUHJZT5MnR84hsM1Qf0M5tjFBp5ks 1IzdUM6Ip+VBLQjkc0AxFNKHZj2kPIR+faroiriFC1R3lr9ggDeupKWYJDeowIXOcrgL gUXg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature :dkim-signature; bh=yiiGoEUePEu9HaBNwbAIO54Q6DIDKBOo2CsWe97rsMo=; fh=jOQcqw22RN7brw+/ysr0OYiIEP2TKvFamkqBU76Lpro=; b=IMgsWqI6fLX3+jbJ3ec0RuQeYDyt3Wwb7yvTsfhA/vbVP2DhUheZeSHUvQkJDhpTB4 r7ee7J2OCOrUobvBR5uvtxE2iIeDqikTQa+ND10ipYArK2u0mrF10j6BJWaAqmBEItEw jcbp8UP7yLHICiwWicuBY24HcNWrUnsXKwGpQMj1cJ3iXUcV2viqc6BMWMcRxzyfpUib 58buohKb2w+vUgcsbyEmtJozJ1/FXqRvepKkdP6iS1iptOI5vEBqeAVc4mT/m4Ww180L K/wueHqx3oaaUhekuKtZz3zqLNnqlHZek9XfiZNrs3A7d9KeeMihZ7MSytFJUc3ZZKW5 0FQg==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=PG6vDCR+; spf=pass (google.com: domain of developerdong@gmail.com designates 2607:f8b0:4864:20::430 as permitted sender) smtp.mailfrom=developerdong@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1713336445; x=1713941245; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=yiiGoEUePEu9HaBNwbAIO54Q6DIDKBOo2CsWe97rsMo=; b=IqxVjTkgqxASc8s0/QdaSnpreuIjqneYE3jRM0FoEvGPjRk92suA3GRFcmn2HfKl++ h3MkCOuHIJRUutjdfqJBDatM8CTp8yJ09gWUbCEVguHT6aRhZQNyXL4uBiNvcmYxaNuW syKIYV4N+iqI4CYAI7nUH9VlmPifOYzaWTFWmpj4cvQNE3eRwwVGPUNNYmDCCdx5BZ0z RtGp1FUxZBTofLER9IsN0nCZ92/fftkXb8g5pTbLRBMXAcP6rle2XfhIt3sNmoqbG+h0 hk8ZOeV9dOED4bhpDkmXbE4K6TfqvN+3jLov47q4WOvGukc6Vm+xufJ71I+bRblgBeEO K05w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713336445; x=1713941245; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=yiiGoEUePEu9HaBNwbAIO54Q6DIDKBOo2CsWe97rsMo=; b=J3T+1qsm2uYIplI79X9tHIQtLgCAv7Vv3M8GV78Sb4AuKC54pJAzymW37+CrEtuAUu bycUsOHgzWhDnKRa49lSs1o5q3MkEZu+u6+4g9gO6jY4emPS3B6wk6bu+cUS0R6ZY+WB 293HgKiHXe0eJK9Hl9LY6mKl3PLtKcJSXW5uZHfEaYEuTRDEoqg8chgxdmPyYuJu7gPM ireNYnwKtNcBouBQvH5XCxfk9sOGgTl2hffN8dkSfN4s8rrUtb3i3rvFWbZofzItQtzQ mYUfKTqx3zjYOP4XHTTnnk7KLAKsRpvTNELroV9vSJTzCmITr2HAtrbfojTyK9PfoUY9 C1BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713336445; x=1713941245; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=yiiGoEUePEu9HaBNwbAIO54Q6DIDKBOo2CsWe97rsMo=; b=lvHcku2pQ/aLIgLCh1nBhX2C+6wo+R8e2QJNjINUEbKGzaqHIY5EhsjS7ztVkUcPen kHU6j20nv2q6ru9SJ7lU5Z5sMn0t8K1ku5QPpSXz/+7EaLKt+NFgade/+PNWDsvv1RQw TDsLpel8ydX73BtJ+J6Ewm2SXlA+y+qMoIpQN2boalY02SQrXF4luzvHgPjn/SvofhV9 vNOWqsatZEbTVnM1znS/n0WN60X+XKbK50Yt0qiXh4CFQZ1GwARxkzyJmMLsbPiLTkqi YJ+bukvCrfYhlh8hGmvkQfbmdg672nfQfFXpk+LzjNb0K/5EdGhsNlHT0HoxR+/kngVY eH5Q== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCWiqoHeAMwhOubFdOiyDKVYC+HANcuZ2/wxS5kLNCGc6qpdKWjmFvhWr3+fZ0U4ZD8qjxwyX1lGWtMyskjXLCDhlJY33zo= X-Gm-Message-State: AOJu0Yz06w+jEtz76l3yFmuxroKX6fdKqMN3ITDPB8E6jwA0IzRFC0qo mWLdrDO0JN8vPQJhmXsJOGA2j98SEymZPsOfDRElWoUoczKa+a8F X-Google-Smtp-Source: AGHT+IEotP5e/z0B4M49iizzIzj6AOSyoOGhimYI0JC1WxiOUF3/v8Ld0A4NZL9xcwJjaWF2M90DZQ== X-Received: by 2002:a17:903:2452:b0:1e7:c05c:f1be with SMTP id l18-20020a170903245200b001e7c05cf1bemr6611287pls.0.1713336445099; Tue, 16 Apr 2024 23:47:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:902:e84e:b0:1e5:10f7:ff1e with SMTP id t14-20020a170902e84e00b001e510f7ff1els3206337plg.0.-pod-prod-01-us; Tue, 16 Apr 2024 23:47:24 -0700 (PDT) X-Received: by 2002:a17:902:ce0e:b0:1e4:cb0e:2988 with SMTP id k14-20020a170902ce0e00b001e4cb0e2988mr18629996plg.2.1713336443605; Tue, 16 Apr 2024 23:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713336443; cv=none; d=google.com; s=arc-20160816; b=XxW1P6uqu1oh341b5UlefxNcgCYpkSwN+Z6kFiZ9k6a4z/9w2JBX4lUQKaBGzWVXzq p3A2TdhhWCGYhBvErUAHdNMXkvUtRTDF6rV9iTMUgj3B6gNsjTibeu7jOsdi/QW+TnMS uY5PZohQUbZwJZQpglZ7hds2Tas1ZpYjUADXo0N+5pmEJaqULy8IiZaLsCSntaXZQXv8 mlgo24iUpyRelPVZQuRwj+7tUG3fipzKkd0zMfaUg/CDz4086rbKzOAFlPnqO2g27mMe Il/4eCwbGkL5YRXmt1lqOI9z/C5yDXMfOIDAMvol2nvJj4/c3zb7hesDgEvCGU8h3TrB PfTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=srWZbDE5T2BoGFdeBQf+PyUU4w0ZaIs6i4NJhOO5yOU=; fh=dZbs7OdW2ieBo6+PoNybICM0JqsHP1X53GnCLtZWpyw=; b=d1aegAJzPVqCfVC729duIw9evVybg58JBx456mjFx7NLGRQ1kXO44W5QK6nDck9swK VCw+NGBk3bSC7w3dixk+W1nypoaop2J7Ap1OPwLoaYatH+GnLY/NzMkm20D7Z1onq5Dq 72oyH+H/Bzs5DiEvo5g+8RFpH7vzDYyakXlIqA5HpVL19zI3bv+omN5zH2Nj+v0czmmC g0HdtepkSUYnQnUZ50Bjam1v1H8GmQP+iFRM7D9TERUK90Afcctofzq8ha7SfXonFqWj O3wLT4tB55f0jwWM2vn6M0WgVI9bK+/7QQEGEWaTjrvIztq2XMqSswyVqLRogH3iyYcQ W6DQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=PG6vDCR+; spf=pass (google.com: domain of developerdong@gmail.com designates 2607:f8b0:4864:20::430 as permitted sender) smtp.mailfrom=developerdong@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com. [2607:f8b0:4864:20::430]) by gmr-mx.google.com with ESMTPS id l18-20020a170903005200b001e5083fbf11si808957pla.0.2024.04.16.23.47.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Apr 2024 23:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of developerdong@gmail.com designates 2607:f8b0:4864:20::430 as permitted sender) client-ip=2607:f8b0:4864:20::430; Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6eff9dc1821so2630333b3a.3 for ; Tue, 16 Apr 2024 23:47:23 -0700 (PDT) X-Received: by 2002:a05:6a00:10c2:b0:6ed:41f3:cd06 with SMTP id d2-20020a056a0010c200b006ed41f3cd06mr16312351pfu.7.1713336442193; Tue, 16 Apr 2024 23:47:22 -0700 (PDT) Received: from md3knb8c.ad001.siemens.net (45.78.51.22.16clouds.com. [45.78.51.22]) by smtp.gmail.com with ESMTPSA id 9-20020a631149000000b005dbed0ffb10sm9971283pgr.83.2024.04.16.23.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 23:47:21 -0700 (PDT) From: Zhibin Dong To: isar-users@googlegroups.com Cc: Zhibin Dong Subject: [PATCH] image: check if the file is core dump Date: Wed, 17 Apr 2024 14:46:00 +0800 Message-Id: <20240417064600.12133-1-zhibin.dong@siemens.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240416051222.3344127-1-zhibin.dong@siemens.com> References: <20240416051222.3344127-1-zhibin.dong@siemens.com> MIME-Version: 1.0 X-Original-Sender: developerDong@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=PG6vDCR+; spf=pass (google.com: domain of developerdong@gmail.com designates 2607:f8b0:4864:20::430 as permitted sender) smtp.mailfrom=developerdong@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The previous code does a wrong judgement in two cases: 1. a file is suffixed by .core but is not a core dump file 2. a file is a core dump file but is not suffixed by .core The new code uses `file` to determine the type of files, which is more accurate. Signed-off-by: Zhibin Dong --- meta/classes/image.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index 98741da0..2b0995d2 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -444,7 +444,7 @@ EOSUDO # Sometimes qemu-user-static generates coredumps in chroot, move them # to work temporary directory and inform user about it. - for f in $(sudo find ${ROOTFSDIR} -type f -name *.core); do + for f in $(sudo find ${ROOTFSDIR} -type f -exec file --mime-type {} \; | grep 'application/x-coredump' | cut -d: -f1); do sudo mv "${f}" "${WORKDIR}/temp/" bbwarn "found core dump in rootfs, check it in ${WORKDIR}/temp/${f##*/}" done