| Message ID | 20240524065241.1393937-1-srinuvasan.a@siemens.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | Drop redundant expand=True parameter from getVar | expand |
On Fri, 2024-05-24 at 12:22 +0530, srinuvasan.a via isar-users wrote: > From: Srinuvasan A <srinuvasan.a@siemens.com> > > It is long True by default, but people keep adding new cases of this > redundancy, hence fix this one. Thanks! Acked-by: Felix Moessbauer <felix.moessbauer@siemens.com> > > Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> > --- > meta/recipes-kernel/linux/linux-custom.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc > b/meta/recipes-kernel/linux/linux-custom.inc > index 0d222332..433ed057 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@ > d.getVar('BPN').partition('linux-')[2]}" > > # Determine cross-profile override > python() { > - if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and > d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in > d.getVar("OVERRIDES", True).split(":"): > + if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and > d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in > d.getVar("OVERRIDES").split(":"): > d.appendVar("OVERRIDES", ":cross-profile") > } > > -- > 2.34.1 >
24/05/2024 09:52, srinuvasan.a via isar-users wrote: > From: Srinuvasan A <srinuvasan.a@siemens.com> > > It is long True by default, but people keep adding new cases of this > redundancy, hence fix this one. > > Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> > --- > meta/recipes-kernel/linux/linux-custom.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc > index 0d222332..433ed057 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@ d.getVar('BPN').partition('linux-')[2]}" > > # Determine cross-profile override > python() { > - if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in d.getVar("OVERRIDES", True).split(":"): > + if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in d.getVar("OVERRIDES").split(":"): > d.appendVar("OVERRIDES", ":cross-profile") > } > Hello Srinuvasan, This was already fixed in next by: 7505bd07 ("linux-custom: use to_boolean when checking ISAR_CROSS_COMPILE")
On Friday, May 24, 2024 at 2:08:44 PM UTC+5:30 Anton Mikanovich wrote: 24/05/2024 09:52, srinuvasan.a via isar-users wrote: > From: Srinuvasan A <srinuv...@siemens.com> > > It is long True by default, but people keep adding new cases of this > redundancy, hence fix this one. > > Signed-off-by: Srinuvasan A <srinuv...@siemens.com> > --- > meta/recipes-kernel/linux/linux-custom.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc > index 0d222332..433ed057 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@ d.getVar('BPN').partition('linux-')[2]}" > > # Determine cross-profile override > python() { > - if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in d.getVar("OVERRIDES", True).split(":"): > + if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in d.getVar("OVERRIDES").split(":"): > d.appendVar("OVERRIDES", ":cross-profile") > } > Hello Srinuvasan, This was already fixed in next by: 7505bd07 ("linux-custom: use to_boolean when checking ISAR_CROSS_COMPILE") Hi Anton, Yes, accidently created patch on master instead of next, sorry for the inconvenience, but still it's partially fixed in next, i will send v1 of this patch again. Thanks, Srinu
On Fri, 2024-05-24 at 12:22 +0530, srinuvasan.a via isar-users wrote: > From: Srinuvasan A <srinuvasan.a@siemens.com> > > It is long True by default, but people keep adding new cases of this > redundancy, hence fix this one. > > Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> > --- > meta/recipes-kernel/linux/linux-custom.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc > b/meta/recipes-kernel/linux/linux-custom.inc > index 0d222332..433ed057 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@ > d.getVar('BPN').partition('linux-')[2]}" > > # Determine cross-profile override > python() { > - if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and > d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in > d.getVar("OVERRIDES", True).split(":"): > + if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and > d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in > d.getVar("OVERRIDES").split(":"): > d.appendVar("OVERRIDES", ":cross-profile") > } > > -- > 2.34.1 > Applied to next, thanks.
diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc index 0d222332..433ed057 100644 --- a/meta/recipes-kernel/linux/linux-custom.inc +++ b/meta/recipes-kernel/linux/linux-custom.inc @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@ d.getVar('BPN').partition('linux-')[2]}" # Determine cross-profile override python() { - if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in d.getVar("OVERRIDES", True).split(":"): + if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in d.getVar("OVERRIDES").split(":"): d.appendVar("OVERRIDES", ":cross-profile") }