| Message ID | 20240731151644.213693-1-felix.moessbauer@siemens.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/1] fix: remove not-needed python3-distutils from wic deps | expand |
31/07/2024 18:16, 'Felix Moessbauer' via isar-users wrote: > The python3-distutils package currently does not exist in debian trixie, > breaking the build. While debugging this, I noticed that this dependency > seems to be no longer needed. > > This patch removes the wic dependency python3-distutils > > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> > --- > meta/conf/distro/debian-common.conf | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf > index d8556964..8c6a3f63 100644 > --- a/meta/conf/distro/debian-common.conf > +++ b/meta/conf/distro/debian-common.conf > @@ -18,7 +18,6 @@ IMAGER_INSTALL:wic += "parted \ > dosfstools \ > mtools \ > e2fsprogs \ > - python3-distutils \ > bmap-tools \ > tar \ > fdisk" Hello Felix, The same fix was already sent by Jan in the patch: [PATCH] debian-common: Drop python3-distutils dependency but your patch looks cleaner because of endline changes.
On Thu, 2024-08-01 at 09:12 +0300, Anton Mikanovich wrote: > 31/07/2024 18:16, 'Felix Moessbauer' via isar-users wrote: > > The python3-distutils package currently does not exist in debian > > trixie, > > breaking the build. While debugging this, I noticed that this > > dependency > > seems to be no longer needed. > > > > This patch removes the wic dependency python3-distutils > > > > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> > > --- > > meta/conf/distro/debian-common.conf | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/meta/conf/distro/debian-common.conf > > b/meta/conf/distro/debian-common.conf > > index d8556964..8c6a3f63 100644 > > --- a/meta/conf/distro/debian-common.conf > > +++ b/meta/conf/distro/debian-common.conf > > @@ -18,7 +18,6 @@ IMAGER_INSTALL:wic += "parted \ > > dosfstools \ > > mtools \ > > e2fsprogs \ > > - python3-distutils \ > > bmap-tools \ > > tar \ > > fdisk" > > Hello Felix, > > The same fix was already sent by Jan in the patch: > > [PATCH] debian-common: Drop python3-distutils dependency Ah ok. I overlooked this. > > but your patch looks cleaner because of endline changes. Then let's just merge this and drop the one from Jan. Felix >
On 01.08.24 08:16, Moessbauer, Felix (T CED OES-DE) wrote: > On Thu, 2024-08-01 at 09:12 +0300, Anton Mikanovich wrote: >> 31/07/2024 18:16, 'Felix Moessbauer' via isar-users wrote: >>> The python3-distutils package currently does not exist in debian >>> trixie, >>> breaking the build. While debugging this, I noticed that this >>> dependency >>> seems to be no longer needed. >>> >>> This patch removes the wic dependency python3-distutils >>> >>> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> >>> --- >>> meta/conf/distro/debian-common.conf | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/meta/conf/distro/debian-common.conf >>> b/meta/conf/distro/debian-common.conf >>> index d8556964..8c6a3f63 100644 >>> --- a/meta/conf/distro/debian-common.conf >>> +++ b/meta/conf/distro/debian-common.conf >>> @@ -18,7 +18,6 @@ IMAGER_INSTALL:wic += "parted \ >>> dosfstools \ >>> mtools \ >>> e2fsprogs \ >>> - python3-distutils \ >>> bmap-tools \ >>> tar \ >>> fdisk" >> >> Hello Felix, >> >> The same fix was already sent by Jan in the patch: >> >> [PATCH] debian-common: Drop python3-distutils dependency > > Ah ok. I overlooked this. > >> >> but your patch looks cleaner because of endline changes. > > Then let's just merge this and drop the one from Jan. > Mine provides clear reasoning AND cleans up the file :) Jan
diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf index d8556964..8c6a3f63 100644 --- a/meta/conf/distro/debian-common.conf +++ b/meta/conf/distro/debian-common.conf @@ -18,7 +18,6 @@ IMAGER_INSTALL:wic += "parted \ dosfstools \ mtools \ e2fsprogs \ - python3-distutils \ bmap-tools \ tar \ fdisk"
The python3-distutils package currently does not exist in debian trixie, breaking the build. While debugging this, I noticed that this dependency seems to be no longer needed. This patch removes the wic dependency python3-distutils Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> --- meta/conf/distro/debian-common.conf | 1 - 1 file changed, 1 deletion(-)