diff mbox series

meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file

Message ID 20240809065158.224059-1-srinuvasan.a@siemens.com
State Superseded, archived
Headers show
Series meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file | expand

Commit Message

Arjunan, Srinu Aug. 9, 2024, 6:51 a.m. UTC 
From: Srinuvasan A <srinuvasan.a@siemens.com>

Now debhelper supports the versions debhelper-compat (= 9) till
debhelper-compat (= 13), hence set appropriate debian helper compatible version
in the debian/control file and remove the debian/compat file.

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 meta/recipes-kernel/linux/files/debian/compat       | 1 -
 meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
 delete mode 100644 meta/recipes-kernel/linux/files/debian/compat

Comments

Jan Kiszka Aug. 9, 2024, 4:43 p.m. UTC | #1 
On 09.08.24 08:51, srinuvasan.a@siemens.com wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> Now debhelper supports the versions debhelper-compat (= 9) till

What is "now" in this context? Which Debian releases are your referring
to? Keep in mind that we are still compiling down to buster with these
files. Doubt that this would still work...

> debhelper-compat (= 13), hence set appropriate debian helper compatible version
> in the debian/control file and remove the debian/compat file.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-kernel/linux/files/debian/compat       | 1 -
>  meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/compat b/meta/recipes-kernel/linux/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl b/meta/recipes-kernel/linux/files/debian/control.tmpl
> index 04ad0f4f..ae257b7c 100644
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
>  Section: kernel
>  Priority: optional
>  Maintainer: ${MAINTAINER}
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= 12), bc, kmod, cpio, ${KBUILD_DEPENDS}
>  Homepage: http://www.kernel.org/
>  
>  Package: linux-image-${KERNEL_NAME_PROVIDED}

Jan
Srinuvasan Arjunan Aug. 11, 2024, 2:20 p.m. UTC | #2 
On Friday, August 9, 2024 at 10:13:44 PM UTC+5:30 Jan Kiszka wrote:

On 09.08.24 08:51, srinuv...@siemens.com wrote: 
> From: Srinuvasan A <srinuv...@siemens.com> 
> 
> Now debhelper supports the versions debhelper-compat (= 9) till 

What is "now" in this context? Which Debian releases are your referring 
to? Keep in mind that we are still compiling down to buster with these 
files. Doubt that this would still work...


    yes am aware that one still we are supporting buster Debian release, i 
hope the default compatibility
    version for buster is 12, and already we had some discussion in the 
mailing list, please refer [1].

     Triggered the build for QEMU buster with this changes, it is getting 
passed, need to check any other real H/W buster build
      with compat 12 .

     [1]:  
https://groups.google.com/g/isar-users/c/6obXqgY0CC4/m/_DOppmgEBAAJ 



> debhelper-compat (= 13), hence set appropriate debian helper compatible 
version 
> in the debian/control file and remove the debian/compat file. 
> 
> Signed-off-by: Srinuvasan A <srinuv...@siemens.com> 
> --- 
> meta/recipes-kernel/linux/files/debian/compat | 1 - 
> meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +- 
> 2 files changed, 1 insertion(+), 2 deletions(-) 
> delete mode 100644 meta/recipes-kernel/linux/files/debian/compat 
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/compat 
b/meta/recipes-kernel/linux/files/debian/compat 
> deleted file mode 100644 
> index f599e28b..00000000 
> --- a/meta/recipes-kernel/linux/files/debian/compat 
> +++ /dev/null 
> @@ -1 +0,0 @@ 
> -10 
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl 
b/meta/recipes-kernel/linux/files/debian/control.tmpl 
> index 04ad0f4f..ae257b7c 100644 
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl 
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl 
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED} 
> Section: kernel 
> Priority: optional 
> Maintainer: ${MAINTAINER} 
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS} 
> +Build-Depends: debhelper-compat (= 12), bc, kmod, cpio, 
${KBUILD_DEPENDS} 
> Homepage: http://www.kernel.org/ 
> 
> Package: linux-image-${KERNEL_NAME_PROVIDED} 

Jan
Uladzimir Bely Aug. 27, 2024, 3:45 p.m. UTC | #3 
On Fri, 2024-08-09 at 12:21 +0530, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> Now debhelper supports the versions debhelper-compat (= 9) till
> debhelper-compat (= 13), hence set appropriate debian helper
> compatible version
> in the debian/control file and remove the debian/compat file.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-kernel/linux/files/debian/compat       | 1 -
>  meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/compat
> b/meta/recipes-kernel/linux/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl
> b/meta/recipes-kernel/linux/files/debian/control.tmpl
> index 04ad0f4f..ae257b7c 100644
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
>  Section: kernel
>  Priority: optional
>  Maintainer: ${MAINTAINER}
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= 12), bc, kmod, cpio,
> ${KBUILD_DEPENDS}
>  Homepage: http://www.kernel.org/
>  
>  Package: linux-image-${KERNEL_NAME_PROVIDED}
> -- 
> 2.34.1
> 

Hello all.

The patch checked in CI and it passes OK, but it's not clear from a
discussion if it is worth applying.
Arjunan, Srinu Aug. 28, 2024, 5:04 a.m. UTC | #4 
Thanks Uladzimir, Will update the build status of real target ASAP from my end as well.

-----Original Message-----
From: Uladzimir Bely <ubely@ilbers.de>
Sent: 27 August 2024 21:16
To: Arjunan, Srinu (DI CTO FDS CES LX PBU 2) <srinuvasan.a@siemens.com>; isar-users@googlegroups.com
Cc: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>
Subject: Re: [PATCH] meta/recipes-kernel/linux/files: use debhelper-compat to generate compat file

On Fri, 2024-08-09 at 12:21 +0530, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> Now debhelper supports the versions debhelper-compat (= 9) till
> debhelper-compat (= 13), hence set appropriate debian helper
> compatible version in the debian/control file and remove the
> debian/compat file.
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-kernel/linux/files/debian/compat       | 1 -
>  meta/recipes-kernel/linux/files/debian/control.tmpl | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>  delete mode 100644 meta/recipes-kernel/linux/files/debian/compat
>
> diff --git a/meta/recipes-kernel/linux/files/debian/compat
> b/meta/recipes-kernel/linux/files/debian/compat
> deleted file mode 100644
> index f599e28b..00000000
> --- a/meta/recipes-kernel/linux/files/debian/compat
> +++ /dev/null
> @@ -1 +0,0 @@
> -10
> diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl
> b/meta/recipes-kernel/linux/files/debian/control.tmpl
> index 04ad0f4f..ae257b7c 100644
> --- a/meta/recipes-kernel/linux/files/debian/control.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
> @@ -2,7 +2,7 @@ Source: linux-${KERNEL_NAME_PROVIDED}
>  Section: kernel
>  Priority: optional
>  Maintainer: ${MAINTAINER}
> -Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
> +Build-Depends: debhelper-compat (= 12), bc, kmod, cpio,
> ${KBUILD_DEPENDS}
>  Homepage:
> http://www.k/
> ernel.org%2F&data=05%7C02%7Csrinuvasan.a%40siemens.com%7C7fa7950ce18d4
> 474a83408dcc6af4b00%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C63860
> 3703423305649%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
> MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=iM4bLGTAYnfF1lOA
> %2FKpouvr3WOzgXjfLhwBxbomy%2BbM%3D&reserved=0
>
>  Package: linux-image-${KERNEL_NAME_PROVIDED}
> --
> 2.34.1
>

Hello all.

The patch checked in CI and it passes OK, but it's not clear from a
discussion if it is worth applying.

--
Best regards,
Uladzimir.
diff mbox series

Patch

diff --git a/meta/recipes-kernel/linux/files/debian/compat b/meta/recipes-kernel/linux/files/debian/compat
deleted file mode 100644
index f599e28b..00000000
--- a/meta/recipes-kernel/linux/files/debian/compat
+++ /dev/null
@@ -1 +0,0 @@ 
-10
diff --git a/meta/recipes-kernel/linux/files/debian/control.tmpl b/meta/recipes-kernel/linux/files/debian/control.tmpl
index 04ad0f4f..ae257b7c 100644
--- a/meta/recipes-kernel/linux/files/debian/control.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/control.tmpl
@@ -2,7 +2,7 @@  Source: linux-${KERNEL_NAME_PROVIDED}
 Section: kernel
 Priority: optional
 Maintainer: ${MAINTAINER}
-Build-Depends: bc, kmod, cpio, ${KBUILD_DEPENDS}
+Build-Depends: debhelper-compat (= 12), bc, kmod, cpio, ${KBUILD_DEPENDS}
 Homepage: http://www.kernel.org/
 
 Package: linux-image-${KERNEL_NAME_PROVIDED}