[3/3] phyboard-mira.conf: use a specific target build

Message ID 20240813115521.381481-3-nicusor.huhulea@siemens.com
State Superseded, archived
Headers show
Series [1/3] linux-custom: optimization on kernel's make command | expand

Commit Message

nicusor.huhulea@siemens.com Aug. 13, 2024, 11:55 a.m. UTC
The reason for this change is that phyboard-mira full build produces
several tens of dtbs from the nxp bsp dir, therefore use a target build
to get only the desired dtb

Signed-off-by: Nicusor Huhulea <nicusor.huhulea@siemens.com>
---
 meta-isar/conf/machine/phyboard-mira.conf | 2 ++
 1 file changed, 2 insertions(+)

Comments

nicusor.huhulea@siemens.com Aug. 13, 2024, 12:10 p.m. UTC | #1
I can add another con to the cons already mentioned in this thread, particularly for ARM architectures.
So, it's better to use a targeted build needed for the target hardware and a full build should be only reserved for the entire range of hardware supported by the bsp dir.
e.g: for me it make sense to have a full build if I'm going to do a test on all the bsps from arch/arm/nxp/freescale/*.dtbs but it does not make sense to have a full build when I'm using one bsp.

>>-----Original Message-----
>>From: Huhulea, Nicusor Liviu (DI CTO FDS CES LX SVCS)
>><nicusor.huhulea@siemens.com>
>>Sent: Tuesday, August 13, 2024 2:55 PM
>>To: isar-users@googlegroups.com
>>Cc: Huhulea, Nicusor Liviu (DI CTO FDS CES LX SVCS)
>><nicusor.huhulea@siemens.com>
>>Subject: [PATCH 3/3] phyboard-mira.conf: use a specific target build
>>
>>The reason for this change is that phyboard-mira full build produces several tens
>>of dtbs from the nxp bsp dir, therefore use a target build to get only the desired
>>dtb
>>
>>Signed-off-by: Nicusor Huhulea <nicusor.huhulea@siemens.com>
>>---
>> meta-isar/conf/machine/phyboard-mira.conf | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>>diff --git a/meta-isar/conf/machine/phyboard-mira.conf b/meta-
>>isar/conf/machine/phyboard-mira.conf
>>index feec4e54..1d2b3e1c 100644
>>--- a/meta-isar/conf/machine/phyboard-mira.conf
>>+++ b/meta-isar/conf/machine/phyboard-mira.conf
>>@@ -20,6 +20,8 @@ DTB_FILES = "imx6q-phytec-mira-rdk-nand.dtb"
>>
>> IMAGE_INSTALL += "barebox"
>>
>>+KERNEL_IMAGETYPE = "zImage"
>>+
>> BAREBOX_CONFIG = "imx_v7_defconfig"
>> BAREBOX_ENV = "phytec-mira-env"
>> BAREBOX_BASE_BIN = "barebox-phytec-phycore-imx6q-som-nand-1gib"
>>--
>>2.39.2
Jan Kiszka Aug. 13, 2024, 12:34 p.m. UTC | #2
On 13.08.24 13:55, 'Nicusor Huhulea' via isar-users wrote:
> The reason for this change is that phyboard-mira full build produces
> several tens of dtbs from the nxp bsp dir, therefore use a target build
> to get only the desired dtb
> 

It's also needed so that we have at least one test in-tree.

> Signed-off-by: Nicusor Huhulea <nicusor.huhulea@siemens.com>
> ---
>  meta-isar/conf/machine/phyboard-mira.conf | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-isar/conf/machine/phyboard-mira.conf b/meta-isar/conf/machine/phyboard-mira.conf
> index feec4e54..1d2b3e1c 100644
> --- a/meta-isar/conf/machine/phyboard-mira.conf
> +++ b/meta-isar/conf/machine/phyboard-mira.conf
> @@ -20,6 +20,8 @@ DTB_FILES = "imx6q-phytec-mira-rdk-nand.dtb"
>  
>  IMAGE_INSTALL += "barebox"
>  
> +KERNEL_IMAGETYPE = "zImage"
> +
>  BAREBOX_CONFIG = "imx_v7_defconfig"
>  BAREBOX_ENV = "phytec-mira-env"
>  BAREBOX_BASE_BIN = "barebox-phytec-phycore-imx6q-som-nand-1gib"

BTW, you are missing patch 4 in your series. I reminded of it in V1 of
your submission.

Jan

Patch

diff --git a/meta-isar/conf/machine/phyboard-mira.conf b/meta-isar/conf/machine/phyboard-mira.conf
index feec4e54..1d2b3e1c 100644
--- a/meta-isar/conf/machine/phyboard-mira.conf
+++ b/meta-isar/conf/machine/phyboard-mira.conf
@@ -20,6 +20,8 @@  DTB_FILES = "imx6q-phytec-mira-rdk-nand.dtb"
 
 IMAGE_INSTALL += "barebox"
 
+KERNEL_IMAGETYPE = "zImage"
+
 BAREBOX_CONFIG = "imx_v7_defconfig"
 BAREBOX_ENV = "phytec-mira-env"
 BAREBOX_BASE_BIN = "barebox-phytec-phycore-imx6q-som-nand-1gib"