[v2] fix: unsupported value of disk format in ovf

Message ID 20240823022356.160179-1-chengshu.mou@siemens.com
State Superseded, archived
Headers show
Series [v2] fix: unsupported value of disk format in ovf | expand

Commit Message

Mou Chengshu(Ben) Aug. 23, 2024, 2:23 a.m. UTC
fix: unsupported value of disk format in ovf

Currently, Isar doesn't assign the variable 'VMDK_SUBFORMAT' into ovf template 
that causes generated ovf file contains unsupported disk format value and error 
message will be reported when import it into ESXi.

Signed-off-by: Mou Chengshu(Ben) <chengshu.mou@siemens.com>
---
 meta/classes/imagetypes_vm.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka Aug. 23, 2024, 6:13 a.m. UTC | #1
On 23.08.24 04:23, Mou Chengshu(Ben) wrote:
> fix: unsupported value of disk format in ovf
> 

Almost: duplicate subject line.

> Currently, Isar doesn't assign the variable 'VMDK_SUBFORMAT' into ovf template 
> that causes generated ovf file contains unsupported disk format value and error 
> message will be reported when import it into ESXi.
> 

That's perfect!

Jan

> Signed-off-by: Mou Chengshu(Ben) <chengshu.mou@siemens.com>
> ---
>  meta/classes/imagetypes_vm.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/imagetypes_vm.bbclass b/meta/classes/imagetypes_vm.bbclass
> index 56410de9..4da42447 100644
> --- a/meta/classes/imagetypes_vm.bbclass
> +++ b/meta/classes/imagetypes_vm.bbclass
> @@ -60,7 +60,7 @@ macgen() {
>  
>  OVA_VARS = "OVA_NAME OVA_MEMORY OVA_NUMBER_OF_CPU OVA_VRAM \
>              OVA_FIRMWARE OVA_ACPI OVA_3D_ACCEL \
> -            OVA_SHA_ALG VIRTUAL_MACHINE_IMAGE_FILE"
> +            OVA_SHA_ALG VIRTUAL_MACHINE_IMAGE_FILE VMDK_SUBFORMAT"
>  
>  IMAGE_TEMPLATE_FILES:ova = "${OVF_TEMPLATE_FILE}"
>  IMAGE_TEMPLATE_VARS:ova = "${OVA_VARS}"

Patch

diff --git a/meta/classes/imagetypes_vm.bbclass b/meta/classes/imagetypes_vm.bbclass
index 56410de9..4da42447 100644
--- a/meta/classes/imagetypes_vm.bbclass
+++ b/meta/classes/imagetypes_vm.bbclass
@@ -60,7 +60,7 @@  macgen() {
 
 OVA_VARS = "OVA_NAME OVA_MEMORY OVA_NUMBER_OF_CPU OVA_VRAM \
             OVA_FIRMWARE OVA_ACPI OVA_3D_ACCEL \
-            OVA_SHA_ALG VIRTUAL_MACHINE_IMAGE_FILE"
+            OVA_SHA_ALG VIRTUAL_MACHINE_IMAGE_FILE VMDK_SUBFORMAT"
 
 IMAGE_TEMPLATE_FILES:ova = "${OVF_TEMPLATE_FILE}"
 IMAGE_TEMPLATE_VARS:ova = "${OVA_VARS}"