From patchwork Fri Apr 11 10:16:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Clara Kowalsky X-Patchwork-Id: 4163 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 11 Apr 2025 12:16:14 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-ed1-f64.google.com (mail-ed1-f64.google.com [209.85.208.64]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 53BAGDvU017089 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 11 Apr 2025 12:16:13 +0200 Received: by mail-ed1-f64.google.com with SMTP id 4fb4d7f45d1cf-5e5bde483cdsf1575321a12.1 for ; Fri, 11 Apr 2025 03:16:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1744366568; cv=pass; d=google.com; s=arc-20240605; b=QdtnISsCfCmBf6YrpwHCujoAoI7mBxudP3eEFOIJNdwyBqY05BNVbvLMTmGzkD3wLj kX5rjywvRwxBGfXHyjdIxKFz+bO6YbwQsRF6YzQ8kY/jeSovhlXz2Zugen3UneXimqBi gJf3556wX6hJUeKU79TZ0+tsD9p88XejD7BmdJZ5dhqb/tEw3FkyROSC/nw07nSJudrf Z5hduW09LP7sjxOZKzXnmgYvHw5AExmAHtdwT6sorS7Mtdfgfshrk8tP+w6mMcIdytWh vE+U+Pi7or7D0llVJJPzD/klklUL75KyTSLs7L3mxYfsut04zjA2g3AlfsdEhKS+xy2P o8PA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FCwvEVz0viSmvXyxj4Drt/GCPkCvIQJ+/Pj907Te2GI=; fh=33KPr0SwRY+frKcN9xAUu8eEyytFZFrSog8qW2M8Hfs=; b=LJe2Q4VcdtekJfVI4ONv/t1rcoAPvdIcJXWy3p7zrAZL3g0slpSGl79D5p4E74P1ka 3cmSAy4B1y+sOeVAOOWN+5fb33CWN/qjZutcMdvI7OBODK8w8r496lkGe/L4p3we25NG FEttSKHnqHAufGe/EY5t35Ad2MUUdGbpb+2yh4u8tBFvgrcccH0I6Jc6MoDZv2L21ryO Z/mIUhIK84e4V7cvdLGzTzbjlnIBQyDqfUXSApjNNV4ASdQiZIu2nZ0n3XNINkYtKXTI fIU3F8qsi7l5T7Y+KND4L6n87j4voSTf6Sv2HbMdAp0+KIJE1UQYsXZkH84wXk5VFVFE dapQ==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=ZZ1X4hSs; spf=pass (google.com: domain of fm-1047747-20250411101604c5edb4877f23eca51a-crnfpe@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1047747-20250411101604c5edb4877f23eca51a-cRnFpe@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1744366568; x=1744971368; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=FCwvEVz0viSmvXyxj4Drt/GCPkCvIQJ+/Pj907Te2GI=; b=vWMEy62ZGeP/sRFpfwezNFX5ud8vMT6Fw9lFgRpUWrPMaJgIoXdvX/GEHq+/Kkk7Wl M9DAbLhZqxSNjOdsPQf73dTVhLMdUHwXLrlH4ByVjH8txH3Z9Bvnk6E2uKB1AceDycSw 7GRUeZaQqzg9Uvw1RIFOFleekrzu89U9qlC49rNJUt0nvxP7vNLT14i5e6xTZoaLg8mv 0dL2813lmtUE+7T3EV9yTI8quHscO3vp9hinmrbotqMvvMGbWCvw4Ed5i1zXFuJmvc+a pY3qt5W/Ik56QpxJmEdz1NaTmLlWz7mHeYlONp7S3jN9/CMw93Lneph9lukIZq1Fluev Savw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744366568; x=1744971368; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FCwvEVz0viSmvXyxj4Drt/GCPkCvIQJ+/Pj907Te2GI=; b=kFZp0dTeDS21OM+RIt/ozpAv0Au96Ch1RjQRTSTY3euPdsGvYQwuaeACboYS2vKP75 YRMW++xEFBSX7qQFhaOZZ4RY6CIf7dEm1aIkCIjCymRI7B4DaZ0hD3dyWQ1RXIWw7lqI CGG6Sfx+ZyajXELnF+PNN0MCSIgjms6H2W1ImNhg+teqadC6dcQMQQH/urz6JLPPA4EH qRyGkXfKRdlhfkxVJastX1yPvTJdrDj4D+LZNBYr9hCGbAWF0lj57V4EcQ2TknbqHZtu 1Fjz2jvB8Fhfnk0ZBqkuhulBeZc20Pn4CqTZq+h732iMu/+/SQn+n+bDB/EcQ78YtvCJ DHOw== X-Forwarded-Encrypted: i=2; AJvYcCXklcH80gIM2UpKQvkiPdtQBhb8XPUogcJwkpNi+qRYw91IN/4azNm2NlENBogpnWPpkhs250s=@isar-build.org X-Gm-Message-State: AOJu0Yx83sCZE3lwqB32mx3LAdLRHTPWp0bU7diSuUrN/LLLvB7J8UOa cHG7h1q9GuaLOm5l5IFG/53dGbgl63KHLYX/EX1uY+65hBd8kTtv X-Google-Smtp-Source: AGHT+IHBH3isD4Ha3pvn3Hfv32Ri/Kpy3ugow15Ry1Qx76ecwxaB1JyInTLdzNywPXfBNCYa10Xnlg== X-Received: by 2002:a05:6402:1d50:b0:5e7:b015:ad42 with SMTP id 4fb4d7f45d1cf-5f370122d57mr1610361a12.28.1744366567119; Fri, 11 Apr 2025 03:16:07 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=ARLLPAJ915fWGbV+6EcdTa6wCCbUprYRNpkcytgDw2ePK1Lv8A== Received: by 2002:a50:8ad4:0:b0:5e7:88ec:e96d with SMTP id 4fb4d7f45d1cf-5f32763e725ls31816a12.2.-pod-prod-05-eu; Fri, 11 Apr 2025 03:16:05 -0700 (PDT) X-Received: by 2002:a05:6402:2805:b0:5dc:74fd:abf1 with SMTP id 4fb4d7f45d1cf-5f36f781311mr1387549a12.15.1744366564662; Fri, 11 Apr 2025 03:16:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744366564; cv=none; d=google.com; s=arc-20240605; b=kt1XkLBzXEqHKiA7dgkGmZJdp+H5m3CrMRhHUWM53l9riggqhQRokApdai51xMnt/q EAhxpHraKo6KoUI/Lck6Mujljlw7/LvayQ4t1e7USgV6XMDeGzzdB8ctsoV3h7NAG+58 xL5HuTvlvJB2eE84P0/IJMyrmUBfW0urQVFEd6icuDg022agxrNz2MF/25vnnDEqRblh v1zMEYI66E/f71pp6Qgae0pruHc+zbOvVjT38zNM2Rqk4hBnbe6p+9JiErM/mrABSMP0 OwTOdAKTs6uSIGfAxd/O+95excH+oohsYpemX/OHXLBWqU6zq4bFuXOX54TutWUVGQOX eUnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=e5TRxxsl0B5QgOqc9/ZWiRcjQu4HXQd83AZ6aPyrb78=; fh=Kr2Q6/26e9poP6E+YpRpAziO3b+80h0a3o9NSh1Rj5Y=; b=C/MXrIclrrSn0/2RU+deZYXFbzyk4GGRZJ1LY7r57j+ijQpzEjk3ZM2YqMu/oGIPQC +gCEaxJkKZVngACN8j7wPK0debBaYLyOFwiJWM8rbZL2pR/oMNclOJgEJNVWlanhnKXS hrcF2QcZ5XnbvFlWYZkl87Y97Vj1JY3l5q6PzbCDfzPVTxpfGzFUryWU+LLPiY0/gCUJ Bn7EZ7detOZSsqiha8lVvcOVc12yTwMLz2YtEQcJ5dBP1rRRPfQQC7VOO41pfDUGmTkq /yoHF3L1O3dlwzVxU0LYyqwEOvPQNQIVLOC4oGvv+SfnvWhQbGDYMy7B1IhrE4ohBTFt rzgw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=ZZ1X4hSs; spf=pass (google.com: domain of fm-1047747-20250411101604c5edb4877f23eca51a-crnfpe@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1047747-20250411101604c5edb4877f23eca51a-cRnFpe@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-226.siemens.flowmailer.net (mta-65-226.siemens.flowmailer.net. [185.136.65.226]) by gmr-mx.google.com with ESMTPS id 4fb4d7f45d1cf-5f36ef56d9esi31478a12.2.2025.04.11.03.16.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Apr 2025 03:16:04 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1047747-20250411101604c5edb4877f23eca51a-crnfpe@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) client-ip=185.136.65.226; Received: by mta-65-226.siemens.flowmailer.net with ESMTPSA id 20250411101604c5edb4877f23eca51a for ; Fri, 11 Apr 2025 12:16:04 +0200 X-Patchwork-Original-From: "'Clara Kowalsky' via isar-users" From: Clara Kowalsky To: isar-users@googlegroups.com Cc: adriaan.schmidt@siemens.com, felix.moessbauer@siemens.com, Clara Kowalsky Subject: [RFC PATCH v2] fix: rebuild rootfs on change of USERS Date: Fri, 11 Apr 2025 12:16:02 +0200 Message-ID: <20250411101602.1656234-1-clara.kowalsky@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1047747:519-21489:flowmailer X-Original-Sender: clara.kowalsky@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=ZZ1X4hSs; spf=pass (google.com: domain of fm-1047747-20250411101604c5edb4877f23eca51a-crnfpe@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1047747-20250411101604c5edb4877f23eca51a-cRnFpe@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Clara Kowalsky Reply-To: Clara Kowalsky Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= In case a change to the Isar created users is done, this currently only re-triggers the do_rootfs_postprocess task. This task changes the rootfs (e.g. home dirs are moved) and by that needs to operate on a clean one. Otherwise old homedirs might still remain in the final rootfs or move operations are not possible. We fix this by ensuring that the do_rootfs_install task is executed whenever a change to USERS is done. By that, we enter the do_rootfs_postinstall with a clean rootfs. Signed-off-by: Clara Kowalsky --- meta/classes/image-account-extension.bbclass | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/meta/classes/image-account-extension.bbclass b/meta/classes/image-account-extension.bbclass index ea956cd5..1c664be0 100644 --- a/meta/classes/image-account-extension.bbclass +++ b/meta/classes/image-account-extension.bbclass @@ -11,11 +11,11 @@ GROUPS ??= "" python() { for entry in (d.getVar("GROUPS") or "").split(): group_entry = "GROUP_{}".format(entry) - d.appendVarFlag("image_postprocess_accounts", "vardeps", " {}".format(group_entry)) + d.appendVarFlag("image_postprocess_groups", "vardeps", " {}".format(group_entry)) for entry in (d.getVar("USERS") or "").split(): user_entry = "USER_{}".format(entry) - d.appendVarFlag("image_postprocess_accounts", "vardeps", " {}".format(user_entry)) + d.appendVarFlag("image_postprocess_users", "vardeps", " {}".format(user_entry)) } def image_create_groups(d: "DataSmart") -> None: @@ -137,10 +137,14 @@ def image_create_users(d: "DataSmart") -> None: if "force-passwd-change" in flags: bb.process.run([*chroot, "/usr/bin/passwd", "--expire", entry]) +ROOTFS_POSTPROCESS_COMMAND += "image_postprocess_groups" +ROOTFS_INSTALL_COMMAND += "image_postprocess_users" +image_postprocess_groups[vardeps] += "GROUPS" +image_postprocess_users[vardeps] += "USERS" -ROOTFS_POSTPROCESS_COMMAND += "image_postprocess_accounts" -image_postprocess_accounts[vardeps] += "USERS GROUPS" -python image_postprocess_accounts() { +python image_postprocess_groups() { image_create_groups(d) +} +python image_postprocess_users() { image_create_users(d) }