From patchwork Wed Aug 20 09:12:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kasturi Shekar X-Patchwork-Id: 4291 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 20 Aug 2025 11:12:53 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-il1-f188.google.com (mail-il1-f188.google.com [209.85.166.188]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 57K9CqUe028135 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Aug 2025 11:12:53 +0200 Received: by mail-il1-f188.google.com with SMTP id e9e14a558f8ab-3e5700a3d43sf178383605ab.3 for ; Wed, 20 Aug 2025 02:12:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1755681167; cv=pass; d=google.com; s=arc-20240605; b=PuXc4VuwJY4mEoAReKihaBJB57XETG4HbC94+c6gFTu0JO9N23JgxGBoCUqEIPpVun l5gxAOexmiofB/sQdGv0EiiKSE01Dha9/uqsbKvyuvbpFAYzl+DtN6vzSrylU+dsLLw7 8a29jUreT0vSidBF9fh4Sn3ZUtrZrRFK8N9u+d71+u1Nci8piT3V4RQT0j0dqwy2HbzP G36pLEojJaS1iWOsjUqCJ3sHtOdlcgQB2n9+cvIN/eqkjbjAozHRxUIP/PncZC7AzJYL hjS2eyJWfn9essn45NLEgvajMVfGBlNNB1eKQvV8absD/iGbUNOmcFutRkTjHOIBjWQN 2WLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tIuSReNWXD6R8kS/nZL4rT9UCi4q5KXvbjk/zhdHZjI=; fh=xnqUTmvgBVafA0aNnA0Xf5uLpdsUZFW6EiB1eb5DLNw=; b=ae1ZNXy5JwTBLrIA6Uvoi/BF2/y1SMjpXWqzEDlI/3iUE5FBgMwIscZ8q1JbMpMOfq EjoUgAhe/4IHrate+aYhfaFvWOXz2EE5WRLzimytrJEGoP+6pB69MqiY5Gq/q33tSJun /LuoASTz1DcXl7vAXvcAlXvHMe1cCHqUhmb6koUw7b32/20V+OEzwsMvw00AXYslRUAR TNH0dFp8hDLpS3Ca+Wldia2WhBsZT+T+T4cUBv5Hx6F3rk7rthOYDQYyPq5EbloKQ25N J+KyYQPxL5+QQTDcBFtH2xmTPkWkFL7O5MSO4F+jy7hl9tTePllzp7g+v3uWJx6XjdXe D1EQ==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=BNjTP44T; spf=pass (google.com: domain of fm-1328757-2025082009124420ab9752d07a067425-2kmdeb@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-2025082009124420ab9752d07a067425-2KmDeb@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1755681167; x=1756285967; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=tIuSReNWXD6R8kS/nZL4rT9UCi4q5KXvbjk/zhdHZjI=; b=tIudlFsJfXPVIo2E9L52LqPeq8hCHO8ZZfAgv6u+Jh/oml6BZtIugAATyeDsKTyvzy yVP11wNrR17FQYdqYqjd+2raWQsosWxaPEKiNFcydlsBqD5Zh9QChkKOKPd8k8Dx1qQb 45qUfl3Nyv73Zo4R+hYU32u5Xqv4jeYz/9K8Q1lWdGutP03dBWi4ptc3UKswrJMQGGwD pGCLpXsvbIXb0Ecig9zopZLKM5px9b5wzC7dymUa3+G8PTAKPY27BL9OKE6CF0XXsqq6 /fQpqtcz0SDYYq1LkEw2B/dVkNBFcfuf9K8F7jWtsivDyITMAp1MhLV6pcN/nqYRQ47C 11/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755681167; x=1756285967; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tIuSReNWXD6R8kS/nZL4rT9UCi4q5KXvbjk/zhdHZjI=; b=hZr0iegWlM2L7NUAdOBRu6C13q2GEr58xbjkCXHvykUiyL86NEZPb53uQ10tKiBs1J JBddhxwXIDNUFGbdGSwujWXnYwjaNK47kvd1rx6Co0C8cRepeQ6brSYAyYGUwDdqQPAF bIwBJa41HtzSaedNQdoDGsOwVvRi5OFGPv/1YBqAhCY2nnAW40UnPgdZMIpog7mPDOau bIuSRUENoVETVnXF2W6EMa3e0SNsNrRdxahfQekZdut0Hp5Ej4tXihvl5tiGqNwzu+vE iJ2LNFMJlJ1/EyyPI3+uuvOoH02iw7h8hufmGj13ayCGFoTse8OxdbRMqRawH4zmy5cr u46Q== X-Forwarded-Encrypted: i=2; AJvYcCVj+iCJlgFGCQu5tbSF16Gn/5OjyESZSfKjR+86aE4+g7KkmW9UadNYr2DnR6o8crePJqto1HM=@isar-build.org X-Gm-Message-State: AOJu0YyjrrNdUX9/UjqDa26HSWK4bif5L7ArmBD2p5AeR8w30B2liOxS wywUdxJ8zhT8cY751RY4eFniVO/Lx7m5rTtttd6KBJLXhUjU7gf12t20 X-Google-Smtp-Source: AGHT+IH2BTmOdJky26Ldpd1JoX5QCZ1oFp+ZkFuYN/dwHNIHk/viKlzAkLgggRhT/cvxa/VQhQdVQA== X-Received: by 2002:a05:6e02:1a68:b0:3e5:8249:e973 with SMTP id e9e14a558f8ab-3e67ca21815mr37933175ab.16.1755681166791; Wed, 20 Aug 2025 02:12:46 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=AZMbMZe0V5W2efSpaWdKq8CRJi7CTK8CRdsQF/7UiaUKlP23lQ== Received: by 2002:a05:6e02:2504:b0:3e5:50da:c386 with SMTP id e9e14a558f8ab-3e679475fa2ls14700175ab.2.-pod-prod-05-us; Wed, 20 Aug 2025 02:12:46 -0700 (PDT) X-Received: by 2002:a05:6e02:188a:b0:3e5:7e57:d094 with SMTP id e9e14a558f8ab-3e67ca08fcfmr34386225ab.14.1755681165906; Wed, 20 Aug 2025 02:12:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1755681165; cv=none; d=google.com; s=arc-20240605; b=LmMPSYHqlfDxtYBvrxxUXdH8h7tyoJrGJfEVWMeu/VQsFhfjNXlPtgWC9bXFV+Pmqs X/l0zeq6SHaajs/ggaNoBorbiAMM2F5mq61YMFZtLJ6rNanyyLwYd5+tqQLz/FUkvEn+ QemlHadMRJSf5lTzBDkEsyIhfOmTZpSCSOG2We9snNsDI4nOCo9ICOujRUXyHERnd+yM ZD1n1cCvzJCE/ZSvkf+MMfea+BJ2/JPWX5wvhlHLlbrS+/myOvqVHPjS1Sz5Vcqwztpj Pgg5LOf65w4K9o+G3k8n+h97PzX/OomVxTg5VKqVgVO2dzneINetPC2M1MOfj40Ibh3+ rARA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=GB7+7LJ1yfg0BtVjmAF5lJYH8Tb4z5+/91QAQnxC0ic=; fh=pR4tJPO4NbHlIB/rP4bIo54Z1zh5hd/ksAGQ0tcKkYM=; b=ceLpOt4eyEoBo1RJvpD5hb6TVR35w1k6KxbhHYY6qu1jwf7lsjU957syTmdmSIn5ic dDciFlrO4WA7kXlq42qVDOaLk4Ekl5LgIpSAwoAQiPgJB4ylzEGo0dVOObre8b02NhCj azZjOx4RDnjZBzbRNS1BFUAz+EXS+GEWV5Yk9LK9/TRS0DTaBmez0qWfXfojdOEr0PLV lZpW5mv5uqeEuZKilomLZd2atilksVa526xo49EFV2J2Nhu6BHJnGmTH5QzSJ1wzf+Dl GofY3zXi8JLCu2FiIkpjnvrNnyn/pPiEwwDihyA7tQ0pZFy3NzFWLEXpty1O9c84vLNP fP0A==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=BNjTP44T; spf=pass (google.com: domain of fm-1328757-2025082009124420ab9752d07a067425-2kmdeb@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-2025082009124420ab9752d07a067425-2KmDeb@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-226.siemens.flowmailer.net (mta-64-226.siemens.flowmailer.net. [185.136.64.226]) by gmr-mx.google.com with ESMTPS id e9e14a558f8ab-3e6789e74besi1424385ab.3.2025.08.20.02.12.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Aug 2025 02:12:45 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1328757-2025082009124420ab9752d07a067425-2kmdeb@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) client-ip=185.136.64.226; Received: by mta-64-226.siemens.flowmailer.net with ESMTPSA id 2025082009124420ab9752d07a067425 for ; Wed, 20 Aug 2025 11:12:44 +0200 X-Patchwork-Original-From: "'Kasturi Shekar' via isar-users" From: Kasturi Shekar To: isar-users@googlegroups.com Cc: Kasturi Shekar Subject: [PATCH 1/2 v3] fix premature success dialog in installer script Date: Wed, 20 Aug 2025 14:42:31 +0530 Message-Id: <20250820091232.41738-1-kasturi.shekar@siemens.com> In-Reply-To: References: MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1328757:519-21489:flowmailer X-Original-Sender: kasturi.shekar@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=BNjTP44T; spf=pass (google.com: domain of fm-1328757-2025082009124420ab9752d07a067425-2kmdeb@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-2025082009124420ab9752d07a067425-2KmDeb@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Kasturi Shekar Reply-To: Kasturi Shekar Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The 'Installation successful' message was displayed before the progress bar completed. Fixed by tracking the dialog --gauge PID and terminating it after bmaptool finishes. This ensures the progress bar runs to 100% before showing the final message. Changes: - Tracked the PID of the dialog --gauge process. - Killed gauge process after bmaptool completed. - Ensured success message is shown only after the progress bar ends. Signed-off-by: Kasturi Shekar --- .../deploy-image/files/usr/bin/deploy-image-wic.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh index aba81c84..fa1061c1 100755 --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh @@ -183,12 +183,16 @@ if version_ge "$bmap_version" "3.6"; then done ) | dialog --gauge "Flashing image, please wait..." 10 70 0 & + gauge_pid=$! fi if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then + kill "$gauge_pid" exit 1 fi +kill "$gauge_pid" 2>/dev/null + if ! $installer_unattended; then dialog --title "Reboot" \ --msgbox "Installation was successful. System will be rebooted. Please remove the USB stick." 6 60