From patchwork Wed Aug 20 09:20:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kasturi Shekar X-Patchwork-Id: 4293 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 20 Aug 2025 11:21:01 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qk1-f186.google.com (mail-qk1-f186.google.com [209.85.222.186]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 57K9Kxc6028341 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Aug 2025 11:21:00 +0200 Received: by mail-qk1-f186.google.com with SMTP id af79cd13be357-7e864817cb8sf227500885a.0 for ; Wed, 20 Aug 2025 02:21:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1755681654; cv=pass; d=google.com; s=arc-20240605; b=aHCPG5UavFaVlEvLC9xD/xPJ8KzrVR0kkvjcRnFMZHUk46XulcabscvZTaSGk82Ua4 RoTrG0PcYKhwkfLPTeEy7IjqEL+tl8dh5d9oK9XQK4Sa+Y0T8yV+9R0PNjb4EcLZrZy+ S8xycfWhUWqI1Yhs7NJUEscJq4hDYn/p7zSlbsvCsLLLJjKHLtwUSYSG8FzfTNrzZgZo vGBv/piz6hqfGxF/Qg05SU0uDST835/7XfAOMkZ9MoMHA0uszm3mih6lQYy2nDOMelXQ CbqvRAaXN2m49teOZNIOiZYffxSG+pKjlTQDuRxOrbkVZSHlJVZtvDnhNrkQ0tV8HYNK lywg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QB50UCe43fvNxCH3NeeGggRyZhuaSon3XZ+94N7xrNo=; fh=tZQeof6GZFDDMWQVuZ8xTd+hZLqn+gKwHAmPbahaJDo=; b=LKR2sMqlX2GVwb7vGy+h+t/kgzBI8LAeowidulLk11HQuNUAWV42pqqlGsZ7U38HYj yIhORo1uL7+S0GSER/SJgo4aHOagK15295MZebeBSUTQjcsZZPg2HbGcYUX57mvuBf9Y fEBCkSwKcDpYmcciVe5CeQ8xnf2D65jSzBMzXq8/Atb3cmM7cUy/6aQ0jo0/7gLhrNHh 0iU0WamozVKKsMMaMn3692ppMYh1ehI3w+DndCpJ8hMDLS+2LkrtQ0r7yxVPzQUFv16a 9SwUs+k8WUET8hNO8iOfikO43VDODlFoPG2egZhhrvobdD2olUt40LJ3LvcWrKL5ugm9 lBdQ==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b="TQEVslI/"; spf=pass (google.com: domain of fm-1328757-20250820092051040534fbe387663968-6ofe8j@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-1328757-20250820092051040534fbe387663968-6OFE8J@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1755681654; x=1756286454; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=QB50UCe43fvNxCH3NeeGggRyZhuaSon3XZ+94N7xrNo=; b=h8fZT6Mv7KUgwCP8Mvu56X048agLgOQcemutab6km5ORQdS7PcMsrfhedUobFREezs S7peAJu2lN649rmMk8yFyZAgnxVR0+Usv2/opNy9X69n9f08VyUyAYmU1rXt/qQqHCUO PiFVD9jSkS7FZObb978IOqOO+lZSCYnIVkBXt0+BtGaR3TwXNIdY5f6nVRBvmKNriTGQ pzenTExx02MmHB0Q6dxfrSzus+FnTUk2+CTPiFpWnF9fmF19Lw06NtVxFoSCVEaYce4B 1AIizXAojvo0yYZ9SLOO2GRPkmTmNxFn3kRkWp+iuHQJTmOtodRP0iM+axTWcmtOAofc unzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755681654; x=1756286454; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QB50UCe43fvNxCH3NeeGggRyZhuaSon3XZ+94N7xrNo=; b=bdnM0LeD9/Xo2KNWm8gZeWXGZf7ndE/gFzIiicdMQMc4HEEN+MCA79Q6AX2WjU9kWC SA7YrcFFb/cuIL343wvf1f4qDNAWowEg2GohY0FVdKMR8hTqQ8PUZbWZ3tD2GbZq//04 oyLJp9EVrkmQp9l4pQUoAD0l8mZtqmVqobu5FoqUPkfs3TJLdavttlxHsOJq4PGj8Hhb g3ZICNfxbf9waFcRhgy7WNORrDLo/4mUFWOGm5GS7z0kSByfjlLkRt5HGqF6SBCP4lqH leItjjvYcjbRBkDQimn1XyVwUwPgQ8B4Q3RxFLPwScD+a/vq4qAzqVmZir8/XqedXqGJ dkZg== X-Forwarded-Encrypted: i=2; AJvYcCW8gQ24L65BlmLydcuGsH+Mgmj3VLp9D0ced/2pDLOAoVpHZuZxiKgw/i2c8tr98b2wroQiluA=@isar-build.org X-Gm-Message-State: AOJu0Yw/c1VQ+byPGX2GFTVIIKeoIYeCJl0/jko/0ID1TR5cfzXj2Qbs 79KbMkfi98UAJl3/WUq9BLziobEIyruOse9Iz1sehncLEqxwhMSUZwLb X-Google-Smtp-Source: AGHT+IHwvL6oNEt+sbK9StHb/uBJ9LbL+4fpArF5qHfre8AFBBabYslYfp3j4QjEuoqFdylnDh7vGg== X-Received: by 2002:a05:620a:2954:b0:7e7:1fd7:ee9d with SMTP id af79cd13be357-7e9fc7f85acmr240155785a.29.1755681653982; Wed, 20 Aug 2025 02:20:53 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=AZMbMZecHk+dJcJ3HA2jpDcaduIylsjyPtbX+j7Yv5chiA15lw== Received: by 2002:a05:6214:2349:b0:707:5acb:366c with SMTP id 6a1803df08f44-70d75bd3748ls5657316d6.2.-pod-prod-00-us; Wed, 20 Aug 2025 02:20:53 -0700 (PDT) X-Received: by 2002:ad4:5d6d:0:b0:70b:be12:f4d2 with SMTP id 6a1803df08f44-70d75f32f47mr22460676d6.22.1755681652981; Wed, 20 Aug 2025 02:20:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1755681652; cv=none; d=google.com; s=arc-20240605; b=kNcUCAlDaODBo+X09HETznNKfblFfjQSk5RW1mP0wq2HUqXTKWyXNi9vZz2WNNgzFC iH9GJq3fGWnq9mwi+Wo89NtFZZsilmk7aES0kOGohvL0lhUYoOi4hTmdgejNbt/Impob CBRHB4q34gATRxKXq6JpeZrAti+OLp2KUYknPin3PCMpaj+7G1AyPGJplbqpeu+Ts3J7 Grn8YzQxODTqikgDtkJV8awgN8YCgv4ex/LdHpqTuGurtaDjZxtGxowQOTLoaFTgTb8V H3dzWtcnvPSuHfTVpoHwHfzCQMuDoIJ0e6ccApTeUW7Fy/2tqgv87N4ZUngSh1U6YeFm EZsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=GB7+7LJ1yfg0BtVjmAF5lJYH8Tb4z5+/91QAQnxC0ic=; fh=pR4tJPO4NbHlIB/rP4bIo54Z1zh5hd/ksAGQ0tcKkYM=; b=HON797ED304K7BBb744l3TJQvd6doD1C4YK42f7wU4MGbCOHLJ++gb/3EiAZUDnesz wiPbCo1HqHPhz8XcInuQmBx9I0Q9cHVzBt+/CwbHLCHWCAO3Im3lQG4RvUtqbDnr+SJT QcBcMbrhBTmH1kNKSDnkEfV+p3YiGfAfQavdDR/ytZ+2//AMEH2CLNQ4Gf+BDf44xsWg HmcEblvkPb3kmbpeF5w18Rib8VGDHxnfSH9OUefI+AATu/a4KUymhcUHf70SYJIKIzLd CEj4XcBsjrN0JJMCFq8JZDoEjr8g1qTP+E922bvBqKJ9QYWu4Y0+UuO2tCQesBiXdzlX NQWQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b="TQEVslI/"; spf=pass (google.com: domain of fm-1328757-20250820092051040534fbe387663968-6ofe8j@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-1328757-20250820092051040534fbe387663968-6OFE8J@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-227.siemens.flowmailer.net (mta-65-227.siemens.flowmailer.net. [185.136.65.227]) by gmr-mx.google.com with ESMTPS id 6a1803df08f44-70ba902a306si6453856d6.1.2025.08.20.02.20.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Aug 2025 02:20:52 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1328757-20250820092051040534fbe387663968-6ofe8j@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) client-ip=185.136.65.227; Received: by mta-65-227.siemens.flowmailer.net with ESMTPSA id 20250820092051040534fbe387663968 for ; Wed, 20 Aug 2025 11:20:51 +0200 X-Patchwork-Original-From: "'Kasturi Shekar' via isar-users" From: Kasturi Shekar To: isar-users@googlegroups.com Cc: Kasturi Shekar Subject: [PATCH 1/2 v3] fix premature success dialog in installer script Date: Wed, 20 Aug 2025 14:50:40 +0530 Message-Id: <20250820092041.41798-1-kasturi.shekar@siemens.com> In-Reply-To: References: MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1328757:519-21489:flowmailer X-Original-Sender: kasturi.shekar@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b="TQEVslI/"; spf=pass (google.com: domain of fm-1328757-20250820092051040534fbe387663968-6ofe8j@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-1328757-20250820092051040534fbe387663968-6OFE8J@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Kasturi Shekar Reply-To: Kasturi Shekar Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The 'Installation successful' message was displayed before the progress bar completed. Fixed by tracking the dialog --gauge PID and terminating it after bmaptool finishes. This ensures the progress bar runs to 100% before showing the final message. Changes: - Tracked the PID of the dialog --gauge process. - Killed gauge process after bmaptool completed. - Ensured success message is shown only after the progress bar ends. Signed-off-by: Kasturi Shekar --- .../deploy-image/files/usr/bin/deploy-image-wic.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh index aba81c84..fa1061c1 100755 --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh @@ -183,12 +183,16 @@ if version_ge "$bmap_version" "3.6"; then done ) | dialog --gauge "Flashing image, please wait..." 10 70 0 & + gauge_pid=$! fi if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then + kill "$gauge_pid" exit 1 fi +kill "$gauge_pid" 2>/dev/null + if ! $installer_unattended; then dialog --title "Reboot" \ --msgbox "Installation was successful. System will be rebooted. Please remove the USB stick." 6 60