From patchwork Wed Aug 20 09:34:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kasturi Shekar X-Patchwork-Id: 4295 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 20 Aug 2025 11:34:42 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-pj1-f63.google.com (mail-pj1-f63.google.com [209.85.216.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 57K9YeUk028542 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Aug 2025 11:34:41 +0200 Received: by mail-pj1-f63.google.com with SMTP id 98e67ed59e1d1-32326e72dfbsf11912423a91.3 for ; Wed, 20 Aug 2025 02:34:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1755682474; cv=pass; d=google.com; s=arc-20240605; b=OdeKlT64XY7+Ej/G+vqz8Cl8nCMlp+sj0qp5tWC/uOrR4LzluEjmEIUFE0CeI6b7QR vk7bvvP0khIidMVmyBBUc04LVCikFzKxDr8Kp7lfQ9pftEEAQ77x8Kk0ljERH+3ZlAYC dilTG1hL4Bbn64ktLQ7yBg0KS1Vb9jMSc/JWswGttPJvWFtv9Z4eXYRv5pjixjD4w8Pb L7o2bsonTMEsLNObDKARS4IjOvY+uD2g5mvT/eNzxS5lEf61vKapKKrgHTZu664EHQoh X1LgickmVXbsRVB3XRloRlprWlNPzdBGA450qrG7Ay3R2/CZqIDoWtAZ/tNORftsS56U 7nBA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ExU4bZqfVRanKHn2YRW/PgGtg94N5Xmaj10LZZbktUg=; fh=9SK+S9ccBnRbClbyo72tmST8TOaUajtOx1MRZrBdu+I=; b=K1fuUZGKJbepJwXF/I8FbrbvNBlmvSyahpCCyBdDsqPz/+OKvtHZzCN/42yITfunSR wVIPOZ8SvEq0ggaSFUT0g8D4AgYx3S6N47nzELJf8x9f6k/FOgjXDHGbWCAySCjhijwk a+eZhx6oQCs26v5RbyV4zwx976D38NDZYcGdD0+vpPXFcuNIBtLkwkoBqRaV4kI+ZUzF ocSb/fskpnzCCnymId+1vubB9/blBYUGJyZ0ZUmIfzwM3Bqi0Rn+6yOkkSmxDu6FJ/FY ALifRa3rYxwEaZrx+oOvmenMS+Crmm1xP6HL3yua4ZMf2rZvVTb0Q7eFhqvyv6In9g7E IpJA==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=OEP2Q0rg; spf=pass (google.com: domain of fm-1328757-20250820093430e527db47e196bf4654-n_hu0x@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-20250820093430e527db47e196bf4654-N_hU0X@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1755682474; x=1756287274; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ExU4bZqfVRanKHn2YRW/PgGtg94N5Xmaj10LZZbktUg=; b=GJ4F9Y3Ji4+VEQCeM0Dw+w+RAZVtZcJbfE/CVeuqJUPXMs5ogEt5ir2Ef6ft1ZbgGh fjMFgJfXO3vXkHPQCMyqhW9vNdsUJA3rCJtPC7kGk3yTd1rgTm6G+j8tTkwzhnTZ1GhS LKrUfc5QCUdnqlmlqRO8rfugJyPNRfXfnrSMUhZ/GVLncFGWLjvkUGg1PYR8U1bo32LJ +OVmcIMw6dpPHQPsMlOoI+6exqq4ERYPHCkeCNWKnXee52l50Xsvcylu7lDHlBXbg5xq R+nlZlQNFUoTf+VVeE6TcwOLN2uxdfMC1X1jRgSZhtrzD52t+TcvEug0EgSBMJ1evFnm yrTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755682474; x=1756287274; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ExU4bZqfVRanKHn2YRW/PgGtg94N5Xmaj10LZZbktUg=; b=aAPQslSy9ClDHY+XCQqaBK7u8uQ/v7JNkGnhtdG1zZaJWtgwlJyhDQ9JBuhCzwDebH QR5YkF0/qiMGaMjdOTZfUmOHdW8tENwrlPJgtSGnAi/U1PWcurij7pcOh8QdXx6CQc19 oFDmz52XUNLmqYF3wZ82/kcUFu3P1WR4iNi99SRqhZwCRuf5SFaTWQWvLbJdHcGqacix DVjJgN0FFcPQ3obh48QmpgZ/cNaxG1yL6TAT4pVs4i5oNwXJ2O0z0ErhZnzamGCbXsMS isWkzLgb8ByyPA883Hu2/ezV2xz6yDUvLW1KRP/dxVRDuoYXyCaNpR124cIQ/zDAPoDV 0J2g== X-Forwarded-Encrypted: i=2; AJvYcCXE+VjpYWhKcYpylrsdvkdimRo9QCEWPyPZAqy7rxasfvx6BUcLL/3rnN4/YAg+2zSsxw/32nc=@isar-build.org X-Gm-Message-State: AOJu0YyrUueieKw3gKy21ADZhrOBG3CiwlzduX1EqZ6t9dJRmcCCm0Gy OcfKxs4FMBxVffb+was0s0oC4HHbJaBxJFBZBdFl54MbvatWShetC+9z X-Google-Smtp-Source: AGHT+IETFl6XRdJiJ3UM1zSW1pstmhMsycHws9cQurfMpsgguspRbviB3JEhZ0a9EIlsWQcVXxqqVg== X-Received: by 2002:a17:90b:530f:b0:31f:22f:a221 with SMTP id 98e67ed59e1d1-324e1429959mr2797627a91.29.1755682474473; Wed, 20 Aug 2025 02:34:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=AZMbMZeGTRwxXEjOu0nWos0lHM9fl1C8oJ0lij5GIYKgc7UnuQ== Received: by 2002:a17:90b:4b10:b0:311:d132:6573 with SMTP id 98e67ed59e1d1-32326661a36ls7869210a91.1.-pod-prod-08-us; Wed, 20 Aug 2025 02:34:33 -0700 (PDT) X-Received: by 2002:a17:90b:558c:b0:31f:11d6:cea0 with SMTP id 98e67ed59e1d1-324e142993emr3038244a91.27.1755682473082; Wed, 20 Aug 2025 02:34:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1755682473; cv=none; d=google.com; s=arc-20240605; b=BWE5AKLxuvKY5l23T8o6ui3KRVZ/Uebg3FemxPw9M6YkeFoxIjrgn+3VqXWuzTDRvE kOu87jXcfKxocTVKXi0peVdtf5vXERSunJBDP/e8cCfta7zWRb2NP7lIKCERvFuaQoFQ Ks0mYygsFxxYfGxW1+eDQFPBvSrwE0qRiPuRl+kp/SYbm9qChxUp7XnaXCU7EwdiBCGB Xu8ZBjcYeBasrXKtvjGZ8ACNIEDI9s+lurq2WIZIVecahqjD6WZF8DYPUowud4zNAFbK IB33n9VEudlQG3il5l9WAJ2PiDgHc8Z3lELBeFZBgwdYYLMca1pvnq8XiF/JRZsm3biX p5Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=GB7+7LJ1yfg0BtVjmAF5lJYH8Tb4z5+/91QAQnxC0ic=; fh=pR4tJPO4NbHlIB/rP4bIo54Z1zh5hd/ksAGQ0tcKkYM=; b=ca4qPltWy3B0HwYuRa42beaisxppFbqbo5xBZFgJEPwu2+VJM1uEWRA3zLzT5LZlgH q+jiM6Nco0nL89qePQYZwLvt+6uzHMXdOeJfm+UycPvwBzCflr6s+35kxzldMWYVPcC+ eixox+CtWnZLo90Tbib1LFCKoaGjL8w6ZR+S0kaOU8H9HkrFHkO3Dlj3LUS+cYV4vP9v TuodbYaGdFhberh43ZNyIhBhWV4ZohHV4qLGQOW6pYyfaQpjoZlJwGfEknNLr3QyVN6r bVI64LSYTaPkMjQmBd80YFNPS7HqoZJVKUP+LU4/lp/eDFiNFBYfWxKRkp6xPHWRSOIL HtTg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=OEP2Q0rg; spf=pass (google.com: domain of fm-1328757-20250820093430e527db47e196bf4654-n_hu0x@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-20250820093430e527db47e196bf4654-N_hU0X@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-226.siemens.flowmailer.net (mta-64-226.siemens.flowmailer.net. [185.136.64.226]) by gmr-mx.google.com with ESMTPS id 98e67ed59e1d1-324e2563a49si61623a91.3.2025.08.20.02.34.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Aug 2025 02:34:32 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1328757-20250820093430e527db47e196bf4654-n_hu0x@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) client-ip=185.136.64.226; Received: by mta-64-226.siemens.flowmailer.net with ESMTPSA id 20250820093430e527db47e196bf4654 for ; Wed, 20 Aug 2025 11:34:30 +0200 X-Patchwork-Original-From: "'Kasturi Shekar' via isar-users" From: Kasturi Shekar To: isar-users@googlegroups.com Cc: Kasturi Shekar Subject: [PATCH 1/2 v3] fix premature success dialog in installer script Date: Wed, 20 Aug 2025 15:04:16 +0530 Message-Id: <20250820093417.41825-1-kasturi.shekar@siemens.com> In-Reply-To: <20250806055438.3318548-1-kasturi.shekar@siemens.com> References: <20250806055438.3318548-1-kasturi.shekar@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1328757:519-21489:flowmailer X-Original-Sender: kasturi.shekar@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=OEP2Q0rg; spf=pass (google.com: domain of fm-1328757-20250820093430e527db47e196bf4654-n_hu0x@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-20250820093430e527db47e196bf4654-N_hU0X@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Kasturi Shekar Reply-To: Kasturi Shekar Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The 'Installation successful' message was displayed before the progress bar completed. Fixed by tracking the dialog --gauge PID and terminating it after bmaptool finishes. This ensures the progress bar runs to 100% before showing the final message. Changes: - Tracked the PID of the dialog --gauge process. - Killed gauge process after bmaptool completed. - Ensured success message is shown only after the progress bar ends. Signed-off-by: Kasturi Shekar --- .../deploy-image/files/usr/bin/deploy-image-wic.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh index aba81c84..fa1061c1 100755 --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh @@ -183,12 +183,16 @@ if version_ge "$bmap_version" "3.6"; then done ) | dialog --gauge "Flashing image, please wait..." 10 70 0 & + gauge_pid=$! fi if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then + kill "$gauge_pid" exit 1 fi +kill "$gauge_pid" 2>/dev/null + if ! $installer_unattended; then dialog --title "Reboot" \ --msgbox "Installation was successful. System will be rebooted. Please remove the USB stick." 6 60