[RFC,1/5] enable-fsck: remove dependency to initramfs-tools

Message ID 20250905113014.2765493-2-Quirin.Gylstorff@siemens.com
State New
Headers show
Series Add support for dracut | expand

Commit Message

Quirin Gylstorff Sept. 5, 2025, 11:27 a.m. UTC
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>

The packages doesn't use any artifacts provided by initramfs-tools.

Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
 meta/recipes-support/enable-fsck/enable-fsck_0.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka Sept. 5, 2025, 12:25 p.m. UTC | #1
On 05.09.25 13:27, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> The packages doesn't use any artifacts provided by initramfs-tools.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>  meta/recipes-support/enable-fsck/enable-fsck_0.2.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
> index 2d0ec950..8a11990f 100644
> --- a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
> +++ b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb

Recipe revision bump?

> @@ -9,7 +9,7 @@ inherit dpkg-raw
>  
>  DESCRIPTION = "This service enables fsck on first boot"
>  
> -DEBIAN_DEPENDS = "systemd, sed, mount, initramfs-tools"
> +DEBIAN_DEPENDS = "systemd, sed, mount"

I have no idea anymore why I once added that dependency... Makes no
sense, indeed.

>  
>  SRC_URI = " \
>      file://enable-fsck.service \

Jan
Jan Kiszka Sept. 5, 2025, 12:38 p.m. UTC | #2
On 05.09.25 14:25, 'Jan Kiszka' via isar-users wrote:
> On 05.09.25 13:27, Quirin Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> The packages doesn't use any artifacts provided by initramfs-tools.
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>>  meta/recipes-support/enable-fsck/enable-fsck_0.2.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
>> index 2d0ec950..8a11990f 100644
>> --- a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
>> +++ b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
> 
> Recipe revision bump?
> 
>> @@ -9,7 +9,7 @@ inherit dpkg-raw
>>  
>>  DESCRIPTION = "This service enables fsck on first boot"
>>  
>> -DEBIAN_DEPENDS = "systemd, sed, mount, initramfs-tools"
>> +DEBIAN_DEPENDS = "systemd, sed, mount"
> 
> I have no idea anymore why I once added that dependency... Makes no
> sense, indeed.
> 

Now I have: 2377b73d8f060bb03bed970853fc47a7197b7789 broke enable-fsck.
The current form does indeed no longer need the tools - but also has no
meaning anymore.

Jan

Patch

diff --git a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
index 2d0ec950..8a11990f 100644
--- a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
+++ b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
@@ -9,7 +9,7 @@  inherit dpkg-raw
 
 DESCRIPTION = "This service enables fsck on first boot"
 
-DEBIAN_DEPENDS = "systemd, sed, mount, initramfs-tools"
+DEBIAN_DEPENDS = "systemd, sed, mount"
 
 SRC_URI = " \
     file://enable-fsck.service \