From patchwork Mon Sep 22 16:43:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Heinisch, Alexander" X-Patchwork-Id: 4368 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Mon, 22 Sep 2025 18:44:26 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-pl1-f191.google.com (mail-pl1-f191.google.com [209.85.214.191]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 58MGiPOp020563 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 22 Sep 2025 18:44:26 +0200 Received: by mail-pl1-f191.google.com with SMTP id d9443c01a7336-27c62320f16sf428585ad.1 for ; Mon, 22 Sep 2025 09:44:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758559459; cv=pass; d=google.com; s=arc-20240605; b=WQw5eSFX8eJbrQPNfieZTP2S7Dz+c9jClhtsebuUnZ/NrRa3VBiRbohnyMJLb/cyB8 piVC/orm3zvoWI9TxgCrQNb1x/Py1KLYtXMYBQ3LrHgtg4SbAy6U01g5ggjc1mLGNlJi lnY8ilEf6YB1HM2lO2hIs89loCpjD27R+hQPzztMARa0ei+VkQPQCOBC3qpJjWuYOXGa ZldYqqvlZM9CeSMl8oQleNCy/Ysk7ZnklaDr+smUaJfplEhKDT7unz2H55VbvWCKa8mp hJAT6cKUfghchiCacBGPoQmpatR8YuFUny0EHLqERCFblRvkFSKvc1jxdURuxUmE/WTQ /Niw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PHds/lAU1jP0n9hWpu/lMM0Ifh18sC5820p/VrCwr+8=; fh=XNONAymKbDFYvrPSswqest2aQZ4/NbRPCGI54yZV5Qk=; b=QlHTEmNNsyHZP7ceHpYhrMeKX8HSGkSzPiN4iycdmny4Ku3AgkzrE1CD8amjz7aU2m 2KD/IbC26HE/YQX4jAZEu/OzwuMIucHQSclwD86dR85bE+qhXkqoMqaDyi+e9tZXfaxT tOF2OH0VdnIxbomVHxvC8taS2aXOcKMX20X2CcPXQXZBwG1LkBrayIclzVCTTYPu4RDX 3JmrCecRQzstbr4USWXtfbW/T4T6fj1ZIAErCpzlfOw9FKefbzaq2hwpzW4C45bitbpR q4mfTrGbRIjsNFEjZTQqKTWUs+Knxm8Hfm06grDQhIXEl+m8hxj5nRwrPKFVUqZOFTzG Bs3g==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=qpV45DuD; spf=pass (google.com: domain of fm-1330684-20250922164415bb10e87a1f00020711-uxvrj7@rts-flowmailer.siemens.com designates 185.136.65.228 as permitted sender) smtp.mailfrom=fm-1330684-20250922164415bb10e87a1f00020711-UxVRJ7@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1758559459; x=1759164259; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=PHds/lAU1jP0n9hWpu/lMM0Ifh18sC5820p/VrCwr+8=; b=v5HYICLsmdTHwm3hXjzEL4kVoSdXUiwJnBe33N4C+Q51f+fPYKt29XobwSAuoLziSH cJPBRqFKdBGYheCVVY9/36D5PQ70ilYKkldOFpMUvX08E6cim6udtjI7OM0VqIcEPNKe j22BTp87u4RQ98IGRkhZac9utrOEtndrb0nfnUJCaR/N3Y/4BBc/hqPzPmld14rDkAn+ LD2oQH3BzWQ4Zz0qPA/ntr6UWpdwR/m4opDfDPC3XyXcWTG6qaccMhVuWMK92IHDBiM5 SzbqBO432lO6+mKnySUcnBzH3VVevrPZa/jL3wxgbWEbzEyLkwkj4cVJvz3u/mYriHAW XFcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758559459; x=1759164259; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PHds/lAU1jP0n9hWpu/lMM0Ifh18sC5820p/VrCwr+8=; b=ZExquqkwtrWZM9vOz+kNzI+IE+qkw3lQrSh4klUNJUGpq6Me1f+5gS9y47WwfMknRc 64BeaO0VSAk0NnWiLWBF5JGoSarDLBjJSO+VAiZlNcr+7xSKgRLFm329A5heqfDKrsTS BtnZgxr+JUCKqFtEwf72YtNGJwl7i6F/YhR+lY15B1E47SRvujeq44r69r3QMtaKZd0M ktbSZzpY44RcR3U0A6E+MXhrw6HszNfbC6y5Rr+Vfhm1YOmsvIcWaVFz3pmlRIhbHJZD ol6/3zSLhLTmfDGKQ1+gfovKWECF8DtyOyvs/B2v8cbXEUxzTaTGlEbGmOLZe6Dwy97V wc2Q== X-Forwarded-Encrypted: i=2; AJvYcCVKVsJFbXZc+hjw/cz6IAyBWMt5XvAp4VU1L8dvI/aXj9gv6o/iHFbN68Uc3MpZfFRgfhqvPUI=@isar-build.org X-Gm-Message-State: AOJu0YxD5QseYHPRQiK087BQ6kWunmszQGmk3NY2KuULx3ZW1gWKtK+Z EyfLjjyTkxqGnooDni4SGRAeTeGU/iQNTStyKSZ2vnkN8NaskIuAX9aW X-Google-Smtp-Source: AGHT+IFNTw7vhtwkn3r4Q9fCY132FqV1/dqjpUwIC87gUr9t6IGUHtazD7ihlu212SIOTRGk2HLyhg== X-Received: by 2002:a17:902:db0c:b0:273:31fb:a872 with SMTP id d9443c01a7336-27331fbaaa9mr91371745ad.6.1758559459295; Mon, 22 Sep 2025 09:44:19 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=ARHlJd5L1MM63/vcxa5gF5hVPZC4X94xberTa5pXLevHfuSbrg== Received: by 2002:a17:903:3508:b0:267:ac34:9e67 with SMTP id d9443c01a7336-269840f261dls52322175ad.2.-pod-prod-07-us; Mon, 22 Sep 2025 09:44:17 -0700 (PDT) X-Received: by 2002:a05:6a20:7f93:b0:240:1ad8:1821 with SMTP id adf61e73a8af0-2925f75cb84mr17987738637.19.1758559457465; Mon, 22 Sep 2025 09:44:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758559457; cv=none; d=google.com; s=arc-20240605; b=BZQ1fxv0VSYQdc1ugJJkySvQwa5TUDJxvUJkd2mwT7StudkD80Wx4TxRXBuV5cql9p cO+eY3uJe7aBbP9lG3hIYALyPMQ6iLaqXPY6vCOIs9ye0fZ9s5qKIT0VwJPbJtpW47JU kj48bhi3Z7ZivzqKix1F4scElap9sZGYWAl1wAPxM9ZuaJYt7nVGlNyDm4xgVVNcYzmp +LHVMH9MJtYfEIF4M7Q2izf74zXh5mJfefxAfT3oibphnfZsZ57c/CJWlAilGZP5M2NP PswJXD0zhhAzfCVvyObfUx63gOZwMJYEIdDlIUP+yv2kDa8ZMdoJKkfYQlE31dCL23a2 ctTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=WqN1TAN92XwcAQm3GgFlN8KHzBWbq4xeX9VmzQ1QQeM=; fh=65uPnq3xxWxeuE2KN+Ajrg0XDbYMdgKgugkACMJPzOc=; b=kOx87G0QOLLEGg7h+iJlhI6b7x8DLiVrSNijeFKKSR9O/T7SgU9GVRDmiwzewr48Fc /AovKb6KPsDPrTrknaFYO+RnFY3/gZtjNH2NzhgTlk47XeidIq71FUuJDw7KNy+nV+0l pCv7q7aavhlkUxECZAm3I6+pWVpRsqysslx7RARWXGu2646fbAgU0qgu7XTckLchje5/ 7cGYqqL3nnd8mUPAgBSD21N6sITCgV4q0naUGNAod92ztYDpbp8D0SfNPT6pQRYXTuzg iwYiIrGcBEvBZUH8BLGhecxL/YLxUayuDajC0talmpRmYel/Jsu9H+uVvCAzPMsYJif/ C9QA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=qpV45DuD; spf=pass (google.com: domain of fm-1330684-20250922164415bb10e87a1f00020711-uxvrj7@rts-flowmailer.siemens.com designates 185.136.65.228 as permitted sender) smtp.mailfrom=fm-1330684-20250922164415bb10e87a1f00020711-UxVRJ7@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-228.siemens.flowmailer.net (mta-65-228.siemens.flowmailer.net. [185.136.65.228]) by gmr-mx.google.com with ESMTPS id 41be03b00d2f7-b551435d42asi438210a12.3.2025.09.22.09.44.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Sep 2025 09:44:17 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1330684-20250922164415bb10e87a1f00020711-uxvrj7@rts-flowmailer.siemens.com designates 185.136.65.228 as permitted sender) client-ip=185.136.65.228; Received: by mta-65-228.siemens.flowmailer.net with ESMTPSA id 20250922164415bb10e87a1f00020711 for ; Mon, 22 Sep 2025 18:44:15 +0200 X-Patchwork-Original-From: "alexander.heinisch via isar-users" From: "Heinisch, Alexander" To: isar-users@googlegroups.com Cc: kasturi.shekar@siemens.com, Alexander Heinisch Subject: [PATCH] isar-installer: Generate textual output only in unattended mode. Date: Mon, 22 Sep 2025 18:43:59 +0200 Message-Id: <20250922164359.1322947-1-alexander.heinisch@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1330684:519-21489:flowmailer X-Original-Sender: alexander.heinisch@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=qpV45DuD; spf=pass (google.com: domain of fm-1330684-20250922164415bb10e87a1f00020711-uxvrj7@rts-flowmailer.siemens.com designates 185.136.65.228 as permitted sender) smtp.mailfrom=fm-1330684-20250922164415bb10e87a1f00020711-UxVRJ7@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: alexander.heinisch@siemens.com Reply-To: alexander.heinisch@siemens.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Alexander Heinisch Dialog renders textual output unreadable, thus, useless. Thus, logs output via a serial, or piped to a file are useless when combined with dialog. Signed-off-by: Alexander Heinisch --- .../files/usr/bin/deploy-image-wic.sh | 52 ++++++++++--------- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh index 333762f1..779ed34a 100755 --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh @@ -157,32 +157,34 @@ version_ge() { fi } -# Get bmap-tools version -bmap_version=$(bmaptool --version | awk '{ print $NF }') - -if version_ge "$bmap_version" "3.6"; then - # Create a named pipe for progress communication - progress_pipe="/tmp/progress" - if ! mkfifo "$progress_pipe"; then - echo "Error: Failed to create named pipe $progress_pipe" - exit 1 - fi - - # Add psplash pipe to bmap_options - bmap_options="$bmap_options --psplash-pipe=$progress_pipe" - quiet_flag="-q" - - # Initialize the dialog gauge and update it dynamically - ( - while true; do - if read -r line < "$progress_pipe"; then - percentage=$(echo "$line" | awk '{ print $2 }') - echo "$percentage" - fi - done - ) | dialog --gauge "Flashing image, please wait..." 10 70 0 & +if ! $installer_unattended; then + # Get bmap-tools version + bmap_version=$(bmaptool --version | awk '{ print $NF }') + + if version_ge "$bmap_version" "3.6"; then + # Create a named pipe for progress communication + progress_pipe="/tmp/progress" + if ! mkfifo "$progress_pipe"; then + echo "Error: Failed to create named pipe $progress_pipe" + exit 1 + fi - gauge_pid=$! + # Add psplash pipe to bmap_options + bmap_options="$bmap_options --psplash-pipe=$progress_pipe" + quiet_flag="-q" + + # Initialize the dialog gauge and update it dynamically + ( + while true; do + if read -r line < "$progress_pipe"; then + percentage=$(echo "$line" | awk '{ print $2 }') + echo "$percentage" + fi + done + ) | dialog --gauge "Flashing image, please wait..." 10 70 0 & + + gauge_pid=$! + fi fi if ! bmaptool $quiet_flag copy $bmap_options "$installer_image_uri" "$installer_target_dev"; then