From patchwork Thu Oct 9 13:09:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arulpandiyan Vadivel X-Patchwork-Id: 4405 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 09 Oct 2025 15:06:42 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qv1-f62.google.com (mail-qv1-f62.google.com [209.85.219.62]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 599D6eIO012996 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 9 Oct 2025 15:06:41 +0200 Received: by mail-qv1-f62.google.com with SMTP id 6a1803df08f44-792f273fd58sf25872266d6.0 for ; Thu, 09 Oct 2025 06:06:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1760015195; cv=pass; d=google.com; s=arc-20240605; b=ZwGhc2EwtMyBOhHndOFs1bBA/aPKvFJ3815504Y/j3KCJprGLHvm9Ev3JLXYD20FGN HCbXv4btS+gmePJSpv6iLpNP5hzx0uF9J+PeJ+JSB8L+fp6BOzhTCYVkoEBvdI5A6I1f yFixROCXpDWQpuyxiGXrXrMv3CNiSaxCbQhIEUSOQY9DlFWJ1Iw/6I5HLjHRp3jCwcU8 TpbI0b0TXCebGyAaPJD+7HUSAVbqLt1aU6USx3x1v8Qy4Ix58BI7rFFIwajPY8d5v2n4 j0JOqD3fl4gld/ZLsFHb4g0+k/XmZhFXJIZtpGOF6NyhwU24Ul/hSCOnTa5P0j4yod/a CaYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=e5DqffozW5nwTKAwGROE3SnGK2psM8nZLIn+1HbrzS4=; fh=FJKeLzX3g/ErxwA95EFwfMFVVRwzP8pFhJahtXk+n1g=; b=arWd9kKIBMDFqpZIW0NA6m4SoLu5eJLqbsRvo51DxHBrKGrN2vyGW2pIbbJUcFe0io gLHv4zt5Mn5xKKOM/w9aeFQnWvSRTSuG6pe4idBxzvlkpAzwyqAA0o7WcoaNH2DwWkE0 v+8pY6WfmJq2IjjsRWT3FoKH606/cw8XyortrnKSev+DE7Tg2jCxuHEtySzg9jrmoZkJ /EKIEy5LZgz2X4wodQ70/8x4IY2EmdJLJD0qeoiWrvze3Oz4rMegv1pC2IvA9MrnUTc3 4ErEJPRlgyhOUVC1PjtJAtrx/zn/8aA2qDKmKRUzP84WnnncjgE/lDaQHQMNF0zXd5y4 yvWA==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=SVTV5dRA; spf=pass (google.com: domain of fm-1328317-20251009130631c82261b6840002076e-kmj8vv@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1328317-20251009130631c82261b6840002076e-KMj8VV@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1760015195; x=1760619995; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=e5DqffozW5nwTKAwGROE3SnGK2psM8nZLIn+1HbrzS4=; b=R37dYUaBixjc8MpY/24m1ar4XocHw1fchhn2B/Uk2OttzTabvbKWJIX4Z2t4vtuuFx lCYrivc4JWC37sTt/9a0HQ9YUT2zXgU2VTnKwXEYhPElAZAEhqX2cx7lID3ppVDiyIzF XKvttQMqscThDRKxIzDGJtFosQ5iWq8cncYeNshENAy0iriE0+MFCgfmIcKyVA1Ockkq tp4I3gUH1wvODvgRyymTXZ7+M9mis3pM4L0CXJ/HzCto3hIP3HssdFtTh6JmPRXOLIZA n1W9hqfyUjh7lkne58MzFJCDcgLlM5z3hzV+omKTQwbcSlYy06CVeGrPEQtqw9UCzBj/ T4fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760015195; x=1760619995; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e5DqffozW5nwTKAwGROE3SnGK2psM8nZLIn+1HbrzS4=; b=Z3q/6xSmV19nq1P/nHB2XIJfhE1jvLqThX03Q9vzFPmhZyHeou+laFNcrFrvotKDB7 JgpEz7a9STW9WQvs7jTRuoOZPwp/fwp/p2EubSeItTzeAIG6dTKPkbs1BLE46UQ8mnmS +PA08Ghc59TO7U6cZuqpdnmOSvkSqLEFB/Ia0jODQ9GX6bxUGwFRDXW3QmOBlXWtW3yk 001MCtKEqqyh+HHExOVzUlhNxc6XOk9ngD7ujB0sfWe1gQw029WP0hrpFvoYCwUMSmWr HFcwwbXkC2k/+uz85SM+ogl7Q475GDfnJ1Z7ga5aIxSivyi7lii7voEx0UBj1GvRgSik Yk1g== X-Forwarded-Encrypted: i=2; AJvYcCXF+idr6YOVQO8HcapMSS1D+RFXByH1B+2/B7wn3M+jrY06n/1lkIQvD/BB3yfF32R+1Gww0Pw=@isar-build.org X-Gm-Message-State: AOJu0Yzo9qogXJjVe8pHmE52/EtSn1Yl6r586h6Y0o9Q6ipp/Ncs4Jin ertROtjJGaLMD3+WjUBWgxA8pBnDXGvanZkFQI+xPbuvlO3ncUbvmOu7 X-Google-Smtp-Source: AGHT+IEabzETI3zAE1VESPRCb/5RjC1h62vEOrkpRkn8U7AOPx7z5v2oFT4X28Zt8hl52FG5Czxx8w== X-Received: by 2002:a05:6214:301a:b0:879:e817:ba65 with SMTP id 6a1803df08f44-87b2efe822dmr93842296d6.56.1760015194766; Thu, 09 Oct 2025 06:06:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="ARHlJd4WNfFxLXNLoodU4U41cxb+JULQ09mzERgquYFE3nID9w==" Received: by 2002:a05:6214:2f0b:b0:779:d180:7e3f with SMTP id 6a1803df08f44-87bb5093867ls15097716d6.1.-pod-prod-01-us; Thu, 09 Oct 2025 06:06:33 -0700 (PDT) X-Received: by 2002:a05:6102:3a13:b0:5d4:4f3:dafd with SMTP id ada2fe7eead31-5d5e2348ab8mr3273927137.18.1760015193433; Thu, 09 Oct 2025 06:06:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1760015193; cv=none; d=google.com; s=arc-20240605; b=J+s2eAGYvg51YwaToLJRKY9SdRWez/c3B5wYFm0qkWl4ZXKEF1pjs7vtnOvUVfvgR6 RaSGkbjhlzed4YoOvOLNH1jnCyqch7cypWLT+aEfnKXsgBQCOW5wBLtsNWND/5YyCqoT IDQVfOc81d1JJkTLdfi3ZWwzgN1ERPnp7BQNonDg9mRSZkk4CnlGzXxOjGBZxZ8t4cFL MFOALzJuTX+saGuSrZzLAMYrRS/Ir4qln6Oum8a+DzmcwW632Ag3TaWCtBcpxd/cxmb/ kQNxqL7Nsnow4tuWwIydRz4A/VoVPAn7fn7e1uXPljj8VSc2l6JoNHhHYNRC0SyxFaGG ftJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=94D5D0/aawcc+hjnyEv5iugEnMhYWU1lKc8cp9pzI44=; fh=iHHF6vtnzKjJkhrO05u9v0MUSNeeXiQJBQUXoyW1+LE=; b=DHAqx1HWATV98QiN78+9WeLg7cKPHVtq/Y8///qIJKI56fwpFSEGVP8kF7NMJwvH/d 4Tcl3LBqaS1MhYBHpLiCswUQYaPyAMBU4jL7NyC1j0//4unD1GUblid/qtCT6T1GYkK3 /cHRu0K1irYgh155sQA9TLEmMDgj7DUhGdmMG3sP7bQh7zlIU7//X4W98+KnKKzt4Ivl CMlIkSSPuargB7XLbONI2ZkdLtBhHKU23X93jau/S4y99nHRFYukJmjNGJB8L88IfaQv S2m2VHthh6u3zbLiZkKnaJZ5BKaOt6IUY2mpc/ZZDO2Z/TdpJdeqjPBTwtFIUVGh3HBS u4rA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=SVTV5dRA; spf=pass (google.com: domain of fm-1328317-20251009130631c82261b6840002076e-kmj8vv@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1328317-20251009130631c82261b6840002076e-KMj8VV@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-225.siemens.flowmailer.net (mta-64-225.siemens.flowmailer.net. [185.136.64.225]) by gmr-mx.google.com with ESMTPS id 71dfb90a1353d-5523cf3bbc4si104960e0c.3.2025.10.09.06.06.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Oct 2025 06:06:33 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1328317-20251009130631c82261b6840002076e-kmj8vv@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) client-ip=185.136.64.225; Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 20251009130631c82261b6840002076e for ; Thu, 09 Oct 2025 15:06:32 +0200 X-Patchwork-Original-From: "'Arulpandiyan Vadivel' via isar-users" From: Arulpandiyan Vadivel To: isar-users@googlegroups.com Cc: jan.kiszka@siemens.com, felix.moessbauer@siemens.com, cedric.hombourger@siemens.com, Arulpandiyan Vadivel Subject: [PATCH] meta-isar: add support to verify sha512 checksum for target image Date: Thu, 9 Oct 2025 18:39:28 +0530 Message-ID: <20251009130928.84805-1-arulpandiyan.vadivel@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1328317:519-21489:flowmailer X-Original-Sender: arulpandiyan.vadivel@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=SVTV5dRA; spf=pass (google.com: domain of fm-1328317-20251009130631c82261b6840002076e-kmj8vv@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1328317-20251009130631c82261b6840002076e-KMj8VV@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Arulpandiyan Vadivel Reply-To: Arulpandiyan Vadivel Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= In current approach, target images from installer is installed without any verifications and validations. Adding support of verifying image with sha512 checksum before installing image Currently during the image installation .bmap files also listed in the menu. Update to show only image name instead of showing supported artifacts like .bmap and .sha512. Added a class to support generating sha512 checksum for the images. Signed-off-by: Arulpandiyan Vadivel --- .../classes/installer-add-rootfs.bbclass | 6 +- ...eploy-image_0.1.bb => deploy-image_0.2.bb} | 2 +- .../files/usr/bin/deploy-image-wic.sh | 56 ++++++++++++++++++- meta/classes/image-checksum.bbclass | 14 +++++ meta/classes/image.bbclass | 1 + 5 files changed, 76 insertions(+), 3 deletions(-) rename meta-isar/recipes-installer/deploy-image/{deploy-image_0.1.bb => deploy-image_0.2.bb} (96%) create mode 100644 meta/classes/image-checksum.bbclass diff --git a/meta-isar/classes/installer-add-rootfs.bbclass b/meta-isar/classes/installer-add-rootfs.bbclass index c738f690..185e4a3c 100644 --- a/meta-isar/classes/installer-add-rootfs.bbclass +++ b/meta-isar/classes/installer-add-rootfs.bbclass @@ -19,7 +19,7 @@ IMAGE_DATA_POSTFIX ??= "wic.zst" IMAGE_DATA_POSTFIX:buster ??= "wic.xz" IMAGE_DATA_POSTFIX:bullseye ??= "wic.xz" -ROOTFS_ADDITIONAL_FILES ??= "installer-target installer-target-bmap" +ROOTFS_ADDITIONAL_FILES ??= "installer-target installer-target-bmap installer-target-sha512" def get_installer_source(d, suffix): installer_target_image = d.getVar('INSTALLER_TARGET_IMAGE') or "" @@ -49,4 +49,8 @@ ROOTFS_ADDITIONAL_FILE_installer-target[destination] = "${@ get_installer_destin ROOTFS_ADDITIONAL_FILE_installer-target-bmap[source] = "${@ get_installer_source(d, "wic.bmap")}" ROOTFS_ADDITIONAL_FILE_installer-target-bmap[destination] = "${@ get_installer_destination(d, "wic.bmap")}" +# Add support for SHA512 checksum files +ROOTFS_ADDITIONAL_FILE_installer-target-sha512[source] = "${@ get_installer_source(d, d.getVar('IMAGE_DATA_POSTFIX') + '.sha512')}" +ROOTFS_ADDITIONAL_FILE_installer-target-sha512[destination] = "${@ get_installer_destination(d, d.getVar('IMAGE_DATA_POSTFIX') + '.sha512')}" + do_rootfs_install[mcdepends] += "${@ get_mc_depends(d, "do_image_wic")}" diff --git a/meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb b/meta-isar/recipes-installer/deploy-image/deploy-image_0.2.bb similarity index 96% rename from meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb rename to meta-isar/recipes-installer/deploy-image/deploy-image_0.2.bb index b287a8d1..0259a5af 100644 --- a/meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb +++ b/meta-isar/recipes-installer/deploy-image/deploy-image_0.2.bb @@ -1,5 +1,5 @@ # This software is a part of ISAR. -# Copyright (C) Siemens AG, 2024 +# Copyright (C) Siemens AG, 2025 # # SPDX-License-Identifier: MIT diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh index 333762f1..963f5756 100755 --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh @@ -10,11 +10,65 @@ SCRIPT_DIR=$( dirname -- "$( readlink -f -- "$0"; )"; ) . "${SCRIPT_DIR}/../lib/deploy-image-wic/handle-config.sh" +verify_checksum() { + checksum_file="$1" + hash_image_file="$2" + + # Get the extension from the checksum file + algorithm=$(echo "$checksum_file" | awk -F. '{print $NF}') + + #Read the expected checksum + expected_checksum=$(cut -d' ' -f1 "$checksum_file") + + # Check if the checksum file was empty + if [[ -z "$expected_checksum" ]]; then + dialog --msgbox "Error: Checksum file is empty or unreadable, Installation aborted." 6 60 + exit 1 + fi + + # Calculate the current checksum of the file + local current_checksum + case "$algorithm" in + sha512) + current_checksum=$("${algorithm}sum" "$hash_image_file" | awk '{print $1}') + ;; + *) + dialog --msgbox "Error: Unsupported algorithm($algorithm), Installation aborted." 6 60 + exit 1 + ;; + esac + + # Compare the checksums + if [[ "$current_checksum" == "$expected_checksum" ]]; then + echo "Checksum validation success for $checksum_file and $hash_image_file" + else + dialog --msgbox "Error: Checksum validation failure for $checksum_file and $hash_image_file, Installation aborted." 6 60 + exit 1 + fi +} + +hash_files_uri=$(find "$installdata" -type f -iname "*.sha512") +if [ -n "$hash_files_uri" ]; then + for hash_file in $hash_files_uri; do + # extract the checksum / bmap file from signed files name + hash_image_file="${hash_file%.*}" + if [ -f "$hash_image_file" ] && [ -f "$hash_file" ]; then + verify_checksum "$hash_file" "$hash_image_file" + else + dialog --msgbox "[ERROR] Checksum file or image file is missing! Installation aborted" 6 60 + exit 1 + fi + done +else + dialog --msgbox "Error: No checksum file(s) found for image artifacts, Installation aborted." 6 60 + exit 1 +fi + if ! $installer_unattended; then installer_image_uri=$(find "$installdata" -type f -iname "*.wic*" -a -not -iname "*.wic.bmap" -exec basename {} \;) if [ -z "$installer_image_uri" ] || [ ! -f "$installdata/$installer_image_uri" ]; then pushd "$installdata" - for f in $(find . -type f); do + for f in $(find . -type f -iname "*.wic.zst" -exec basename {} \;); do array+=("$f" "$f") done popd diff --git a/meta/classes/image-checksum.bbclass b/meta/classes/image-checksum.bbclass new file mode 100644 index 00000000..673235a0 --- /dev/null +++ b/meta/classes/image-checksum.bbclass @@ -0,0 +1,14 @@ +# This software is a part of ISAR. +# Copyright (C) 2025 Siemens AG +# +# SPDX-License-Identifier: MIT + +do_generate_checksum() { + cd ${DEPLOY_DIR_IMAGE} + for postfix in ${IMAGE_FSTYPES}; do + [ -f "${IMAGE_FULLNAME}.$postfix" ] || continue + sha512sum "${IMAGE_FULLNAME}.$postfix" > "${IMAGE_FULLNAME}.$postfix.sha512" + done +} + +do_image_wic[postfuncs] += "do_generate_checksum" diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index bd1b8552..57216014 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -141,6 +141,7 @@ IMAGE_CLASSES ??= "" IMGCLASSES = "imagetypes imagetypes_wic imagetypes_vm imagetypes_container squashfs" IMGCLASSES += "${IMAGE_CLASSES}" inherit ${IMGCLASSES} +inherit image-checksum # convenience variables to be used by CMDs IMAGE_FILE_HOST = "${DEPLOY_DIR_IMAGE}/${IMAGE_FULLNAME}.${type}"