From patchwork Wed Nov 5 10:15:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "srinuvasan.a" X-Patchwork-Id: 4537 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 05 Nov 2025 11:12:00 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-ed1-f63.google.com (mail-ed1-f63.google.com [209.85.208.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5A5ABxkE017683 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 5 Nov 2025 11:11:59 +0100 Received: by mail-ed1-f63.google.com with SMTP id 4fb4d7f45d1cf-6409605a485sf4186847a12.0 for ; Wed, 05 Nov 2025 02:11:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1762337514; cv=pass; d=google.com; s=arc-20240605; b=hmFhiaqHF1f3K8VTHAd4Y76/jPYENSx1DNUmMPSR5Ao5MsPiv/+J1hNrLYYqAZZYUr aSnTOKekzIO2VYKgn1LmcjYcN2STgd4s5rVgWEDGT5J7GOCuPOQAxspeKiLLakTfl/6U L0AjU7vOEj8vknTfuF4Qcj0GWqy5HCgrTeLxghKXXt1nrKDWcoF1rk6lXtRBAZhF2VNg 0vp8XZ3CM5etFpeQtQFzvYv6fXYw4gUZ1jaUcmzHs9y11bdRfxkkkbYBjDLz/IL4We66 VaQp5R41E7ZT10wT1zAPKgynJQZaRmoy8+uWkDGj0OsPvZi8JvYNgisl7QAeWMUSwR/P Gn4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3VS4HzjuaQMexc+zTEgzq718liY+v98YG5ffi4Mf6z4=; fh=ZNJ1R1+T7K2PLY73Mib5hgHnp0cvNklNBT/BSGE1uuE=; b=URKiPMPYKFa4f9aXjxZvo1/JVziC8mGHHMKX5l/SGJbiA++RTb6jDwASjNOy53dRIM JSTQmoPow4xN28ahqGKhTBgggbIxFDxak+0g98N+HU5qHCQl3SHHWyjhEeb6jPi7B/oG 9uQu+8fNrqPi4fTVU7PiyGHmyq2RaOCdSMAHOT2iQOPxrBbRetfWCpUkk6aNhOVODmIg cCuMQa/H1Xrlou5xQQyjCiEKrWlK7TdoAEoRCNGpquxbi92f4g+fSIR/nnlCIuRqZrtw 6k4wlFVWZ2G2mEtwpWbXeL6MktNrZfXz+4TyekZVVu8lMglzzlY5hJ1qMxY1CdL6FQQf cfyA==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=VRup66Dt; spf=pass (google.com: domain of fm-1324425-2025110510115067647344bd00020795-fpqalu@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1324425-2025110510115067647344bd00020795-FpQALU@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1762337514; x=1762942314; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=3VS4HzjuaQMexc+zTEgzq718liY+v98YG5ffi4Mf6z4=; b=YSfUTIypDUYYkj6BwY5CqkiIHK42rtwOqA/A5cGYHu0k45s4e7MTF11JVtSqR8wmQe OD/IGw+yhvxrSUiEANV1QY19CRJyx4nDXXD3jFcZNwddYW+8dvwYvXg15spm4TOjuHc8 Qk7RsB8PhiTUAie8FkgZhuaGtiTeLHY985kgh3eB8onIlV7BKooB/86Il46Wvv8pOxGv 3bNefCVz68w+/PIPraUUbOs9lN2vrS9KZW+Lpb5KcBGD+wGLwhdZm+qYkgRcE0PXE8TL dfQ4qsvwauJo0PVx3jEt8oVxVUpYZsh5rFKdLF/VpuNioeSu3nh/ALCWS7iXpdNUqbQa BtsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762337514; x=1762942314; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3VS4HzjuaQMexc+zTEgzq718liY+v98YG5ffi4Mf6z4=; b=XxLlfE4HjOPf2T5dRgem1ErfW0rNrauWtemslJ/KurCLYhSFKsVu8IcNunyzkcj9WB BRKxaRCoHu+UiLj5vZxJ7R0uA+EVqvhZEdKCuSfD7SikNvdseAdz9MsqS9R5ElkVWB2n Z5Jxj27IiK6QfifDxd2bA7poncQyyTSJmk3HMWBbhyUXeq/FzEeBUSXVaxohEEPYFaNn zYs1U5aCBV/UpWtf0RsT3aunE0oZN5SsVJqd7TWMCt2oecwcPcogr5lnlPAWStg8kfQn dwyOIZYWZeKsNxhI9JB16VZFY8bXFYQBXdw5kRbKX8BlDHDka6UVfaeTP1C+LAhHgMhH pr3Q== X-Forwarded-Encrypted: i=2; AJvYcCULYgO0XnHnl2pPZGwZToeU58VsMlV6m2sSxbJe46DiT5d7iy/cnfCeIZKneRLNtWXE/svqPlM=@isar-build.org X-Gm-Message-State: AOJu0YyE2OUIz03E2YIegCzp+Kdcj2eN0rpb7TCAH+mVRCabKaTEB+ZN sVomXM3UZv/5YNUfLWqSj2jXcwZPyWcR/6XkKIUl4kVe/teVkQm8FFTs X-Google-Smtp-Source: AGHT+IFGRUbgyQTlXdi20SMT3haRO7oUADhUgYzKJqevuR524Pp8euCg4KuDlzrNWN212khK5hYItA== X-Received: by 2002:a05:6402:254f:b0:640:abd5:865b with SMTP id 4fb4d7f45d1cf-64105a44bddmr2041913a12.22.1762337514055; Wed, 05 Nov 2025 02:11:54 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="Ae8XA+aSjzyrblJqdf+fs8moMtvXkTNFXBMjwtJGibNh2JrZKg==" Received: by 2002:a05:6402:20cc:20b0:640:bb82:6ca6 with SMTP id 4fb4d7f45d1cf-640bb826ffdls25196a12.2.-pod-prod-05-eu; Wed, 05 Nov 2025 02:11:51 -0800 (PST) X-Received: by 2002:a05:6402:1d48:b0:640:7402:4782 with SMTP id 4fb4d7f45d1cf-6410568513fmr2041482a12.0.1762337510999; Wed, 05 Nov 2025 02:11:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762337510; cv=none; d=google.com; s=arc-20240605; b=PFBhzBiWaW5cjh6ug0fax+BK2MM3mqGd0Dmfy35fPOBoj8h3PuYSYLjuqpxRzRwtRx FOXmZ6Tz8snn10YZMBmGmq1rWT3N7K9f5GyqfMLn7ABS0s9ilHevbv53DCsR1F811Hj5 6TtaHqYG6vasXEqVGHg/7qOj6kDrG61doXcipxKaw/YfX3UWYtgjrV6cpx2ADiN6QCiB UJwqcg3CZivB0gMqXWq0zDvBye/J2o+ny2HTL6W77nCxW/+pxvk/O2eKYFFT/sMBk4mE DJXsd3iIY80Tp6Q7zX/rsJ8WL97LPHec5d5Elti649HlbbPOqdRnj7TvyyN/gk1U4lnm Treg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=BYaiPhwslb2x+nHrfxLl1ku/nmjWFj+EO3xubzrRrx8=; fh=fJYqdYL3xhCS5FNWeLWGTuHLWIkeGA3KdbQ9U0DP7m0=; b=VwioJG1NVlIiwvrhfrsojwihH+eC6m+pyglzim1kB4kl/k/umpQgMwJOyXLOr7ZQ4c xaNMX8/Vd7Jus99qqx/u3TWgMJV4oCV8p1aocknLCqx8DEbBraFkvYvBg34vSMWSYY9o prULMqqEiawu0az7+gPghvwwCxhBbXjSJyYYxbbXbWN5U2IYJQVyXhtRJXJFjY5dVTmm TZv4H6KEl7UKPc6zTFvbhOt70KkIMnRRRr5G6KqxhtrIowimaOOgwBqaXlm1DCaK8bT0 wsLSPYH8wTupKTDAqa4Xh3qfMLa2ksOeOEfzoc02gahrOvMeqW6dY7cT5kOfIZaShlje fmKw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=VRup66Dt; spf=pass (google.com: domain of fm-1324425-2025110510115067647344bd00020795-fpqalu@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1324425-2025110510115067647344bd00020795-FpQALU@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-225.siemens.flowmailer.net (mta-65-225.siemens.flowmailer.net. [185.136.65.225]) by gmr-mx.google.com with ESMTPS id 4fb4d7f45d1cf-640e67ec185si158472a12.1.2025.11.05.02.11.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Nov 2025 02:11:50 -0800 (PST) Received-SPF: pass (google.com: domain of fm-1324425-2025110510115067647344bd00020795-fpqalu@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) client-ip=185.136.65.225; Received: by mta-65-225.siemens.flowmailer.net with ESMTPSA id 2025110510115067647344bd00020795 for ; Wed, 05 Nov 2025 11:11:50 +0100 X-Patchwork-Original-From: "srinuvasan.a via isar-users" From: "srinuvasan.a" To: isar-users@googlegroups.com Cc: jan.kiszka@siemens.com, srinuvasan Subject: [PATCH v6 1/2] debianize: set appropriate Standards-Version for each debian suite Date: Wed, 5 Nov 2025 15:45:02 +0530 Message-Id: <20251105101503.283956-1-srinuvasan.a@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1324425:519-21489:flowmailer X-Original-Sender: srinuvasan.a@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=VRup66Dt; spf=pass (google.com: domain of fm-1324425-2025110510115067647344bd00020795-fpqalu@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1324425-2025110510115067647344bd00020795-FpQALU@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: srinuvasan.a@siemens.com Reply-To: srinuvasan.a@siemens.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: srinuvasan The Standards-Version field in debian/control declares the Debian Policy version that the package complies with. Currently, the custom source packages use a hard-coded Standards-Version: 3.9.6, which is obsolete and does not align with the policies of newer Debian releases Update the packaging to set the correct Standards-Version dynamically based on the target Debian suite, ensuring compliance with the appropriate Debian Policy version for each release. Debian Policy evolves over time, newer versions may add, remove, or deprecate control fields and packaging behaviors. Using an outdated Standards-Version can miss required or recommended fields, leading to QA or functional issues. Examples: - Rules-Requires-Root (Policy 4.1.0): declares if root privileges are needed during debian/rules execution, improves reproducibility and isolation. - Homepage (Policy 3.9.3): provides upstream project link for better metadata. Older Standards-Version(Policy 3.9.6) may trigger lintian warnings such as: W: source: missing-rules-requires-root-field W: source: missing-homepage-field Keeping Standards-Version current ensures clean builds, QA compliance, and future compatibility. Signed-off-by: srinuvasan --- RECIPE-API-CHANGELOG.md | 9 +++++++++ meta-isar/conf/distro/raspios-bookworm.conf | 2 ++ meta-isar/conf/distro/raspios-bullseye.conf | 2 ++ meta-isar/conf/distro/ubuntu-focal.conf | 2 ++ meta-isar/conf/distro/ubuntu-jammy.conf | 2 ++ meta-isar/conf/distro/ubuntu-noble.conf | 2 ++ meta/classes/debianize.bbclass | 6 ++++-- meta/conf/distro/debian-bookworm.conf | 2 ++ meta/conf/distro/debian-bullseye.conf | 2 ++ meta/conf/distro/debian-buster.conf | 2 ++ meta/conf/distro/debian-sid-ports.conf | 2 ++ meta/conf/distro/debian-sid.conf | 2 ++ meta/conf/distro/debian-trixie.conf | 2 ++ 13 files changed, 35 insertions(+), 2 deletions(-) diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md index 1826667a..34194b39 100644 --- a/RECIPE-API-CHANGELOG.md +++ b/RECIPE-API-CHANGELOG.md @@ -242,6 +242,15 @@ consumption by imaging classes. Additional build dependencies of auto-debianized packages can now be defined by setting DEBIAN_BUILD_DEPENDS. +### Add DEBIAN_STANDARDS_VERSION as a deb_debianize parameter + +By default, the Standards-Version field in the debian/control file is automatically +set based on the corresponding Debian suite. +If you need to override this default value, you can do so by defining +the DEBIAN_STANDARDS_VERSION variable in your recipe. + +E.x: `DEBIAN_STANDARDS_VERSION: = ` + ### Separation of ${S} and ${D} in dpkg-raw ${S} can now be used for checking out sources without being linked implicitly diff --git a/meta-isar/conf/distro/raspios-bookworm.conf b/meta-isar/conf/distro/raspios-bookworm.conf index 079dba24..edba011f 100644 --- a/meta-isar/conf/distro/raspios-bookworm.conf +++ b/meta-isar/conf/distro/raspios-bookworm.conf @@ -25,3 +25,5 @@ THIRD_PARTY_APT_KEYS += "http://archive.raspberrypi.org/debian/raspberrypi.gpg.k COMPAT_DISTRO_ARCH:arm64 = "armhf" DISTRO_GCC = "12" + +DEBIAN_STANDARDS_VERSION ?= "4.6.2" diff --git a/meta-isar/conf/distro/raspios-bullseye.conf b/meta-isar/conf/distro/raspios-bullseye.conf index a362289d..60782f67 100644 --- a/meta-isar/conf/distro/raspios-bullseye.conf +++ b/meta-isar/conf/distro/raspios-bullseye.conf @@ -28,3 +28,5 @@ COMPAT_DISTRO_ARCH:arm64 = "armhf" DISTRO_GCC = "10" DEBIAN_COMPAT = "13" + +DEBIAN_STANDARDS_VERSION ?= "4.5.1" diff --git a/meta-isar/conf/distro/ubuntu-focal.conf b/meta-isar/conf/distro/ubuntu-focal.conf index 81728dec..155644c1 100644 --- a/meta-isar/conf/distro/ubuntu-focal.conf +++ b/meta-isar/conf/distro/ubuntu-focal.conf @@ -10,3 +10,5 @@ BASE_DISTRO_CODENAME = "focal" DISTRO_GCC = "9" DEBIAN_COMPAT = "12" + +DEBIAN_STANDARDS_VERSION ?= "4.5.0" diff --git a/meta-isar/conf/distro/ubuntu-jammy.conf b/meta-isar/conf/distro/ubuntu-jammy.conf index afc4a731..492ab126 100644 --- a/meta-isar/conf/distro/ubuntu-jammy.conf +++ b/meta-isar/conf/distro/ubuntu-jammy.conf @@ -10,3 +10,5 @@ BASE_DISTRO_CODENAME = "jammy" DISTRO_GCC = "11" DEBIAN_COMPAT = "13" + +DEBIAN_STANDARDS_VERSION ?= "4.6.0" diff --git a/meta-isar/conf/distro/ubuntu-noble.conf b/meta-isar/conf/distro/ubuntu-noble.conf index 531f085f..5a9bd100 100644 --- a/meta-isar/conf/distro/ubuntu-noble.conf +++ b/meta-isar/conf/distro/ubuntu-noble.conf @@ -10,3 +10,5 @@ BASE_DISTRO_CODENAME = "noble" DISTRO_GCC = "13" DEBIAN_COMPAT = "13" + +DEBIAN_STANDARDS_VERSION ?= "4.7.0" diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass index 1f54e8f9..e29bfb1e 100644 --- a/meta/classes/debianize.bbclass +++ b/meta/classes/debianize.bbclass @@ -17,6 +17,7 @@ DEBIAN_BREAKS ??= "" DEBIAN_BUILT_USING ??= "" DEBIAN_MULTI_ARCH ??= "no" DEBIAN_COMPAT ??= "10" +DEBIAN_STANDARDS_VERSION ??= "3.9.6" DEBIAN_CHANGELOG_TIMESTAMP ??= "3600" DEBIAN_RULES_REQUIRES_ROOT ??= "" DESCRIPTION ??= "must not be empty" @@ -80,14 +81,15 @@ deb_create_control[vardeps] += "DEBIANIZE_BUILD_DEPENDS \ DEBIAN_BREAKS \ DEBIAN_BUILT_USING \ DEBIAN_CONFLICTS \ - DEBIAN_RULES_REQUIRES_ROOT" + DEBIAN_RULES_REQUIRES_ROOT \ + DEBIAN_STANDARDS_VERSION" deb_create_control() { # Add Source section cat << EOF > ${S}/debian/control Source: ${BPN} Section: ${@ deb_list_beautify(d, 'DEBIAN_SECTION')} Priority: optional -Standards-Version: 3.9.6 +Standards-Version: ${DEBIAN_STANDARDS_VERSION} Maintainer: ${MAINTAINER} Build-Depends: ${@ deb_list_beautify(d, 'DEBIANIZE_BUILD_DEPENDS')} EOF diff --git a/meta/conf/distro/debian-bookworm.conf b/meta/conf/distro/debian-bookworm.conf index ee8f2ced..fc5fd5cc 100644 --- a/meta/conf/distro/debian-bookworm.conf +++ b/meta/conf/distro/debian-bookworm.conf @@ -15,3 +15,5 @@ DISTRO_KERNELS ?= "4kc-malta 5kc-malta 686 686-pae amd64 arm64 armmp \ DISTRO_GCC = "12" DEBIAN_COMPAT = "13" + +DEBIAN_STANDARDS_VERSION ?= "4.6.2" diff --git a/meta/conf/distro/debian-bullseye.conf b/meta/conf/distro/debian-bullseye.conf index ee4ecca2..8bda582a 100644 --- a/meta/conf/distro/debian-bullseye.conf +++ b/meta/conf/distro/debian-bullseye.conf @@ -17,3 +17,5 @@ DISTRO_KERNELS ?= "4kc-malta 5kc-malta 686 686-pae amd64 arm64 armmp \ DISTRO_GCC = "10" DEBIAN_COMPAT = "13" + +DEBIAN_STANDARDS_VERSION ?= "4.5.1" diff --git a/meta/conf/distro/debian-buster.conf b/meta/conf/distro/debian-buster.conf index cd58710b..49a073c6 100644 --- a/meta/conf/distro/debian-buster.conf +++ b/meta/conf/distro/debian-buster.conf @@ -13,3 +13,5 @@ DISTRO_KERNELS ?= "686 686-pae amd64 arm64 armmp armmp-lpae cloud-amd64 \ DISTRO_GCC = "8" DEBIAN_COMPAT = "12" + +DEBIAN_STANDARDS_VERSION ?= "4.3.0" diff --git a/meta/conf/distro/debian-sid-ports.conf b/meta/conf/distro/debian-sid-ports.conf index 940dc051..e141327c 100644 --- a/meta/conf/distro/debian-sid-ports.conf +++ b/meta/conf/distro/debian-sid-ports.conf @@ -25,3 +25,5 @@ THIRD_PARTY_APT_KEYS += "${DEBIAN_PORTS_KEYS}" IMAGE_PREINSTALL += "init" DEBIAN_COMPAT = "13" + +DEBIAN_STANDARDS_VERSION ?= "4.7.2" diff --git a/meta/conf/distro/debian-sid.conf b/meta/conf/distro/debian-sid.conf index 081ec7b4..c76b15e4 100644 --- a/meta/conf/distro/debian-sid.conf +++ b/meta/conf/distro/debian-sid.conf @@ -20,3 +20,5 @@ DISTRO_KERNELS ?= "5kc-malta 686 686-pae alpha-generic alpha-smp amd64 arm64 \ DISTRO_GCC = "13" DEBIAN_COMPAT = "13" + +DEBIAN_STANDARDS_VERSION ?= "4.7.2" diff --git a/meta/conf/distro/debian-trixie.conf b/meta/conf/distro/debian-trixie.conf index b3677f45..999e38a3 100644 --- a/meta/conf/distro/debian-trixie.conf +++ b/meta/conf/distro/debian-trixie.conf @@ -17,3 +17,5 @@ DISTRO_KERNELS ?= "5kc-malta amd64 arm64 armmp armmp-lpae cloud-amd64 \ DISTRO_GCC = "14" DEBIAN_COMPAT = "13" + +DEBIAN_STANDARDS_VERSION ?= "4.7.2"