From patchwork Thu Nov 6 15:15:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "cedric.hombourger@siemens.com" X-Patchwork-Id: 4556 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 06 Nov 2025 16:15:23 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-ed1-f61.google.com (mail-ed1-f61.google.com [209.85.208.61]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5A6FFMpg027288 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 6 Nov 2025 16:15:22 +0100 Received: by mail-ed1-f61.google.com with SMTP id 4fb4d7f45d1cf-640cc916e65sf1602301a12.1 for ; Thu, 06 Nov 2025 07:15:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1762442117; cv=pass; d=google.com; s=arc-20240605; b=jTwEphNJVyabdCyvcwRlyCmET8MJmiFo/FOy8+jf8UdzQ/C7o/CuL7OFZNMrxe8dww IEkbL4a7YVn7AcASaeSCZBim9f7LOC5QT6SR2aLo9+XNNwKd7y2AuTnyE3VNFY0nEUSX Yn+gYKu7VaPKxCGL9GXbU35JN6iGnTXXNwWGAFTjq+KE37FStC9cvYmR0lbpu1A1Bw+2 hqAL+ne872aBibNk5owltw8NE1e7h8wElc9j2wCzTutANPBedWHe89XInj6eqQTF2//+ KLCHA0JZExIuRwnNkYFK7vEHk9UelUebcE5wktJuR5LM4203SRg8DbSTRW9V3N/f94Ar anhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=IygLMu2ricYKU3OIkBH7ubA9xKVsEl3RHogyz+hHsJc=; fh=F9hpNkv4i7qTLD0SSEq2ghTG7IiPg/20F0k2Zm1nKx0=; b=L81er+Qs7QxE8T51zcknWJrcck2mLILcLs9SC1yiTTzf4rqCLZtWP5BpxedQ3Zeluh 43poD0wj/o/5OeSjeAM1UlkwP+mSRtkRgW8efHw0HhS97r9NUL9cBVgpBY+t/FXVxDS4 zzMaIfp/71HM8ZjKjDOD3f/1fGqpeN0Y8zz3g1HA1luzhbE54S5J9W+jU36WzyuHgbjJ yIMEk4yVuJnLg6t77P/Rpvz5liI+giW4vcSRwm8FGU4V7TI//7unxlB91V/pL4D4yjoT 2OcxfO5QU6Xx2Qomu3NQqqmiY9giJKy/4n5VObOwmkZqTJRFGViygxGSEI1l5JLwgN+a z2lg==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=NYtc12Nv; spf=pass (google.com: domain of fm-1212295-202511061515133bf611ea35000207a3-nza5ag@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1212295-202511061515133bf611ea35000207a3-nzA5aG@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1762442117; x=1763046917; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=IygLMu2ricYKU3OIkBH7ubA9xKVsEl3RHogyz+hHsJc=; b=gvdTXRsFcteh06Ll7frNZh8DA3oG6G9tqengUU+9EGt4/EDorupv/xy3xKTfJmKMuy X+GNgjwOaS2cKGnMiGME+Ph0gSkWqlnL0SB+JKT7P49jtOqUDQJnYP0uj6vkZ6pchqg1 1gTYoaNSndsTO5ViW0KNrWK9MHuEEvVXksSP7kAmuOHza6H2GHVEQGNudrI1YnhAvUaJ 1vwzZhVq4l2E4QSPBmSF/rgTonh0OLlKGV7nerczsbrFUa0oiPV5DrSXHKEYM+Gj8opv GiwGATsgZ7mWnxMl75DRHcfjX3BdcHLYF3Txx+ZMj7UdQW1jgqDIC5FVyYezeS9BCoLa 9iYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762442117; x=1763046917; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IygLMu2ricYKU3OIkBH7ubA9xKVsEl3RHogyz+hHsJc=; b=wUkc8ULboVUFr6olYE04pbyS0bp9Ask5dkEAanGWgTJvYPX+brwNGPWaFxouLuxkwO hQliUdGLoDpLvQmwpk/ucVuMlJMDk/L/1JqFRBcsQcaDr5bN1HEBdHclrnEDN93xd1Rj zLlN+KhpyqbLcLETZ6nKDJxlFLtuTD+9clyqYJPvUigh/X9J2eoeukGWfsxvemhn7FJu N7gFtI95Pw0wKghYQn3PBk4jTEemIZAycBP65hKmwo6xGqUGjZyew+Xtw9zUF5XtskW3 D+VSUruyLOZCZ78iC4d3aKh4lQP8fmM8rGkqJBgDmCG7rkEHuZ9B+jydLv6TWvYu96JC WAgg== X-Forwarded-Encrypted: i=2; AJvYcCVY4fHMIv1UOS3vBgrFHiF0QEqg5lcY7twYKEz5hlet1ZME0ydLTJO0ydMU+l5zO+qDNYEJs+U=@isar-build.org X-Gm-Message-State: AOJu0YxnoBne6hFfMePU8Lwa9D88N/O2vpPDSxS4ec2C2pzG9W9NSFne kr7p730L0Den7SqmUponS6PaNPxNIfb6bzGUiobbjR9ndjwgQ+TDZLAv X-Google-Smtp-Source: AGHT+IGmd1TAc1S8bIYgPwpzWP/z0QSDr98AwLe33hUuAJ60Y80njVyWRtgE5lsigiDXQmX/swmniQ== X-Received: by 2002:a05:6402:40ce:b0:640:96fe:c7c2 with SMTP id 4fb4d7f45d1cf-6410588dc11mr6824194a12.5.1762442117165; Thu, 06 Nov 2025 07:15:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="Ae8XA+YM0KQfOvohdAaDCAGZk6tyD7Ig/ugoSKMVjsWOAycU3w==" Received: by 2002:aa7:cf8f:0:b0:640:8bcf:e502 with SMTP id 4fb4d7f45d1cf-6411d6afb82ls975835a12.0.-pod-prod-05-eu; Thu, 06 Nov 2025 07:15:14 -0800 (PST) X-Received: by 2002:a17:907:8687:b0:b6d:7e04:7a24 with SMTP id a640c23a62f3a-b72654c2971mr746864666b.36.1762442113964; Thu, 06 Nov 2025 07:15:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762442113; cv=none; d=google.com; s=arc-20240605; b=Me64QezvAadox3isnjOsaaUt4F9BSQAXJNOjvzzxl78+GYqUF3eJtSyMS581+qq06A YYbcnMPAudv6YTonGFxSDT2thP4L1GUyPfH7a0tiJqX3ynqosVopJQhoXtDUubhx+wHu X2t9a8klSEbNFGqVJwxjs+nbL+LpjVVAAObgYQuC2XIvdFLhdGZ/My54qTZz/mW9ec/g TiDBrbo0900tyvrQ5wNCqxjCQ9ir4IVyNeY8wWAeYoq9bqLa2IJvYSwcv3MUcDDWGCB5 37xNfLQdEWn+3znu+Kdb4kaBFIEJ54+iJug/v8DqC0WbI0rLDeCqB6SK/p7RiW8kuSIJ hM7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=9zxmne/6CX/XHrDaJlWECTX4aC7o0KrnD5kFTx2Bx4o=; fh=1z37pEVhqwMLlkT4FDzOga7XBsM6Rzv6sXOq0pipxqo=; b=hSIwbtapMWUiI6fLjWYidwRWY46VLGlE5PDcsFh9CcHHRwt7MHuaGKMAIrKv6Py0lP /w+EdD67P3AzM/1/XPtD0r+1e3lCHWoGXrVq+jLqsL4M2LuHbHaeGdMaKGK5DFScgd38 S+gHsK7kSh1WxIBhWfFTWYEdNqEeWn87hMoHIfds98Dar7+aBz5OIpd6pJi8d9zr6gJN kOPss5rLRiXxSXVFjKw6SsfdAKWw66m550gUynWOtTeCewaQLiQrN6IfECF9aPoDWqYN HX0A5Y/izuYT0VU67O5queFgBUId8mQ+69GMFZKUnUGXqU1Z4aizc/+dw5D5gjKynhRA Ls2A==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=NYtc12Nv; spf=pass (google.com: domain of fm-1212295-202511061515133bf611ea35000207a3-nza5ag@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1212295-202511061515133bf611ea35000207a3-nzA5aG@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-226.siemens.flowmailer.net (mta-65-226.siemens.flowmailer.net. [185.136.65.226]) by gmr-mx.google.com with ESMTPS id 4fb4d7f45d1cf-6411f6f575dsi62214a12.0.2025.11.06.07.15.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Nov 2025 07:15:13 -0800 (PST) Received-SPF: pass (google.com: domain of fm-1212295-202511061515133bf611ea35000207a3-nza5ag@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) client-ip=185.136.65.226; Received: by mta-65-226.siemens.flowmailer.net with ESMTPSA id 202511061515133bf611ea35000207a3 for ; Thu, 06 Nov 2025 16:15:13 +0100 X-Patchwork-Original-From: "'Cedric Hombourger' via isar-users" From: "cedric.hombourger@siemens.com" To: isar-users@googlegroups.com Cc: Cedric Hombourger Subject: [PATCH] customizations: defer IMAGE variable expansion in CUSTOMIZATION_VARS Date: Thu, 6 Nov 2025 16:15:08 +0100 Message-ID: <20251106151508.3872857-1-cedric.hombourger@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1212295:519-21489:flowmailer X-Original-Sender: cedric.hombourger@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=NYtc12Nv; spf=pass (google.com: domain of fm-1212295-202511061515133bf611ea35000207a3-nza5ag@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1212295-202511061515133bf611ea35000207a3-nzA5aG@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Cedric Hombourger Reply-To: Cedric Hombourger Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The previous logic for conditionally adding the IMAGE variable to CUSTOMIZATION_VARS suffered from a Bitbake variable expansion timing issue. The original line `CUSTOMIZATION_VARS_IMAGE ?= "${IMAGE}"` would evaluate the `${IMAGE}` variable too early in the parsing process. If `IMAGE` had not yet been fully defined or resolved to its final value (e.g., `isar-image-base`), `CUSTOMIZATION_VARS_IMAGE` would incorrectly store the literal string `"${IMAGE}"`. Consequently, when `CUSTOMIZATION_VARS` was later appended using a Python expression that retrieved `CUSTOMIZATION_VARS_IMAGE`, it would receive this unexpanded literal string. This led to build failures and errors such as: ERROR: ... Unable to get checksum for ... ${IMAGE} SRC_URI entry ... Introduce a new Bitbake override, `:customization-for-images`, which is conditionally activated when `CUSTOMIZATION_FOR_IMAGES` is set (to preserve the initial semantic of 9a2919be). The `IMAGE` variable is then appended to `CUSTOMIZATION_VARS` specifically within this override context: `CUSTOMIZATION_VARS:append:customization-for-images = " ${IMAGE}"` By associating the append operation with an override, the expansion is deferred and ensures that `${IMAGE}` is properly resolved to its value before being added to `CUSTOMIZATION_VARS`. Fixes: 9a2919be Signed-off-by: Cedric Hombourger --- meta/classes/customization-base.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/customization-base.bbclass b/meta/classes/customization-base.bbclass index 82cad67e..7603460b 100644 --- a/meta/classes/customization-base.bbclass +++ b/meta/classes/customization-base.bbclass @@ -8,8 +8,8 @@ CUSTOMIZATIONS[doc] = "List of customization packages to be installed in images. CUSTOMIZATION_VARS ?= "${DISTRO} ${MACHINE}" CUSTOMIZATION_VARS[doc] = "List of variables that should be added to customization package names." -CUSTOMIZATION_VARS_IMAGE ?= "${IMAGE}" -CUSTOMIZATION_VARS:append = " ${@d.getVar('CUSTOMIZATION_VARS_IMAGE') if d.getVar('CUSTOMIZATION_FOR_IMAGES').strip() else ''}" +OVERRIDES:append = "${@ ':customization-for-images' if (d.getVar('CUSTOMIZATION_FOR_IMAGES') or '').strip() else '' }" +CUSTOMIZATION_VARS:append:customization-for-images = " ${IMAGE}" CUSTOMIZATION_VARS_PREFIXED ?= "${DISTRO}" CUSTOMIZATION_VARS_PREFIXED[doc] = "List of variables from CUSTOMIZATION_VARS that should be prefixed rather than suffixed to customization package names."