[1/2] isoimage-isohybrid-isar: fix error if source_param image_name is set

Message ID 20251126114431.20236-1-Quirin.Gylstorff@siemens.com
State Accepted, archived
Headers show
Series [1/2] isoimage-isohybrid-isar: fix error if source_param image_name is set | expand

Commit Message

Quirin Gylstorff Nov. 26, 2025, 11:43 a.m. UTC
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>

This fixes the following error:

 ERROR: _exec_cmd: export PATH=//sbin://usr/sbin://usr/bin://usr/bin/None://bin:None:$PATH;/usr/bin/python3-native/python3 /usr/bin/bmaptool create /tmp/isar-image-base-debian-bookworm-qemuamd64-iso.wic/tmp.wic.h061sjt6/isohybrid-efi-202511201339-cd.direct -o /tmp/isar-image-base-debian-bookworm-qemuamd64-iso.wic/tmp.wic.h061sjt6/isohybrid-efi-202511201339-cd.direct.bmap returned '1' instead of 0
| output: bmaptool: ERROR: An error occurred, here is the traceback:
| Traceback (most recent call last):
|   File "/usr/lib/python3/dist-packages/bmaptools/BmapCreate.py", line 200, in _open_image_file
|     self._f_image = open(self._image_path, 'rb')
|                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| FileNotFoundError: [Errno 2] No such file or directory: '/tmp/isar-image-base-debian-bookworm-qemuamd64-iso.wic/tmp.wic.h061sjt6/isohybrid-efi-202511201339-cd.direct'
|
| During handling of the above exception, another exception occurred:
|
| Traceback (most recent call last):
|   File "/usr/lib/python3/dist-packages/bmaptools/CLI.py", line 555, in create_command
|     creator = BmapCreate.BmapCreate(args.image, output, "sha256")
|               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|   File "/usr/lib/python3/dist-packages/bmaptools/BmapCreate.py", line 166, in __init__
|     self._open_image_file()
|   File "/usr/lib/python3/dist-packages/bmaptools/BmapCreate.py", line 202, in _open_image_file
|     raise Error("cannot open image file '%s': %s"
|
| bmaptool: ERROR: cannot open image file '/tmp/isar-image-base-debian-bookworm-qemuamd64-iso.wic/tmp.wic.h061sjt6/isohybrid-efi-202511201339-cd.direct': [Errno 2] No such file or directory: '/tmp/isar-image-base-debian-bookworm-qemuamd64-iso.wic/tmp.wic.h061sjt6/isohybrid-efi-202511201339-cd.direct'

Tested-by:     Herbert Bernecker <herbert.bernecker@siemens.com>
Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---

This is already broken in bitbake upstream and I will also sent the patch there.
Quirin
 meta/scripts/lib/wic/plugins/source/isoimage-isohybrid-isar.py | 1 +
 1 file changed, 1 insertion(+)

Comments

Zhihang Wei Nov. 28, 2025, 4:07 p.m. UTC | #1
Applied to next, thanks.

Zhihang

On 11/26/25 12:43, 'Quirin Gylstorff' via isar-users wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>
> This fixes the following error:
>
>   ERROR: _exec_cmd: export PATH=//sbin://usr/sbin://usr/bin://usr/bin/None://bin:None:$PATH;/usr/bin/python3-native/python3 /usr/bin/bmaptool create /tmp/isar-image-base-debian-bookworm-qemuamd64-iso.wic/tmp.wic.h061sjt6/isohybrid-efi-202511201339-cd.direct -o /tmp/isar-image-base-debian-bookworm-qemuamd64-iso.wic/tmp.wic.h061sjt6/isohybrid-efi-202511201339-cd.direct.bmap returned '1' instead of 0
> | output: bmaptool: ERROR: An error occurred, here is the traceback:
> | Traceback (most recent call last):
> |   File "/usr/lib/python3/dist-packages/bmaptools/BmapCreate.py", line 200, in _open_image_file
> |     self._f_image = open(self._image_path, 'rb')
> |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> | FileNotFoundError: [Errno 2] No such file or directory: '/tmp/isar-image-base-debian-bookworm-qemuamd64-iso.wic/tmp.wic.h061sjt6/isohybrid-efi-202511201339-cd.direct'
> |
> | During handling of the above exception, another exception occurred:
> |
> | Traceback (most recent call last):
> |   File "/usr/lib/python3/dist-packages/bmaptools/CLI.py", line 555, in create_command
> |     creator = BmapCreate.BmapCreate(args.image, output, "sha256")
> |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |   File "/usr/lib/python3/dist-packages/bmaptools/BmapCreate.py", line 166, in __init__
> |     self._open_image_file()
> |   File "/usr/lib/python3/dist-packages/bmaptools/BmapCreate.py", line 202, in _open_image_file
> |     raise Error("cannot open image file '%s': %s"
> |
> | bmaptool: ERROR: cannot open image file '/tmp/isar-image-base-debian-bookworm-qemuamd64-iso.wic/tmp.wic.h061sjt6/isohybrid-efi-202511201339-cd.direct': [Errno 2] No such file or directory: '/tmp/isar-image-base-debian-bookworm-qemuamd64-iso.wic/tmp.wic.h061sjt6/isohybrid-efi-202511201339-cd.direct'
>
> Tested-by:     Herbert Bernecker <herbert.bernecker@siemens.com>
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>
> This is already broken in bitbake upstream and I will also sent the patch there.
> Quirin
>   meta/scripts/lib/wic/plugins/source/isoimage-isohybrid-isar.py | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meta/scripts/lib/wic/plugins/source/isoimage-isohybrid-isar.py b/meta/scripts/lib/wic/plugins/source/isoimage-isohybrid-isar.py
> index b46527b8..690e291e 100644
> --- a/meta/scripts/lib/wic/plugins/source/isoimage-isohybrid-isar.py
> +++ b/meta/scripts/lib/wic/plugins/source/isoimage-isohybrid-isar.py
> @@ -533,3 +533,4 @@ class IsoImagePlugin(SourcePlugin):
>           os.remove(disk.path)
>           shutil.copy2(iso_img, full_path_iso)
>           shutil.copy2(full_path_iso, full_path)
> +        disk.path=full_path

Patch

diff --git a/meta/scripts/lib/wic/plugins/source/isoimage-isohybrid-isar.py b/meta/scripts/lib/wic/plugins/source/isoimage-isohybrid-isar.py
index b46527b8..690e291e 100644
--- a/meta/scripts/lib/wic/plugins/source/isoimage-isohybrid-isar.py
+++ b/meta/scripts/lib/wic/plugins/source/isoimage-isohybrid-isar.py
@@ -533,3 +533,4 @@  class IsoImagePlugin(SourcePlugin):
         os.remove(disk.path)
         shutil.copy2(iso_img, full_path_iso)
         shutil.copy2(full_path_iso, full_path)
+        disk.path=full_path